[JIRA] (JENKINS-36322) NaN execution time may appear if a stage gets terminated incorrectly

[jglick@cloudbees.com (JIRA)]

Jesse Glick created an issue

Jenkins / JENKINS-36322 NaN execution time may appear if a stage gets terminated incorrectly Issue Type: Bug Assignee: Sam Van Oort Attachments: workflow-with-nested-stage-declarations.png Components: pipeline-stage-view-plugin Created: 2016/Jun/29 3:10 PM Priority: Minor Reporter: Jesse Glick Add Comment

This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)

[svanoort@cloudbees.com (JIRA)]

Sam Van Oort commented on JENKINS-36322

Re: NaN execution time may appear if a stage gets terminated incorrectly Easy fix: UI templates, don't display an Average Stage time if averageDurationMillisNoPause is NaN, not set, or not > 0. Change to an ifCond statement for that number, not just an if in the template. https://github.com/jenkinsci/pipeline-stage-view-plugin/blob/master/ui/src/main/js/view/templates/pipeline-staged.hbs#L24 and More comprehensive fix: Generally fix the averageDurationMillisNoPause computation & add Jasmine tests for a variety of edge cases (should never see NaN). https://github.com/jenkinsci/pipeline-stage-view-plugin/blob/master/ui/src/main/js/model/runs-stage-grouped.js#L128 - endToEndRuns and https://github.com/jenkinsci/pipeline-stage-view-plugin/blob/master/ui/src/main/js/model/runs-stage-grouped.js#L168 need closer inspection here.

Add Comment

[svanoort@cloudbees.com (JIRA)]

Sam Van Oort commented on JENKINS-36322

Re: NaN execution time may appear if a stage gets terminated incorrectly

Similar class of issue to JENKINS-34644 (something fishy in average timing calculation) and JENKINS-36023

Add Comment

[svanoort@cloudbees.com (JIRA)]

Sam Van Oort commented on JENKINS-36322

Re: NaN execution time may appear if a stage gets terminated incorrectly

From my in-flight investigation, I strongly suspect this is because one or more stages have no timing info (field ), so they return NaN when you either try to read the value or parse it as an integer.

Add Comment

[svanoort@cloudbees.com (JIRA)]

Sam Van Oort edited a comment on JENKINS-36322

Re: NaN execution time may appear if a stage gets terminated incorrectly

From my in-flight investigation, I strongly suspect this is because one or more stages have no timing info (field ), so they return NaN when you either try to read the value or parse it as an integer.   Hiding NaN in UI templates will mask the issue but all the math around the estimates and average duration will be screwed up (NaN is like a virus). Better to handle NaN/undefined at the source and convert to 0 duration/timing for the analysis.

Add Comment

[jwillemsen@remedy.nl (JIRA)]

Johnny Willemsen updated an issue

Jenkins / JENKINS-36322

NaN execution time may appear if a stage gets terminated incorrectly

Change By: Johnny Willemsen Attachment: fp5mti.png

Add Comment

[jwillemsen@remedy.nl (JIRA)]

Johnny Willemsen commented on JENKINS-36322

Re: NaN execution time may appear if a stage gets terminated incorrectly Added a screen dump with similar output but "NaNy NaNd"

Add Comment

[scm_issue_link@java.net (JIRA)]

SCM/JIRA link daemon commented on JENKINS-36322

Re: NaN execution time may appear if a stage gets terminated incorrectly

Code changed in jenkins User: Sam Van Oort Path: ui/src/main/js/view/templates/pipeline-staged.hbs http://jenkins-ci.org/commit/pipeline-stage-view-plugin/a11279d0d3bb3ad133fdde26407a95a5637265bb Log: Do not display average durations that are 0 or NaN - JENKINS-36322

Add Comment

[svanoort@cloudbees.com (JIRA)]

Sam Van Oort started work on JENKINS-36322

Change By: Sam Van Oort Status: Open In Progress

Add Comment

[vivek.pandey@gmail.com (JIRA)]

Vivek Pandey updated an issue

Jenkins / JENKINS-36322

NaN execution time may appear if a stage gets terminated incorrectly

Change By: Vivek Pandey Labels: stageview-frontend triaged-2018-11

Add Comment

This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

[jwillemsen@remedy.nl (JIRA)]

Johnny Willemsen updated an issue

Jenkins / JENKINS-36322 NaN execution time may appear if a stage gets terminated incorrectly

Change By: Johnny Willemsen Attachment: Screenshot_20181119_161957.png

Add Comment

[jwillemsen@remedy.nl (JIRA)]

Johnny Willemsen commented on JENKINS-36322

Re: NaN execution time may appear if a stage gets terminated incorrectly {{Also }}NaNy NaNd is shown for a pipeline which has a step with an expression, use the following pipeline job, just update label to match something in your jenkins   String foo pipeline {    agent {   node {   label 'fc29' {{  }}} {{ }}} stages { {{ stage('Create postbuild.sh') {}} {{ when {}} {{ expression { foo == "bar" }}} {{ }}} {{ steps {}} {{ writeFile file: 'postbuild.sh', text: "bar"}} {{ }}} {{ }}} {{ }}} }

Add Comment

[jwillemsen@remedy.nl (JIRA)]

Johnny Willemsen edited a comment on JENKINS-36322

Re: NaN execution time may appear if a stage gets terminated incorrectly

{{ Also }} NaNy NaNd is shown for a pipeline which has a step with an expression, use the following pipeline job, just update label to match something in your jenkins

{quote}   {{ String foo }}   {{ String foo

pipeline { }} {{   agent { }} {{  node { }} {{  label 'fc29' }} {{  } }} {{ } }} {{ stages { }} {{ stage('Create postbuild.sh') { }} {{ when { }} {{ expression \{ foo == "bar" } }} {{ } }} {{ steps { }} {{ writeFile file: 'postbuild.sh', text: "bar" } } {{ } }} {{ } }} {{ } }}

{ { quote } }}   {{!Screenshot_20181119_161957.png|thumbnail!}}

Add Comment

[jwillemsen@remedy.nl (JIRA)]

Johnny Willemsen edited a comment on JENKINS-36322

Re: NaN execution time may appear if a stage gets terminated incorrectly

Also NaNy NaNd is shown for a pipeline which has a step with an expression, use the following pipeline job, just update label to match something in your jenkins {quote}

{ { noformat } }  String foo pipeline foopipeline { agent { node { label 'fc29' } }

stages { stage('Create postbuild.sh') { when { expression \ { foo == "bar" } } steps { writeFile file: 'postbuild.sh', text: "bar" } } } }

{ quote noformat } {{!Screenshot_20181119_161957.png|thumbnail!}}

Add Comment

[jwillemsen@remedy.nl (JIRA)]

Johnny Willemsen edited a comment on JENKINS-36322

Re: NaN execution time may appear if a stage gets terminated incorrectly

Also NaNy NaNd is shown for a pipeline which has a step with an expression, use the following pipeline job, just update label to match something in your jenkins

{noformat} String foopipeline foo pipeline {     agent {       node {         label 'fc29'       }     }

stages {       stage('Create postbuild.sh') {         when {           expression { foo == "bar" }         }         steps {           writeFile file: 'postbuild.sh', text: "bar"         }       }   }

}{noformat} {{!Screenshot_20181119_161957.png|thumbnail!}}

Add Comment

[jsoref+jenkins@gmail.com (JIRA)]

Josh Soref assigned an issue to Josh Soref

Jenkins / JENKINS-36322

NaN execution time may appear if a stage gets terminated incorrectly

Change By: Josh Soref Assignee: Sam Van Oort Josh Soref

Add Comment

[jsoref+jenkins@gmail.com (JIRA)]

Josh Soref assigned an issue to Sam Van Oort

Jenkins / JENKINS-36322 NaN execution time may appear if a stage gets terminated incorrectly

Change By: Josh Soref Assignee: Josh Soref Sam Van Oort

Add Comment

[jsoref+jenkins@gmail.com (JIRA)]

Josh Soref commented on JENKINS-36322

Re: NaN execution time may appear if a stage gets terminated incorrectly The NaNd/NaNy problem will go away with the next release – https://github.com/jenkinsci/pipeline-stage-view-plugin/pull/53

Add Comment

[dnusbaum@cloudbees.com (JIRA)]

Devin Nusbaum resolved as Fixed

Fixed in version 2.11 of Pipeline Stage View.

Jenkins / JENKINS-36322

NaN execution time may appear if a stage gets terminated incorrectly

Change By: Devin Nusbaum Status: In Progress Resolved Resolution: Fixed Released As: pipeline-stage-view 2.11

Add Comment