[JIRA] (JENKINS-46144) Update vault-java-driver version

From the README.md of the vault-java-driverL "3.0.0: This is a breaking-change release, with several updates."

Tests hang during `com.datapipe.jenkins.vault.it.folder.FolderIT` , not sure why yet. will look into it. Is there a need to update to 3.0.0+ right now?

This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)

peter.a.tierno@gmail.com (JIRA)

unread,

May 2, 2018, 11:13:02 PM5/2/18

to jenkinsc...@googlegroups.com

Peter Tierno edited a comment on

From the README.md of the vault-java- driverL driver - "*3.0.0*: This is a breaking-change release, with several updates."

Tests hang during `com.datapipe.jenkins.vault.it.folder.FolderIT` , not sure why yet. will look into it. Is there a need to update to 3.0.0+ right now?

massdosage@java.net (JIRA)

unread,

May 23, 2018, 9:34:02 AM5/23/18

to jenkinsc...@googlegroups.com

massdosage commented on

FWIW we've noticed a potential version with vault-java-driver where it appears to be using an old/no longer documented API to deal with leases (see https://github.com/BetterCloud/vault-java-driver/issues/117). If this is acknowledged as an issue and a fix is made then there would be a case for upgrading the plugin in order to maintain compatibility with future versions of Vault that might remove these calls. Of course this upgrade might in turn mean the plugin doesn't work with older versions of Vault that perhaps don't have the leases calls as now documented by Vault. Either way I tried building the plugin locally using 3.1.0 of the driver, I had to make a single line code change in order to get it to compile but all the tests passed no problem. I'd be happy to raise a PR for that if of any interest.

peter.a.tierno@gmail.com (JIRA)

unread,

Jun 1, 2018, 4:57:01 PM6/1/18

to jenkinsc...@googlegroups.com

Peter Tierno commented on

massdosage PR's are ALWAYS welcome.

peter.a.tierno@gmail.com (JIRA)

unread,

Jun 1, 2018, 6:41:01 PM6/1/18

to jenkinsc...@googlegroups.com

Peter Tierno edited a comment on

[~massdosage] PR's are ALWAYS welcome. I can look into/handle backwards compatibility before a release is shipped.

massdosage@java.net (JIRA)

unread,

Jun 18, 2018, 11:03:03 AM6/18/18

to jenkinsc...@googlegroups.com

massdosage commented on

OK, well, our problem is in vault-java-driver where I raised the above issue on GitHub but haven't received a response. That would need to be sorted out first and released, and then the plugin updated to use that version of the driver. If/when that happens I'll happily help out with the plugin (I've also offered to help out with the driver).

josephp90@gmail.com (JIRA)

unread,

Aug 20, 2019, 2:06:03 AM8/20/19

to jenkinsc...@googlegroups.com

Joseph Petersen resolved as Fixed

Updated to 4.0.0

Jenkins /