[JIRA] (JENKINS-58926) Refactor bot command CLI and results processing (regex filter, line counts) into a single implementation to be shared by different commands

1 view
Skip to first unread message

jimklimov@gmail.com (JIRA)

unread,
Aug 14, 2019, 7:56:02 AM8/14/19
to jenkinsc...@googlegroups.com
Jim Klimov created an issue
 
Jenkins / Improvement JENKINS-58926
Refactor bot command CLI and results processing (regex filter, line counts) into a single implementation to be shared by different commands
Issue Type: Improvement Improvement
Assignee: Jim Klimov
Components: instant-messaging-plugin, ircbot-plugin
Created: 2019-08-14 11:55
Priority: Minor Minor
Reporter: Jim Klimov

By now there are two copies of CLI loop for argument processing and a regex filter of output lines (and of counting them), in "currentlyBuilding" and "queue" bot commands.

With more commands on the plate that could be improved with these features, it makes sense to rearrange the codebase so this filtering and counting can be implemented in one place, with only the command-specific logic preparing a multiline buffer of text - that is then postprocessed and sent to a IM channel(s) by the common code.

Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)
Reply all
Reply to author
Forward
0 new messages