[JIRA] (JENKINS-61788) jclouds single-use slave never cleaned up

jclouds single-use slave never cleaned up

Issue Type:	Improvement
Assignee:	Fritz Elfert
Components:	jclouds-plugin
Created:	2020-04-02 18:47
Environment:	Jenkins 2.229 jclouds plugin 2.17
Priority:	Minor
Reporter:	Major Hayden

When I use the jclouds plugin to spawn instances at DigitalOcean and EC2, I noticed that the single-use slaves are never removed. They are marked offline as soon as the job finishes, but they remain offline in Jenkins and they are active with the cloud provider.

As soon as the job finishes, I see this in the logs:

 
                                                                 2020-04-02 18:30:42.634+0000 [id=3070]	WARNING	j.p.j.c.JCloudsOneOffSlave$JCloudsOneOffSlaveDisposer#tearDown: Taking single-use slave [COMPUTER_NAME] offline.

I let it sit for two hours and nothing changed. I had to delete the agent manually from inside Jenkins' build executors listing.

Am I missing a step? I'll gladly turn on more debug logging if that would help diagnose the issue.

This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)

fritz@fritz-elfert.de (JIRA)

unread,

Apr 11, 2020, 10:16:04 AM4/11/20

to jenkinsc...@googlegroups.com

Fritz Elfert started work on

Change By:	Fritz Elfert
Status:	Open In Progress

fritz@fritz-elfert.de (JIRA)

unread,

Apr 11, 2020, 10:16:05 AM4/11/20

to jenkinsc...@googlegroups.com

Fritz Elfert commented on

Well this turned out to be a bug. The retention time for the single-use slaves was never reset to zero.

Therefore, the normal RetentionStrategy handler never touched them. Will fix this asap.

-Fritz

fritz@fritz-elfert.de (JIRA)

unread,

Apr 11, 2020, 10:41:03 AM4/11/20

to jenkinsc...@googlegroups.com

Fritz Elfert commented on

Please try this build. If this fixes the problem for you, I will crate a new release.

fritz@fritz-elfert.de (JIRA)

unread,

Apr 11, 2020, 10:41:03 AM4/11/20

to jenkinsc...@googlegroups.com

Fritz Elfert edited a comment on

Please try [this build|https://ci.jenkins.io/job/Plugins/job/jclouds-plugin/job/master/68/artifact/jclouds-plugin/target/jclouds-jenkins.hpi]. If this fixes the problem for you, I will crate create a new release.

fritz@fritz-elfert.de (JIRA)

unread,

Apr 11, 2020, 10:42:02 AM4/11/20

to jenkinsc...@googlegroups.com

Fritz Elfert updated

Jenkins /

jclouds single-use slave never cleaned up

Change By:	Fritz Elfert
Status:	In Progress Fixed but Unreleased
Resolution:	Fixed

major@mhtx.net (JIRA)

unread,

Apr 13, 2020, 8:59:03 AM4/13/20

to jenkinsc...@googlegroups.com

Major Hayden commented on

Thanks for the quick fix. I'll try to get a look at this as soon as I can.

fritz@fritz-elfert.de (JIRA)

unread,

Apr 25, 2020, 4:40:02 AM4/25/20

to jenkinsc...@googlegroups.com

Fritz Elfert updated

As I got no further feedback, I now released v1.18 and close this issue.

Feel free to reopen this issue, if you are not satisfied with the solution.

Note: A slight delay (~ 1min) is still happening between marking a slave offline and actually deleting the instance in the cloud. This works as designed.

Jenkins /

jclouds single-use slave never cleaned up

Change By:	Fritz Elfert
Status:	Fixed but Unreleased Closed