[JIRA] (JENKINS-41012) when {branch} stage conditional is busted (mostly)

[smazurov@gmail.com (JIRA)]

Stepan Mazurov updated an issue

Jenkins / JENKINS-41012 when {branch} stage conditional is busted (mostly) Change By: Stepan Mazurov Summary: when { } branch } stage conditional is busted (mostly) Add Comment

This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)

[andrew.bayer@gmail.com (JIRA)]

Andrew Bayer assigned an issue to rsandell

Jenkins / JENKINS-41012 when {branch} stage conditional is busted (mostly)

Change By: Andrew Bayer Assignee: Andrew Bayer rsandell

Add Comment

[andrew.bayer@gmail.com (JIRA)]

Andrew Bayer commented on JENKINS-41012

Re: when {branch} stage conditional is busted (mostly) Bobby, could you take a look?

Add Comment

[andrew.bayer@gmail.com (JIRA)]

Andrew Bayer assigned an issue to Andrew Bayer

Jenkins / JENKINS-41012

when {branch} stage conditional is busted (mostly)

Change By: Andrew Bayer Assignee: rsandell Andrew Bayer

Add Comment

[andrew.bayer@gmail.com (JIRA)]

Andrew Bayer started work on JENKINS-41012

Change By: Andrew Bayer Status: Open In Progress

Add Comment

[andrew.bayer@gmail.com (JIRA)]

Andrew Bayer commented on JENKINS-41012

Re: when {branch} stage conditional is busted (mostly) Check that, I got it. getContextVariables() basically did nothing useful - it was always getting a null step and so not giving us a context to work with. I've got a branch that'll be up for review momentarily that changes the branch and env conditions to get passed the value to check against rather than trying to find it for themselves. Also we only had negative tests for branch and env, which is...embarrassing.

Add Comment

[andrew.bayer@gmail.com (JIRA)]

Andrew Bayer updated JENKINS-41012

Jenkins / JENKINS-41012

when {branch} stage conditional is busted (mostly)

Change By: Andrew Bayer Status: In Progress Review

Add Comment

[andrew.bayer@gmail.com (JIRA)]

Andrew Bayer commented on JENKINS-41012

Re: when {branch} stage conditional is busted (mostly) PR up at https://github.com/jenkinsci/pipeline-model-definition-plugin/pull/91 - should do the trick. Sorry about this!

Add Comment

[scm_issue_link@java.net (JIRA)]

SCM/JIRA link daemon commented on JENKINS-41012

Re: when {branch} stage conditional is busted (mostly)

Code changed in jenkins User: Andrew Bayer Path: pipeline-model-definition/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/when/impl/BranchConditional.java pipeline-model-definition/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/when/impl/EnvironmentConditional.java pipeline-model-definition/src/main/resources/org/jenkinsci/plugins/pipeline/modeldefinition/when/impl/BranchConditionalScript.groovy pipeline-model-definition/src/main/resources/org/jenkinsci/plugins/pipeline/modeldefinition/when/impl/EnvironmentConditionalScript.groovy pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/AbstractModelDefTest.java pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/BasicModelDefTest.java pipeline-model-definition/src/test/resources/json/whenBranch.json pipeline-model-definition/src/test/resources/json/whenBranchFalse.json pipeline-model-definition/src/test/resources/json/whenEnv.json pipeline-model-definition/src/test/resources/json/whenEnvFalse.json pipeline-model-definition/src/test/resources/whenBranch.groovy pipeline-model-definition/src/test/resources/whenBranchFalse.groovy pipeline-model-definition/src/test/resources/whenBranchTrue.groovy pipeline-model-definition/src/test/resources/whenEnv.groovy pipeline-model-definition/src/test/resources/whenEnvFalse.groovy pipeline-model-definition/src/test/resources/whenEnvTrue.groovy http://jenkins-ci.org/commit/pipeline-model-definition-plugin/4af77f00e32e2e6c459c15564ca84b4c53a6332c Log: [FIXED JENKINS-41012] Actually get when branch/env to work Stop relying on the step context, since that wasn't actually getting provided, and instead pass in the needed arguments from the *Script class. Also make sure we actually have tests for all the conditions passing, not just failing. Oy, but I feel silly there.

Add Comment

[andrew.bayer@gmail.com (JIRA)]

Andrew Bayer updated JENKINS-41012

Pushing out an emergency 0.8.2 release momentarily with this fix. Again, sorry for letting this slip through!

Jenkins / JENKINS-41012

when {branch} stage conditional is busted (mostly)

Change By: Andrew Bayer Status: In Review Resolved Resolution: Fixed

Add Comment

[smazurov@gmail.com (JIRA)]

Stepan Mazurov commented on JENKINS-41012

Re: when {branch} stage conditional is busted (mostly) No worries, this is beta software after all, thanks for taking care of it!

Add Comment

[andrew.bayer@gmail.com (JIRA)]

Andrew Bayer commented on JENKINS-41012

Re: when {branch} stage conditional is busted (mostly)

Stepan Mazurov Nonetheless, I feel sheepish. Shoulda tested better! But the release has been cut and should show up in the update center in a couple hours. Thanks for catching this and supplying such an excellent bug report - the expression comparison was really helpful, since in our test environment, we don't actually get BRANCH_NAME set by the SCM, so if I hadn't had that validation that it does get set in the real world, I'd've gone down some rathole to figure out what could be done. =)

Add Comment

[smazurov@gmail.com (JIRA)]

Stepan Mazurov commented on JENKINS-41012

Re: when {branch} stage conditional is busted (mostly)

Glad I could help! Thank you for those words, I appreciate it.

Add Comment

[bitwiseman@gmail.com (JIRA)]

Liam Newman closed an issue as Fixed

Bulk closing resolved issues.

Jenkins / JENKINS-41012

when {branch} stage conditional is busted (mostly)

Change By: Liam Newman Status: Resolved Closed

Add Comment

This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)