[JIRA] [core] (JENKINS-32326) broken HTTP_PROXY handling on jenkins-slave (JNLP)

[valentin.maechler@gmail.com (JIRA)]

Valentin Maechler created an issue

Jenkins / JENKINS-32326 broken HTTP_PROXY handling on jenkins-slave (JNLP) Issue Type: Bug Assignee: Unassigned Components: core, remoting Created: 07/Jan/16 8:49 AM Priority: Minor Reporter: Valentin Maechler broken HTTP_PROXY handling on jenkins-slave (JNLP) The proxy exclusion list (http.nonProxyHosts, no_proxy) is not taken into account on the jenkins-slave side. This has been observed in our jenkins master/slave environment which uses JNLP. Support for HTTP_PROXY handling on jenkins-slave side has been added with jenkins version 1.606. Unfortunately that does not take the proxy exclusion list into account (e.g. defined by no_proxy env variable on linux). This forces the slave to always use the proxy. Even for destinations which would be excluded by no_proxy. Jenkins uses org.jenkins-ci.main:remoting for handling http proxy functionality. Jenkins includes version 2.53.2 of org.jenkins-ci.main:remoting which contains the error described above. possible solution: 1.) create new release of org.jenkins-ci.main:remoting which *already *contains the fix in it's master branch. 2.) update jenkins' to use this new version of org.jenkins-ci.main:remoting see also: commit of fix in master branch of org.jenkins-ci.main:remoting https://github.com/jenkinsci/remoting/commit/56d30acb89f5626320d6b47585053674a5fdfb78 Add Comment

This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265)

[valentin.maechler@gmail.com (JIRA)]

Valentin Maechler updated an issue

Jenkins / JENKINS-32326 broken HTTP_PROXY handling on jenkins-slave (JNLP)

Change By: Valentin Maechler *broken HTTP_PROXY handling on jenkins-slave (JNLP)*

The proxy exclusion list (http.nonProxyHosts, no_proxy) is not taken into account on the jenkins-slave side. This has been observed in our jenkins master/slave environment which uses JNLP. Support for HTTP_PROXY handling on jenkins-slave side has been added with jenkins version 1.606. Unfortunately that does not take the proxy exclusion list into account (e.g. defined by no_proxy env variable on linux). This forces the slave to always use the proxy. Even for destinations which would be excluded by no_proxy.

Jenkins uses [org.jenkins-ci.main:remoting|https://github.com/jenkinsci/remoting] for handling http proxy functionality.  Jenkins includes version 2.53.2 of  [org.jenkins-ci.main:remoting|https://github.com/jenkinsci/remoting] which contains the error described above. possible solution: 1.) create new release of  [org.jenkins-ci.main:remoting|https://github.com/jenkinsci/remoting] which *already *contains the fix in it's master branch. 2.) update jenkins' to use this new version of  [org.jenkins-ci.main:remoting|https://github.com/jenkinsci/remoting] see also: - commit of fix in master branch of org.jenkins-ci.main:remoting     [https://github.com/jenkinsci/remoting/commit/56d30acb89f5626320d6b47585053674a5fdfb78]

Add Comment

[dbeck@cloudbees.com (JIRA)]

Daniel Beck assigned an issue to Oleg Nenashev

Jenkins / JENKINS-32326 broken HTTP_PROXY handling on jenkins-slave (JNLP)

Change By: Daniel Beck Assignee: Oleg Nenashev

Add Comment

[public@etiennebec.fr (JIRA)]

Etienne Bec commented on JENKINS-32326

Re: broken HTTP_PROXY handling on jenkins-slave (JNLP) We're encountering the same issue (see comment section of JENKINS-28289 for further details). It should also be noted that the proxy configuration defined by the system properties does not have precedence over the one defined by the environment variables. Indeed if you set both, you would expect the slave to actually work because http.nonProxyHosts is automatically taken in account by the JVM. But no, looks like some part rely on http_proxy (and obviously don't use no_proxy). Unless you unset all your proxy env var, the slave won't work even if your system properties are correct. It means that on a host where you need to set those env var, there's no workaround to make the slave work.

Add Comment

[public@etiennebec.fr (JIRA)]

Etienne Bec started work on JENKINS-32326

Change By: Etienne Bec Status: Open In Progress

Add Comment

[public@etiennebec.fr (JIRA)]

Etienne Bec assigned an issue to Etienne Bec

Jenkins / JENKINS-32326

broken HTTP_PROXY handling on jenkins-slave (JNLP)

Change By: Etienne Bec Assignee: Oleg Nenashev Etienne Bec

Add Comment

[public@etiennebec.fr (JIRA)]

Etienne Bec assigned an issue to Oleg Nenashev

Jenkins / JENKINS-32326 broken HTTP_PROXY handling on jenkins-slave (JNLP)

Change By: Etienne Bec Assignee: Etienne Bec Oleg Nenashev

Add Comment

[scm_issue_link@java.net (JIRA)]

SCM/JIRA link daemon commented on JENKINS-32326

Re: broken HTTP_PROXY handling on jenkins-slave (JNLP) Code changed in jenkins User: Etienne Bec Path: src/main/java/hudson/remoting/Util.java src/test/java/hudson/remoting/UtilTest.java http://jenkins-ci.org/commit/remoting/a1bdc233aee6dd13fd76f488adb2aa436a7e74f5 Log: [FIXED JENKINS-32326] Support no_proxy environment variable (#84) Change-Id: I894e7831677ee39c37020b0fab0e6db5b290f9ca

Add Comment

[scm_issue_link@java.net (JIRA)]

SCM/JIRA link daemon resolved as Fixed

Jenkins / JENKINS-32326

broken HTTP_PROXY handling on jenkins-slave (JNLP)

Change By: SCM/JIRA link daemon Status: In Progress Resolved Resolution: Fixed

Add Comment

[scm_issue_link@java.net (JIRA)]

SCM/JIRA link daemon commented on JENKINS-32326

Re: broken HTTP_PROXY handling on jenkins-slave (JNLP)

Code changed in jenkins User: Oleg Nenashev Path: pom.xml http://jenkins-ci.org/commit/jenkins/d9f12b0e614d9598221c571001aa43c018b21e25 Log: Update remoting to 2.60 Changes summary: Fixed issues: JENKINS-22722(https://issues.jenkins-ci.org/browse/JENKINS-22722) - Make the channel reader tolerant against Socket timeouts. (https://github.com/jenkinsci/remoting/pull/80) JENKINS-32326 (https://issues.jenkins-ci.org/browse/JENKINS-32326) - Support no_proxy environment variable. (https://github.com/jenkinsci/remoting/pull/84) JENKINS-35190(https://issues.jenkins-ci.org/browse/JENKINS-35190) - Do not invoke PingFailureAnalyzer for agent=>master ping failures. (https://github.com/jenkinsci/remoting/pull/85) JENKINS-31256(https://issues.jenkins-ci.org/browse/JENKINS-31256) - <code>hudson.Remoting.Engine#waitForServerToBack</code> now uses credentials for connection. (https://github.com/jenkinsci/remoting/pull/87) JENKINS-35494(https://issues.jenkins-ci.org/browse/JENKINS-35494) - Fix issues in file management in <code>hudson.remoting.Launcher</code> (main executable class). (https://github.com/jenkinsci/remoting/pull/88) Enhancements: Ensure a message is logged if remoting fails to override the default <code>ClassFilter</code>. (https://github.com/jenkinsci/remoting/pull/80)

Add Comment

[scm_issue_link@java.net (JIRA)]

SCM/JIRA link daemon commented on JENKINS-32326

Re: broken HTTP_PROXY handling on jenkins-slave (JNLP)

Code changed in jenkins User: Oleg Nenashev Path: pom.xml

http://jenkins-ci.org/commit/jenkins/c718516adfddeb10cbf616ce37c619cc6bbafd53 Log: Update remoting to 2.60 (#2403)

Changes summary: Fixed issues: JENKINS-22722(https://issues.jenkins-ci.org/browse/JENKINS-22722) - Make the channel reader tolerant against Socket timeouts. (https://github.com/jenkinsci/remoting/pull/80) JENKINS-32326 (https://issues.jenkins-ci.org/browse/JENKINS-32326) - Support no_proxy environment variable. (https://github.com/jenkinsci/remoting/pull/84) JENKINS-35190(https://issues.jenkins-ci.org/browse/JENKINS-35190) - Do not invoke PingFailureAnalyzer for agent=>master ping failures. (https://github.com/jenkinsci/remoting/pull/85) JENKINS-31256(https://issues.jenkins-ci.org/browse/JENKINS-31256) - <code>hudson.Remoting.Engine#waitForServerToBack</code> now uses credentials for connection. (https://github.com/jenkinsci/remoting/pull/87) JENKINS-35494(https://issues.jenkins-ci.org/browse/JENKINS-35494) - Fix issues in file management in <code>hudson.remoting.Launcher</code> (main executable class). (https://github.com/jenkinsci/remoting/pull/88) Enhancements: Ensure a message is logged if remoting fails to override the default <code>ClassFilter</code>. (https://github.com/jenkinsci/remoting/pull/80)

Add Comment

[o.v.nenashev@gmail.com (JIRA)]

Oleg Nenashev commented on JENKINS-32326

Re: broken HTTP_PROXY handling on jenkins-slave (JNLP)

Releases: remoting-2.60 and jenkins-2.9

Add Comment

[aheritier@apache.org (JIRA)]

Arnaud Héritier updated an issue

Jenkins / JENKINS-32326

broken HTTP_PROXY handling on jenkins-slave (JNLP)

Change By: Arnaud Héritier Labels: lts-candidate

Add Comment

This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)

[ogondza@gmail.com (JIRA)]

Oliver Gondža updated an issue

Jenkins / JENKINS-32326 broken HTTP_PROXY handling on jenkins-slave (JNLP)

Change By: Oliver Gondža Labels: 2.7.2-fixed lts-candidate

Add Comment

[ogondza@gmail.com (JIRA)]