[JIRA] (JENKINS-40607) Fix Findbugs errors

1 view
Skip to first unread message

egutierrez@cloudbees.com (JIRA)

unread,
Dec 21, 2016, 10:46:02 AM12/21/16
to jenkinsc...@googlegroups.com
Evaristo Gutierrez created an issue
 
Jenkins / Task JENKINS-40607
Fix Findbugs errors
Issue Type: Task Task
Assignee: Evaristo Gutierrez
Components: git-plugin
Created: 2016/Dec/21 3:45 PM
Priority: Minor Minor
Reporter: Evaristo Gutierrez
  • Fix some errors detected by Findbugs.
  • Try to remove some of the ones excluded in the filter.
Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)
Atlassian logo

egutierrez@cloudbees.com (JIRA)

unread,
Dec 21, 2016, 10:54:01 AM12/21/16
to jenkinsc...@googlegroups.com
Evaristo Gutierrez started work on Task JENKINS-40607
 
Change By: Evaristo Gutierrez
Status: Open In Progress

egutierrez@cloudbees.com (JIRA)

unread,
Dec 21, 2016, 11:11:01 AM12/21/16
to jenkinsc...@googlegroups.com
Change By: Evaristo Gutierrez
Status: In Progress Review

mark.earl.waite@gmail.com (JIRA)

unread,
Dec 21, 2016, 11:54:01 AM12/21/16
to jenkinsc...@googlegroups.com
Mark Waite commented on Task JENKINS-40607
 
Re: Fix Findbugs errors

I don't get a lot of value out of "placeholder" bug reports. Is this bug report created solely because someone has a standard process that requires any pull request to have a matching bug report? If so, I'm fine with that, though it seems like unnecessary overhead for something which doesn't affect users and won't be detected by users.

egutierrez@cloudbees.com (JIRA)

unread,
Dec 22, 2016, 2:51:01 AM12/22/16
to jenkinsc...@googlegroups.com
Evaristo Gutierrez commented on Task JENKINS-40607
 
Re: Fix Findbugs errors

I prefer having a ticket that "backups" any work done, that's why I created it. But yes, I agree it's not something that affects users so that's why I created a task, I did not pretend this to be acknowledged as a bug report.

scm_issue_link@java.net (JIRA)

unread,
Jan 23, 2017, 2:39:01 PM1/23/17
to jenkinsc...@googlegroups.com
SCM/JIRA link daemon commented on Task JENKINS-40607
 
Re: Fix Findbugs errors

Code changed in jenkins
User: Mark Waite
Path:
src/findbugs/excludesFilter.xml
src/main/java/hudson/plugins/git/GitSCM.java
src/main/java/hudson/plugins/git/GitStatus.java
src/main/java/hudson/plugins/git/SubmoduleCombinator.java
src/main/java/jenkins/plugins/git/AbstractGitSCMSource.java
src/main/java/jenkins/plugins/git/GitSCMFileSystem.java
src/test/java/hudson/plugins/git/extensions/impl/PathRestrictionTest.java
http://jenkins-ci.org/commit/git-plugin/c60027f816fcd32df7cd0917921ab111782e8709
Log:
Merge pull request #460 from varyvol/JENKINS-40607

JENKINS-40607 Fix some Findbugs errors

Compare: https://github.com/jenkinsci/git-plugin/compare/b2744bf39fe5...c60027f816fc

scm_issue_link@java.net (JIRA)

unread,
Jan 23, 2017, 2:39:02 PM1/23/17
to jenkinsc...@googlegroups.com
 
Re: Fix Findbugs errors

Code changed in jenkins
User: Evaristo Gutiérrez


Path:
src/findbugs/excludesFilter.xml
src/main/java/hudson/plugins/git/GitSCM.java
src/main/java/hudson/plugins/git/GitStatus.java
src/main/java/hudson/plugins/git/SubmoduleCombinator.java
src/main/java/jenkins/plugins/git/AbstractGitSCMSource.java
src/main/java/jenkins/plugins/git/GitSCMFileSystem.java
src/test/java/hudson/plugins/git/extensions/impl/PathRestrictionTest.java

http://jenkins-ci.org/commit/git-plugin/807eb3703f495ed00321a54a9d2e8a90494a5f3d
Log:
JENKINS-40607 Fix two Findbugs errors that were excluded and two that weren't. Remove some used imports.

scm_issue_link@java.net (JIRA)

unread,
Jan 23, 2017, 2:39:02 PM1/23/17
to jenkinsc...@googlegroups.com

Code changed in jenkins
User: Evaristo Gutiérrez
Path:

pom.xml
src/main/java/hudson/plugins/git/GitPublisher.java
src/main/java/hudson/plugins/git/GitSCM.java
src/main/java/hudson/plugins/git/UserRemoteConfig.java
src/main/java/jenkins/plugins/git/GitSCMFileSystem.java
src/main/resources/hudson/plugins/git/BranchSpec/config_ja.properties
src/main/resources/hudson/plugins/git/BranchSpec/help-name_ja.html
src/main/resources/hudson/plugins/git/ChangelogToBranchOptions/config.jelly
src/main/resources/hudson/plugins/git/ChangelogToBranchOptions/config_ja.properties
src/main/resources/hudson/plugins/git/ChangelogToBranchOptions/help-compareRemote_ja.html
src/main/resources/hudson/plugins/git/ChangelogToBranchOptions/help-compareTarget_ja.html
src/main/resources/hudson/plugins/git/GitChangeSetList/digest.jelly
src/main/resources/hudson/plugins/git/GitChangeSetList/digest_ja.properties
src/main/resources/hudson/plugins/git/GitChangeSetList/index.jelly
src/main/resources/hudson/plugins/git/GitChangeSetList/index_ja.properties
src/main/resources/hudson/plugins/git/GitPublisher/config_ja.properties
src/main/resources/hudson/plugins/git/GitPublisher/help-branchesToPush_ja.html
src/main/resources/hudson/plugins/git/GitPublisher/help-notesToPush_ja.html
src/main/resources/hudson/plugins/git/GitPublisher/help-pushMerge_ja.html
src/main/resources/hudson/plugins/git/GitPublisher/help-pushOnlyIfSuccess_ja.html
src/main/resources/hudson/plugins/git/GitSCM/config.jelly
src/main/resources/hudson/plugins/git/GitSCM/config_ja.properties
src/main/resources/hudson/plugins/git/GitSCM/global.jelly
src/main/resources/hudson/plugins/git/GitSCM/global_ja.properties
src/main/resources/hudson/plugins/git/GitSCM/help-createAccountBasedOnEmail_ja.html
src/main/resources/hudson/plugins/git/GitSCM/help-globalConfigEmail_ja.html
src/main/resources/hudson/plugins/git/GitSCM/help-globalConfigName_ja.html
src/main/resources/hudson/plugins/git/GitSCM/help-userRemoteConfigs_ja.html
src/main/resources/hudson/plugins/git/GitSCM/project-changes_ja.properties
src/main/resources/hudson/plugins/git/GitTagAction/tagForm_ja.properties
src/main/resources/hudson/plugins/git/Messages.properties
src/main/resources/hudson/plugins/git/Messages_ja.properties
src/main/resources/hudson/plugins/git/UserMergeOptions/config.jelly
src/main/resources/hudson/plugins/git/UserMergeOptions/config_ja.properties
src/main/resources/hudson/plugins/git/UserMergeOptions/help-fastForwardMode_ja.html
src/main/resources/hudson/plugins/git/UserMergeOptions/help-mergeRemote_ja.html
src/main/resources/hudson/plugins/git/UserMergeOptions/help-mergeStrategy_ja.html
src/main/resources/hudson/plugins/git/UserMergeOptions/help-mergeTarget_ja.html
src/main/resources/hudson/plugins/git/UserRemoteConfig/config_ja.properties
src/main/resources/hudson/plugins/git/UserRemoteConfig/help-name_ja.html
src/main/resources/hudson/plugins/git/UserRemoteConfig/help-refspec_ja.html
src/main/resources/hudson/plugins/git/UserRemoteConfig/help-url_ja.html
src/main/resources/hudson/plugins/git/extensions/impl/AuthorInChangelog/help_ja.html
src/main/resources/hudson/plugins/git/extensions/impl/BuildChooserSetting/config_ja.properties
src/main/resources/hudson/plugins/git/extensions/impl/BuildChooserSetting/help_ja.html
src/main/resources/hudson/plugins/git/extensions/impl/ChangelogToBranch/help_ja.html
src/main/resources/hudson/plugins/git/extensions/impl/CheckoutOption/config_ja.properties
src/main/resources/hudson/plugins/git/extensions/impl/CheckoutOption/help-timeout_ja.html
src/main/resources/hudson/plugins/git/extensions/impl/CleanBeforeCheckout/help_ja.html
src/main/resources/hudson/plugins/git/extensions/impl/CleanCheckout/help_ja.html
src/main/resources/hudson/plugins/git/extensions/impl/CloneOption/config_ja.properties
src/main/resources/hudson/plugins/git/extensions/impl/CloneOption/help-depth_ja.html
src/main/resources/hudson/plugins/git/extensions/impl/CloneOption/help-honorRefspec_ja.html
src/main/resources/hudson/plugins/git/extensions/impl/CloneOption/help-noTags_ja.html
src/main/resources/hudson/plugins/git/extensions/impl/CloneOption/help-reference_ja.html
src/main/resources/hudson/plugins/git/extensions/impl/CloneOption/help-shallow_ja.html
src/main/resources/hudson/plugins/git/extensions/impl/CloneOption/help-timeout_ja.html
src/main/resources/hudson/plugins/git/extensions/impl/DisableRemotePoll/help_ja.html
src/main/resources/hudson/plugins/git/extensions/impl/IgnoreNotifyCommit/help_ja.html
src/main/resources/hudson/plugins/git/extensions/impl/LocalBranch/config_ja.properties
src/main/resources/hudson/plugins/git/extensions/impl/LocalBranch/help_ja.html
src/main/resources/hudson/plugins/git/extensions/impl/MessageExclusion/config_ja.properties
src/main/resources/hudson/plugins/git/extensions/impl/MessageExclusion/help-excludedMessage_ja.html
src/main/resources/hudson/plugins/git/extensions/impl/PathRestriction/config_ja.properties
src/main/resources/hudson/plugins/git/extensions/impl/PathRestriction/help-excludedRegions_ja.html
src/main/resources/hudson/plugins/git/extensions/impl/PathRestriction/help-includedRegions_ja.html
src/main/resources/hudson/plugins/git/extensions/impl/PathRestriction/help_ja.html
src/main/resources/hudson/plugins/git/extensions/impl/PerBuildTag/help_ja.html
src/main/resources/hudson/plugins/git/extensions/impl/PreBuildMerge/help_ja.html
src/main/resources/hudson/plugins/git/extensions/impl/PruneStaleBranch/help_ja.html
src/main/resources/hudson/plugins/git/extensions/impl/RelativeTargetDirectory/config_ja.properties
src/main/resources/hudson/plugins/git/extensions/impl/RelativeTargetDirectory/help-relativeTargetDir_ja.html
src/main/resources/hudson/plugins/git/extensions/impl/ScmName/config_ja.properties
src/main/resources/hudson/plugins/git/extensions/impl/ScmName/help_ja.html
src/main/resources/hudson/plugins/git/extensions/impl/SparseCheckoutPath/config.jelly
src/main/resources/hudson/plugins/git/extensions/impl/SparseCheckoutPath/config_ja.properties
src/main/resources/hudson/plugins/git/extensions/impl/SparseCheckoutPaths/help_ja.html
src/main/resources/hudson/plugins/git/extensions/impl/SubmoduleOption/config_ja.properties
src/main/resources/hudson/plugins/git/extensions/impl/SubmoduleOption/help-disableSubmodules_ja.html
src/main/resources/hudson/plugins/git/extensions/impl/SubmoduleOption/help-parentCredentials_ja.html
src/main/resources/hudson/plugins/git/extensions/impl/SubmoduleOption/help-recursiveSubmodules_ja.html
src/main/resources/hudson/plugins/git/extensions/impl/SubmoduleOption/help-reference_ja.html
src/main/resources/hudson/plugins/git/extensions/impl/SubmoduleOption/help-timeout_ja.html
src/main/resources/hudson/plugins/git/extensions/impl/SubmoduleOption/help-trackingSubmodules_ja.html
src/main/resources/hudson/plugins/git/extensions/impl/UserExclusion/config_ja.properties
src/main/resources/hudson/plugins/git/extensions/impl/UserExclusion/help-excludedUsers_ja.html
src/main/resources/hudson/plugins/git/extensions/impl/UserIdentity/help-email_ja.html
src/main/resources/hudson/plugins/git/extensions/impl/UserIdentity/help-name_ja.html
src/main/resources/hudson/plugins/git/extensions/impl/WipeWorkspace/help_ja.html
src/main/resources/hudson/plugins/git/util/AncestryBuildChooser/config.properties
src/main/resources/hudson/plugins/git/util/BuildData/index.jelly
src/main/resources/hudson/plugins/git/util/BuildData/index_ja.properties
src/main/resources/hudson/plugins/git/util/BuildData/summary.jelly
src/main/resources/hudson/plugins/git/util/BuildData/summary_ja.properties
src/main/resources/jenkins/plugins/git/GitSCMSource/config-detail_ja.properties
src/main/resources/jenkins/plugins/git/GitStep/config.jelly
src/main/resources/jenkins/plugins/git/GitStep/config_ja.properties
src/main/resources/jenkins/plugins/git/GitStep/help_ja.html
src/main/resources/jenkins/plugins/git/Messages_ja.properties
src/main/webapp/gitPublisher_ja.html
src/test/java/jenkins/plugins/git/GitSampleRepoRule.java
http://jenkins-ci.org/commit/git-plugin/d42ec5d59e7d6afc8f69f771c591fa86fa60b723
Log:
Merge branch 'master' of https://github.com/jenkinsci/git-plugin into JENKINS-40607

egutierrez@cloudbees.com (JIRA)

unread,
Jan 24, 2017, 2:27:04 AM1/24/17
to jenkinsc...@googlegroups.com
Change By: Evaristo Gutierrez
Status: In Review Resolved
Resolution: Fixed

mark.earl.waite@gmail.com (JIRA)

unread,
Jul 14, 2019, 8:16:02 AM7/14/19
to jenkinsc...@googlegroups.com
Mark Waite closed an issue as Fixed
Change By: Mark Waite
Status: Resolved Closed
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)
Reply all
Reply to author
Forward
0 new messages