[JIRA] (JENKINS-52261) After a build is rebuilt, parallel stages are marked as FINISHED instead of NOT_BUILT

[npascu@cloudbees.com (JIRA)]

Nicolae Pascu created an issue

Jenkins / JENKINS-52261 After a build is rebuilt, parallel stages are marked as FINISHED instead of NOT_BUILT Issue Type: Bug Assignee: Andrew Bayer Components: pipeline-model-definition-plugin Created: 2018-06-28 23:24 Priority: Minor Reporter: Nicolae Pascu While doing some tests I found an issue (this is a restarted build that was restarted from the "Static Analysis" stage) Unable to render embedded object: File (screenshot-1.png?default=false) not found. The state of non-parallel stages is being correctly reported as "NOT_BUILT" while the state of the Parallel stages is "FINISHED" Unable to render embedded object: File (screenshot-2.png?default=false) not found.   Add Comment

This message was sent by Atlassian JIRA (v7.10.1#710002-sha1:6efc396)

[npascu@cloudbees.com (JIRA)]

Nicolae Pascu updated an issue

Jenkins / JENKINS-52261 After a build is rebuilt, parallel stages are marked as FINISHED instead of NOT_BUILT

Change By: Nicolae Pascu Attachment: screenshot-1.png

Add Comment

[npascu@cloudbees.com (JIRA)]

Nicolae Pascu updated an issue

Jenkins / JENKINS-52261 After a build is rebuilt, parallel stages are marked as FINISHED instead of NOT_BUILT Change By: Nicolae Pascu

While doing some tests I found an issue (this is a restarted build that was restarted from the "Static Analysis" stage)

[!screenshot-1.png?default=false |thumbnail !|https://cloudbees.atlassian.net/secure/attachment/39425/39425_screenshot-1.png]

The state of non-parallel stages is being correctly reported as "NOT_BUILT" while the state of the Parallel stages is "FINISHED"

[!screenshot-2.png?default=false |thumbnail !|https://cloudbees.atlassian.net/secure/attachment/39426/39426_screenshot-2.png]

Add Comment

[npascu@cloudbees.com (JIRA)]

Nicolae Pascu updated an issue

Jenkins / JENKINS-52261 After a build is rebuilt, parallel stages are marked as FINISHED instead of NOT_BUILT

Change By: Nicolae Pascu Attachment: screenshot-2.png

Add Comment

[npascu@cloudbees.com (JIRA)]

Nicolae Pascu updated an issue

Jenkins / JENKINS-52261 After a build is rebuilt, parallel stages are marked as FINISHED instead of NOT_BUILT Change By: Nicolae Pascu

While doing some tests I found an issue (this is a restarted build that was restarted from the "Static Analysis" stage)

[!screenshot-1.png?default=false!|https://cloudbees.atlassian.net/secure/attachment/39425/39425_screenshot-1.png]

The state of non-parallel stages is being correctly reported as "NOT_BUILT" while the state of the Parallel stages is "FINISHED"

[!screenshot-2.png?default=false!|https://cloudbees.atlassian.net/secure/attachment/39426/39426_screenshot-2.png]

Add Comment

[npascu@cloudbees.com (JIRA)]

Nicolae Pascu updated an issue

Jenkins / JENKINS-52261 After a build is rebuilt, parallel stages are marked as FINISHED instead of NOT_BUILT Change By: Nicolae Pascu

While doing some tests I found an issue (this is a restarted build that was restarted from the "Static Analysis" stage)

!screenshot-1.png|thumbnail!

The state of non-parallel stages is being correctly reported as "NOT_BUILT" while the state of the Parallel stages is "FINISHED"

[ !screenshot-2.png ?default=false! | https://cloudbees.atlassian.net/secure/attachment/39426/39426_screenshot-2.png] thumbnail!

Add Comment

[npascu@cloudbees.com (JIRA)]

Nicolae Pascu updated an issue

Jenkins / JENKINS-52261 After a build is rebuilt, parallel stages are marked as FINISHED instead of NOT_BUILT Change By: Nicolae Pascu

While doing some tests I found an issue (this is a restarted build that was restarted from the "Static Analysis" stage) !screenshot-1.png|thumbnail!   The state of non-parallel stages is being correctly reported as "NOT_BUILT" while the state of the Parallel stages is "FINISHED"

!screenshot-2.png|thumbnail!     The jenkinsfile used in the example above is: https://github.com/NicuPascu/app-store-demo/blob/longer-pipeline/Jenkinsfile

Add Comment

[andrew.bayer@gmail.com (JIRA)]

Andrew Bayer commented on JENKINS-52261

Re: After a build is rebuilt, parallel stages are marked as FINISHED instead of NOT_BUILT Hmm. I see NotExecutedNodeAction on both the parent of the parallel stages and the parallel stages themselves, which is right, and they have the SKIPPED_FOR_RESTART value for the STAGE_STATUS tag. Oh, wait, I think I get it. Honestly, I'm not sure how any of the stages are showing up as NOT_BUILT. It looks like that only gets set for a stage that's skipped for a conditional, or one where its last FlowNode has the NotExecutedNodeAction on it. I was putting NotExecutedNodeAction on the start node, not the end node. Durrr. Working up a fix, but it'll need review next week.

Add Comment

[andrew.bayer@gmail.com (JIRA)]

Andrew Bayer started work on JENKINS-52261

Change By: Andrew Bayer Status: Open In Progress

Add Comment

[andrew.bayer@gmail.com (JIRA)]

Andrew Bayer updated JENKINS-52261

Jenkins / JENKINS-52261

After a build is rebuilt, parallel stages are marked as FINISHED instead of NOT_BUILT

Change By: Andrew Bayer Status: In Progress Review

Add Comment

[andrew.bayer@gmail.com (JIRA)]

Andrew Bayer commented on JENKINS-52261

Re: After a build is rebuilt, parallel stages are marked as FINISHED instead of NOT_BUILT I think I have the fix - https://github.com/jenkinsci/pipeline-model-definition-plugin/pull/273/files - I wasn't setting NotExecutedNodeAction in the right places, I believe.

Add Comment

[andrew.bayer@gmail.com (JIRA)]

Andrew Bayer updated JENKINS-52261

Merged, will be in next release (1.3.2)

Jenkins / JENKINS-52261

After a build is rebuilt, parallel stages are marked as FINISHED instead of NOT_BUILT

Change By: Andrew Bayer Status: In Review Resolved Resolution: Fixed

Add Comment

[bitwiseman@gmail.com (JIRA)]

Liam Newman closed an issue as Fixed

Bulk closing resolved issues.

Jenkins / JENKINS-52261 After a build is rebuilt, parallel stages are marked as FINISHED instead of NOT_BUILT

Change By: Liam Newman Status: Resolved Closed

Add Comment

This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)