[JIRA] (JENKINS-55953) JCasC compability with RocketChat Notifier Plugin

9 views
Skip to first unread message

uwe.hanisch@gmx.de (JIRA)

unread,
Feb 4, 2019, 9:08:01 AM2/4/19
to jenkinsc...@googlegroups.com
Uwe Hanisch created an issue
 
Jenkins / Improvement JENKINS-55953
JCasC compability with RocketChat Notifier Plugin
Issue Type: Improvement Improvement
Assignee: Martin Reinhardt
Components: rocket-chat-notifier-plugin
Created: 2019-02-04 14:07
Environment: Jenkins 2 with Configuration as Code Plugin
Labels: jcasc-compatibility
Priority: Major Major
Reporter: Uwe Hanisch

RocketChat Notifier Plugin should be configurable via JCasC compability
(see https://github.com/jenkinsci/configuration-as-code-plugin/blob/master/docs/REQUIREMENTS.md)
Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

uwe.hanisch@gmx.de (JIRA)

unread,
Feb 5, 2019, 9:29:02 AM2/5/19
to jenkinsc...@googlegroups.com
Uwe Hanisch commented on Improvement JENKINS-55953
 
Re: JCasC compability with RocketChat Notifier Plugin

First try according to https://github.com/jenkinsci/configuration-as-code-plugin/blob/master/docs/REQUIREMENTS.md
see:

Problem:

  • Configuration via JCasC works fine, but via GUI / Configure Jenkins doesn't work anymore (changes are not saved)
  • needed to rename parameter in jelly and RocketChatNotifier#DescriptorImpl so set getter/setter correspond to property name
  • better use RocketJobProperty?

hypery2k@web.de (JIRA)

unread,
Feb 7, 2019, 1:27:02 AM2/7/19
to jenkinsc...@googlegroups.com

have to look after it, but currently don't have much time for this and never uses JCasC.

hypery2k@web.de (JIRA)

unread,
Apr 20, 2019, 2:10:22 AM4/20/19
to jenkinsc...@googlegroups.com
Martin Reinhardt started work on Improvement JENKINS-55953
 
Change By: Martin Reinhardt
Status: Open In Progress

hypery2k@web.de (JIRA)

unread,
Apr 20, 2019, 2:11:02 AM4/20/19
to jenkinsc...@googlegroups.com

hypery2k@web.de (JIRA)

unread,
Apr 20, 2019, 2:23:02 AM4/20/19
to jenkinsc...@googlegroups.com

merged your changes on a new feature branch and fixed smaller issues: https://github.com/jenkinsci/rocketchatnotifier-plugin/tree/feature/JCasC-compatibility

But still the saving error occurs. asked via gitter for help

wojteks@wojteks.net (JIRA)

unread,
Jun 27, 2019, 6:06:02 AM6/27/19
to jenkinsc...@googlegroups.com

Any updated? Thank you.

hypery2k@web.de (JIRA)

unread,
Jun 27, 2019, 7:05:02 AM6/27/19
to jenkinsc...@googlegroups.com

nope, didn't had time for this as it requires more changes.

hypery2k@web.de (JIRA)

unread,
Sep 9, 2019, 12:54:04 PM9/9/19
to jenkinsc...@googlegroups.com

Readded the changes on develop. Looking forward that CI passes: https://travis-ci.org/jenkinsci/rocketchatnotifier-plugin/builds/582778920
This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)
Atlassian logo

hypery2k@web.de (JIRA)

unread,
Oct 11, 2019, 12:12:02 AM10/11/19
to jenkinsc...@googlegroups.com
Martin Reinhardt assigned an issue to Uwe Hanisch
 

Could you give version 1.4.6 a try?
Change By: Martin Reinhardt
Assignee: Martin Reinhardt Uwe Hanisch
Reply all
Reply to author
Forward
0 new messages