[JIRA] (JENKINS-57986) NPE doTestConnection

[gigaga31@gmail.com (JIRA)]

Dam Guerin created an issue

Jenkins / JENKINS-57986 NPE doTestConnection Issue Type: Bug Assignee: Martin Reinhardt Components: rocket-chat-notifier-plugin Created: 2019-06-12 12:59 Priority: Minor Reporter: Dam Guerin Currently, for any error in doTestConnection, the code in catch, RocketChatNotifier.java, l599. However, in this catch, the following condition is incorrect. if (e.getCause() != null && e.getCause().getClass() == SSLHandshakeException.class || e.getCause().getClass() == ValidatorException.class) Indeed, the third part of this, is not protect by the first part. In other terms, we can have an NPE when e.getCause() returns null because the condition "e.getCause().getClass() == ValidatorException.class" is eval. Add Comment

This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

[hypery2k@web.de (JIRA)]

Martin Reinhardt started work on JENKINS-57986

Change By: Martin Reinhardt Status: Open In Progress

Add Comment

[hypery2k@web.de (JIRA)]

Martin Reinhardt commented on JENKINS-57986

Re: NPE doTestConnection already fixed: https://github.com/jenkinsci/rocketchatnotifier-plugin/commit/963d0fa60f33838f2947ae46bef40e3739121db0 Next time would appreciate PR for this kind of issue

Add Comment

[hypery2k@web.de (JIRA)]

Martin Reinhardt updated JENKINS-57986

Jenkins / JENKINS-57986 NPE doTestConnection

Change By: Martin Reinhardt Status: In Progress Fixed but Unreleased Resolution: Fixed

Add Comment

[hypery2k@web.de (JIRA)]

Martin Reinhardt updated JENKINS-57986

fixed in 1.4.4

Jenkins / JENKINS-57986 NPE doTestConnection

Change By: Martin Reinhardt Status: Fixed but Unreleased Resolved

Add Comment

This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)

[hypery2k@web.de (JIRA)]

Martin Reinhardt closed an issue as Fixed

Jenkins / JENKINS-57986 NPE doTestConnection

Change By: Martin Reinhardt Status: Resolved Closed Assignee: Martin Reinhardt

Add Comment