[JIRA] (JENKINS-57681) Setup wizard does not take into account optional dependencies when ordering plugin installations

5 views
Skip to first unread message

dbeck@cloudbees.com (JIRA)

unread,
May 25, 2019, 7:40:03 AM5/25/19
to jenkinsc...@googlegroups.com
Daniel Beck created an issue
 
Jenkins / Bug JENKINS-57681
Setup wizard does not take into account optional dependencies when ordering plugin installations
Issue Type: Bug Bug
Assignee: Francisco Fernández
Components: cloudbees-folder-plugin, core, credentials-plugin
Created: 2019-05-25 11:39
Environment: docker run -p 8080:8080 jenkins/jenkins:2.164.3
Priority: Minor Minor
Reporter: Daniel Beck

Seen this myself, and also reports from others that Jenkins requires a restart after setup wizard plugin installation for things to not be broken.

Steps to reproduce:

  1. Install suggested plugins in setup wizard
  2. Observe that Folders is installed before Credentials
  3. New Item, type Folder

Expected result

Folder config screen loads

Actual result

It does not

Workaround

Restart Jenkins after plugin installation.

Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

jglick@cloudbees.com (JIRA)

unread,
May 31, 2019, 9:12:02 AM5/31/19
to jenkinsc...@googlegroups.com
Jesse Glick commented on Bug JENKINS-57681
 
Re: Setup wizard does not take into account optional dependencies when ordering plugin installations

So several bugs here:

  1. The Setup wizard is either failing to do a topological sort of plugins, or failing to include optional dependencies in the set of edges.
  2. The plugin manager is not retroactively inserting the class loader for credentials as a parent of that for cloudbees-folder: after everything has been installed we see Failed to instantiate optional component com.cloudbees.hudson.plugins.folder.properties.FolderCredentialsProvider$FolderCredentialsProperty$DescriptorImpl; skipping
  3. Some JavaScript is not accounting for an edge condition gracefully:
    Uncaught TypeError: Cannot read property 'firstChild' of undefined
        at registerValidator (hudson-behavior.js:424)
        at Array.forEach (<anonymous>)
        at behavior.js:111
        at Array.forEach (<anonymous>)
        at behavior.js:107
        at Array.forEach (<anonymous>)
        at Object.applySubtree (behavior.js:93)
        at Object.apply (behavior.js:76)
        at behavior.js:71
        at window.onload (behavior.js:125)
    
  4. Probably something else, depending on diagnosis of #3.

dbeck@cloudbees.com (JIRA)

unread,
May 31, 2019, 9:16:01 AM5/31/19
to jenkinsc...@googlegroups.com

Would be interesting to know whether the normal plugin manager/update center do this differently. I've only observed it with the setup wizard but that doesn't mean it wouldn't occur elsewhere.

Reply all
Reply to author
Forward
0 new messages