[JIRA] (JENKINS-61925) Upcoming Chrome SameSite policy change will break HTML Publisher plugin

15 views
Skip to first unread message

davidepesa@gmail.com (JIRA)

unread,
Apr 15, 2020, 11:54:03 PM4/15/20
to jenkinsc...@googlegroups.com
Davide Pesavento created an issue
 
Jenkins / Bug JENKINS-61925
Upcoming Chrome SameSite policy change will break HTML Publisher plugin
Issue Type: Bug Bug
Assignee: Richard Bywater
Components: htmlpublisher-plugin
Created: 2020-04-16 03:53
Environment: Jenkins 2.228
htmlpublisher v1.22
Priority: Major Major
Reporter: Davide Pesavento

Google Chrome is about to change behavior for cookies without a SameSite attribute, see https://web.dev/samesite-cookies-explained/ and https://www.chromium.org/updates/same-site. The rollout, originally planned for February/March, has now been postponed until the summer. Other browsers will eventually ship the same changes.

We're using the HTML Publisher plugin to publish LCOV-generated code coverage reports. The new SameSite behavior described above, together with the default Content-Security-Policy header, seems to break this use case. Specifically, the cookies set by Jenkins don't include a SameSite attribute and therefore are no longer being sent by the browser when the HTML report page tries to load additional resources (CSS and images), because they are considered cross-site requests. And without the session cookie, these requests are rejected by Jenkins with an HTTP 403 error.

Removing "sandbox" from the default hudson.model.DirectoryBrowserSupport.CSP setting works around the issue, but seems less than ideal.

Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)
Atlassian logo

richard@bywater.nz (JIRA)

unread,
Apr 24, 2020, 5:32:02 AM4/24/20
to jenkinsc...@googlegroups.com
Richard Bywater commented on Bug JENKINS-61925
 
Re: Upcoming Chrome SameSite policy change will break HTML Publisher plugin

Thanks for the report and apologies for the delay in responding. With all that's going on in the world it's taking a while to get to things

I'll take a look at this as soon to see the impact and what fixes are possible. In the meantime do you happen to know what month "summer" is in the context of the announcement? I assume it means US summer so if happen to be able to clarify when that is for non-US resident that'd be great

 

davidepesa@gmail.com (JIRA)

unread,
Apr 24, 2020, 3:58:02 PM4/24/20
to jenkinsc...@googlegroups.com

That's all the announcement says: "we’re now aiming for over the summer". I don't have any more specific info. And yes, I think we can assume it means northern hemisphere summer.

Also note that "Non-stable Chrome channels (e.g. Dev, Canary, and Beta) will continue with 50% enablement in Chrome 80 and later". I'm able to reproduce the problem with Chrome 83 beta (I guess I'm one of the "lucky" 50%).

davidepesa@gmail.com (JIRA)

unread,
Apr 24, 2020, 4:00:02 PM4/24/20
to jenkinsc...@googlegroups.com
Davide Pesavento edited a comment on Bug JENKINS-61925
That's all the announcement says: "we’re now aiming for over the summer". I don't have any more specific info. And yes, I think we can assume it means northern hemisphere summer , so June to September .


Also note that "Non-stable Chrome channels (e.g. Dev, Canary, and Beta) will continue with 50% enablement in Chrome 80 and later". I'm able to reproduce the problem with Chrome 83 beta (I guess I'm one of the "lucky" 50%).

richard@bywater.nz (JIRA)

unread,
Apr 25, 2020, 9:17:04 PM4/25/20
to jenkinsc...@googlegroups.com

Thanks Davide Pesavento - if the there's nothing particular sensitive about the calls being made, just wondering if you would be able to share a HAR file (see e.g. https://support.zendesk.com/hc/en-us/articles/204410413-Generating-a-HAR-file-for-troubleshooting for details if you aren't sure how) to record the requests & responses so I can get an idea about what is being passed when the 403 is returned etc. Also a copy of any errors in the browser console would be useful too.

The Chrome changes relate to cookies and HTML Publisher itself doesn't really do anything special with cookies and so I'm just wanting to try and get more info so that I can work out if this is something in my realm to fix or if I'll have to kick it over to Jenkins Core developers.

Reply all
Reply to author
Forward
0 new messages