[JIRA] (JENKINS-61478) "Apply" (and similar) banners look really bad with larger header bar

33 views
Skip to first unread message

dbeck@cloudbees.com (JIRA)

unread,
Mar 13, 2020, 7:07:03 PM3/13/20
to jenkinsc...@googlegroups.com
Daniel Beck commented on Bug JENKINS-61478
 
Re: "Apply" (and similar) banners look really bad with larger header bar

FYI Félix Queiruga Balado
Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)
Atlassian logo

dbeck@cloudbees.com (JIRA)

unread,
Mar 13, 2020, 7:07:03 PM3/13/20
to jenkinsc...@googlegroups.com
Daniel Beck created an issue
 
Jenkins / Bug JENKINS-61478
Issue Type: Bug Bug
Assignee: Unassigned
Attachments: Screenshot 2020-03-14 at 00.06.15.png
Components: core
Created: 2020-03-13 23:06
Labels: regression
Priority: Minor Minor
Reporter: Daniel Beck

Previously, notification banners like the one that appears when pressing "Apply" buttons were the same height as the Jenkins header.

With the 2.222 design update, that is no longer the case. They look broken now.

dbeck@cloudbees.com (JIRA)

unread,
Mar 13, 2020, 7:07:04 PM3/13/20
to jenkinsc...@googlegroups.com
Daniel Beck updated an issue
Change By: Daniel Beck
Attachment: Screenshot 2020-03-14 at 00.06.15.png

dbeck@cloudbees.com (JIRA)

unread,
Mar 13, 2020, 7:37:44 PM3/13/20
to jenkinsc...@googlegroups.com
Daniel Beck updated an issue
Change By: Daniel Beck
Labels: regression ux

dbeck@cloudbees.com (JIRA)

unread,
Mar 13, 2020, 7:38:05 PM3/13/20
to jenkinsc...@googlegroups.com
Daniel Beck updated an issue
Previously, notification banners like the one that appears when pressing "Apply" buttons were the same height as the Jenkins header.

With the 2.222 design update, that is no longer the case. They look broken now (not merely ugly :D) .

fqueiruga@cloudbees.com (JIRA)

unread,
Mar 16, 2020, 5:33:03 AM3/16/20
to jenkinsc...@googlegroups.com
Félix Queiruga Balado commented on Bug JENKINS-61478
 
Re: "Apply" (and similar) banners look really bad with larger header bar

It would make sense to revisit the banner. Can someone add it to the https://issues.jenkins-ci.org/browse/JENKINS-60919 epic and mark this as an improvement? We can triage it on the SIG meeting.

fqueiruga@cloudbees.com (JIRA)

unread,
Mar 16, 2020, 5:35:02 AM3/16/20
to jenkinsc...@googlegroups.com
Change By: Félix Queiruga Balado
Issue Type: Bug Improvement

fqueiruga@cloudbees.com (JIRA)

unread,
Mar 16, 2020, 5:36:02 AM3/16/20
to jenkinsc...@googlegroups.com
It would make sense to revisit the banner. Can someone add it to the https://issues.jenkins-ci.org/browse/JENKINS-60919 epic and mark this as an improvement? We can triage it on the SIG meeting.


*Edit:* nevermind, I did that

dbeck@cloudbees.com (JIRA)

unread,
Mar 16, 2020, 5:43:02 AM3/16/20
to jenkinsc...@googlegroups.com

an improvement

So you're saying the banner doesn't look any more broken now than it did in 2.221 before the UI refresh?

fqueiruga@cloudbees.com (JIRA)

unread,
Mar 16, 2020, 5:52:03 AM3/16/20
to jenkinsc...@googlegroups.com

I'm saying I don't consider it a bug. But it's OK, I'll mark it back as a bug and we can talk about it on the next SIG meeting, maybe we could even get some designs going.

fqueiruga@cloudbees.com (JIRA)

unread,
Mar 16, 2020, 5:53:03 AM3/16/20
to jenkinsc...@googlegroups.com
Félix Queiruga Balado updated an issue
Issue Type: Improvement Bug

romen@romenrg.com (JIRA)

unread,
Mar 18, 2020, 12:28:03 PM3/18/20
to jenkinsc...@googlegroups.com
Romen Rodriguez-Gil commented on Bug JENKINS-61478
 
Re: "Apply" (and similar) banners look really bad with larger header bar

I'd be happy to experiment using Bootstrap alerts for this. I'm pretty sure it will be an improvement.

Are you OK if I take the ticket and play with it a bit?

romen@romenrg.com (JIRA)

unread,
Mar 18, 2020, 12:30:03 PM3/18/20
to jenkinsc...@googlegroups.com
Romen Rodriguez-Gil assigned an issue to Romen Rodriguez-Gil
 
Change By: Romen Rodriguez-Gil
Assignee: Romen Rodriguez-Gil

fqueiruga@cloudbees.com (JIRA)

unread,
Mar 20, 2020, 4:59:02 PM3/20/20
to jenkinsc...@googlegroups.com
Félix Queiruga Balado updated an issue
Change By: Félix Queiruga Balado
Attachment: Captura de pantalla 2020-03-20 a las 21.51.16.png

fqueiruga@cloudbees.com (JIRA)

unread,
Mar 20, 2020, 5:00:03 PM3/20/20
to jenkinsc...@googlegroups.com
Félix Queiruga Balado commented on Bug JENKINS-61478
 
Re: "Apply" (and similar) banners look really bad with larger header bar

I found one more banner that should be updated as well:

  1. Go to the /user/admin/configure page
  2. Generate an API token
  3. Click the button to copy the API token to the clipboard

Screenshot:

romen@romenrg.com (JIRA)

unread,
Mar 21, 2020, 6:21:03 AM3/21/20
to jenkinsc...@googlegroups.com
Romen Rodriguez-Gil edited a comment on Bug JENKINS-61478
I'd be happy to experiment using Bootstrap alerts for this. I'm pretty sure it will be an improvement.

Are you OK if I take the ticket and play with it a bit?


EDIT: I'll be working on this as agreed in the UX SIG meeting

romen@romenrg.com (JIRA)

unread,
Mar 21, 2020, 6:22:02 AM3/21/20
to jenkinsc...@googlegroups.com

Thanks Félix. I'll work on that one as well

fqueiruga@cloudbees.com (JIRA)

unread,
Mar 21, 2020, 7:07:03 AM3/21/20
to jenkinsc...@googlegroups.com

If you work with bootstrap alerts, it's better if you don't bring the library in, just bring the code you need.

romen@romenrg.com (JIRA)

unread,
Mar 21, 2020, 10:17:03 AM3/21/20
to jenkinsc...@googlegroups.com
Romen Rodriguez-Gil started work on Bug JENKINS-61478
 
Change By: Romen Rodriguez-Gil
Status: Open In Progress

dbeck@cloudbees.com (JIRA)

unread,
Mar 30, 2020, 5:13:03 AM3/30/20
to jenkinsc...@googlegroups.com
Daniel Beck updated an issue
 
Change By: Daniel Beck
Labels: lts-candidate regression ux

dbeck@cloudbees.com (JIRA)

unread,
Mar 30, 2020, 5:15:05 AM3/30/20
to jenkinsc...@googlegroups.com
Change By: Daniel Beck
Status: In Progress Review

romen@romenrg.com (JIRA)

unread,
Apr 1, 2020, 3:58:04 AM4/1/20
to jenkinsc...@googlegroups.com

o.v.nenashev@gmail.com (JIRA)

unread,
Apr 6, 2020, 5:41:04 AM4/6/20
to jenkinsc...@googlegroups.com
Change By: Oleg Nenashev
Status: In Review Resolved
Resolution: Fixed
Released As: Jenkins 2.230

ogondza@gmail.com (JIRA)

unread,
Apr 9, 2020, 6:12:04 AM4/9/20
to jenkinsc...@googlegroups.com
Oliver Gondža updated an issue
Change By: Oliver Gondža
Labels: 2.222.2-rejected lts-candidate regression ux

ogondza@gmail.com (JIRA)

unread,
May 5, 2020, 3:01:02 AM5/5/20
to jenkinsc...@googlegroups.com
Oliver Gondža updated an issue
Change By: Oliver Gondža
Labels: 2.222.2-rejected 2.222.4- fixed rejected regression ux
Reply all
Reply to author
Forward
0 new messages