[JIRA] (JENKINS-50669) Expose WebAppMain#DEFAULT_RING_BUFFER_SIZE actual value

2 views
Skip to first unread message

batmat@batmat.net (JIRA)

unread,
Apr 9, 2018, 7:22:01 AM4/9/18
to jenkinsc...@googlegroups.com
Baptiste Mathus created an issue
 
Jenkins / Task JENKINS-50669
Expose WebAppMain#DEFAULT_RING_BUFFER_SIZE actual value
Issue Type: Task Task
Assignee: Baptiste Mathus
Components: core
Created: 2018-04-09 11:21
Labels: essentials essentials-triggered
Priority: Minor Minor
Reporter: Baptiste Mathus

For Essentials, we want to detect if already too many logs were generated before the Essentials Jenkins Plugin even had time to start up.

The rationale being: if there are already 256 logs when plugin startup state is attained, then there is something (very) wrong per-se.

The goal is to be able to do something like:

if (Jenkins.logRecords.size() >= WebAppMain.getDefaultRingBufferSize()) {
    LOGGER.log(Level.SEVERE,
               "The Jenkins logs buffer is already full. " +
                       "Some logs might have been missed, and so many logs shows something probably very wrong! (max={0})",
               maxNumberOfLogs);
}

Currently, as an intermediate shim, I'm using reflection. In addition to being dirty, this is likely to become even more an issue to support Java 9 when using such hacks is being made harder and harder.
Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)
Atlassian logo

scm_issue_link@java.net (JIRA)

unread,
Apr 10, 2018, 4:49:02 AM4/10/18
to jenkinsc...@googlegroups.com
SCM/JIRA link daemon commented on Task JENKINS-50669
 
Re: Expose WebAppMain#DEFAULT_RING_BUFFER_SIZE actual value

Code changed in jenkins
User: Baptiste Mathus
Path:
src/main/java/io/jenkins/plugins/essentials/logging/EssentialsLoggingConfigurer.java
http://jenkins-ci.org/commit/essentials-plugin/5f42dc4e3cca1981dc7c5636b4139731c0d16ec4
Log:
JENKINS-50669 reflective access shim

batmat@batmat.net (JIRA)

unread,
Apr 10, 2018, 4:57:02 AM4/10/18
to jenkinsc...@googlegroups.com
Baptiste Mathus updated an issue
Change By: Baptiste Mathus
Sprint: Essentials - Milestone 1 2

batmat@batmat.net (JIRA)

unread,
Apr 10, 2018, 4:58:03 AM4/10/18
to jenkinsc...@googlegroups.com
Baptiste Mathus updated an issue
Change By: Baptiste Mathus
Labels: essentials essentials-triggered technical-debt

batmat@batmat.net (JIRA)

unread,
Sep 28, 2018, 5:50:07 AM9/28/18
to jenkinsc...@googlegroups.com
Baptiste Mathus updated an issue
Change By: Baptiste Mathus
Labels: essentials essentials-triggered evergreen technical-debt
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

batmat@batmat.net (JIRA)

unread,
Sep 28, 2018, 5:52:10 AM9/28/18
to jenkinsc...@googlegroups.com
Baptiste Mathus updated an issue
Change By: Baptiste Mathus
Labels: essentials essentials-triggered evergreen evergreen-triggered technical-debt

batmat@batmat.net (JIRA)

unread,
Sep 28, 2018, 6:01:20 AM9/28/18
to jenkinsc...@googlegroups.com

batmat@batmat.net (JIRA)

unread,
Sep 28, 2018, 7:15:03 AM9/28/18
to jenkinsc...@googlegroups.com
Baptiste Mathus updated an issue
Change By: Baptiste Mathus
Labels: evergreen evergreen-triggered n newbie-friendly technical-debt

batmat@batmat.net (JIRA)

unread,
Sep 28, 2018, 7:15:03 AM9/28/18
to jenkinsc...@googlegroups.com
Baptiste Mathus updated an issue
Change By: Baptiste Mathus
Labels: evergreen evergreen-triggered n technical-debt

batmat@batmat.net (JIRA)

unread,
Sep 28, 2018, 7:15:03 AM9/28/18
to jenkinsc...@googlegroups.com
Baptiste Mathus updated an issue
For Essentials Evergreen , we want to detect if already too many logs were generated before the _Essentials _Evergreen Jenkins Plugin_ even had time to start up.


The rationale being: if there are already 256 logs when plugin startup state is attained, then there is something (very) wrong per-se.

The goal is to be able to do something like:

{code:java}

if (Jenkins.logRecords.size() >= WebAppMain.getDefaultRingBufferSize()) {
    LOGGER.log(Level.SEVERE,
               "The Jenkins logs buffer is already full. " +
                     "Some logs might have been missed, and so many logs shows something probably very wrong! (max={0})",
               maxNumberOfLogs);
}
{code}


Currently, as an intermediate shim, I'm using reflection. In addition to being dirty, this is likely to become even more an issue to support Java 9 when using such hacks is being made harder and harder.

batmat@batmat.net (JIRA)

unread,
Oct 9, 2018, 3:20:03 PM10/9/18
to jenkinsc...@googlegroups.com
Baptiste Mathus assigned an issue to Unassigned
Change By: Baptiste Mathus
Assignee: Baptiste Mathus

batmat@batmat.net (JIRA)

unread,
Oct 9, 2018, 3:20:06 PM10/9/18
to jenkinsc...@googlegroups.com
Baptiste Mathus updated an issue
Change By: Baptiste Mathus
Sprint: Evergreen - Milestone 2

ddevpros@protonmail.com (JIRA)

unread,
Nov 20, 2018, 4:42:01 AM11/20/18
to jenkinsc...@googlegroups.com
Ben A assigned an issue to Ben A
Change By: Ben A
Assignee: Ben A

neaguandrei47@gmail.com (JIRA)

unread,
Jan 19, 2020, 2:21:02 PM1/19/20
to jenkinsc...@googlegroups.com
Andrei Neagu assigned an issue to Andrei Neagu
Change By: Andrei Neagu
Assignee: Ben A Andrei Neagu
This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)
Atlassian logo

neaguandrei47@gmail.com (JIRA)

unread,
Jan 22, 2020, 7:03:03 PM1/22/20
to jenkinsc...@googlegroups.com
Andrei Neagu started work on Task JENKINS-50669
 
Change By: Andrei Neagu
Status: Open In Progress
Reply all
Reply to author
Forward
0 new messages