[JIRA] (JENKINS-41490) Declarative JSON schema doesn't allow nested tree steps within tree steps

[andrew.bayer@gmail.com (JIRA)]

Andrew Bayer created an issue

Jenkins / JENKINS-41490 Declarative JSON schema doesn't allow nested tree steps within tree steps Issue Type: Bug Assignee: Andrew Bayer Components: pipeline-model-definition-plugin Created: 2017/Jan/26 8:27 PM Priority: Minor Reporter: Andrew Bayer We allow non-tree steps as children for tree steps in the JSON schema, but not tree steps. That's silly. Add Comment

This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)

[kzantow@cloudbees.com (JIRA)]

Keith Zantow commented on JENKINS-41490

Re: Declarative JSON schema doesn't allow nested tree steps within tree steps Actually this is a blocker issue to me. Because from JSON you can't do: node('windows') { retry(5) { steps...

Add Comment

[andrew.bayer@gmail.com (JIRA)]

Andrew Bayer updated an issue

Jenkins / JENKINS-41490

Declarative JSON schema doesn't allow nested tree steps within tree steps

Change By: Andrew Bayer Priority: Minor Blocker

Add Comment

[andrew.bayer@gmail.com (JIRA)]

Andrew Bayer updated JENKINS-41490

Jenkins / JENKINS-41490 Declarative JSON schema doesn't allow nested tree steps within tree steps

Change By: Andrew Bayer Status: In Progress Review

Add Comment

[andrew.bayer@gmail.com (JIRA)]

Andrew Bayer started work on JENKINS-41490

Change By: Andrew Bayer Status: Open In Progress

Add Comment

[andrew.bayer@gmail.com (JIRA)]

Andrew Bayer commented on JENKINS-41490

Re: Declarative JSON schema doesn't allow nested tree steps within tree steps Combined PR for JENKINS-41490 and JENKINS-41491 up at https://github.com/jenkinsci/pipeline-model-definition-plugin/pull/104

Add Comment

[andrew.bayer@gmail.com (JIRA)]

Andrew Bayer updated JENKINS-41490

Jenkins / JENKINS-41490

Declarative JSON schema doesn't allow nested tree steps within tree steps

Change By: Andrew Bayer Status: In Review Resolved Resolution: Fixed

Add Comment

[scm_issue_link@java.net (JIRA)]

SCM/JIRA link daemon commented on JENKINS-41490

Re: Declarative JSON schema doesn't allow nested tree steps within tree steps Code changed in jenkins User: Andrew Bayer Path: pipeline-model-api/src/main/resources/ast-schema.json pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/validator/ModelValidatorImpl.groovy pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/AbstractModelDefTest.java pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/BasicModelDefTest.java pipeline-model-definition/src/test/resources/json/nestedTreeSteps.json pipeline-model-definition/src/test/resources/nestedTreeSteps.groovy http://jenkins-ci.org/commit/pipeline-model-definition-plugin/ca9c202861194c80b78dd1f88c013643e524060a Log: Merge pull request #104 from abayer/jenkins-41490-jenkins-41491 [FIXED JENKINS-41490, JENKINS-41491] Tree steps and validation! Compare: https://github.com/jenkinsci/pipeline-model-definition-plugin/compare/3a0ee9510ed4...ca9c20286119

Add Comment

[scm_issue_link@java.net (JIRA)]

SCM/JIRA link daemon commented on JENKINS-41490

Re: Declarative JSON schema doesn't allow nested tree steps within tree steps

Code changed in jenkins User: Andrew Bayer Path: pipeline-model-api/src/main/resources/ast-schema.json pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/validator/ModelValidatorImpl.groovy pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/AbstractModelDefTest.java pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/BasicModelDefTest.java pipeline-model-definition/src/test/resources/json/nestedTreeSteps.json pipeline-model-definition/src/test/resources/nestedTreeSteps.groovy

http://jenkins-ci.org/commit/pipeline-model-definition-plugin/e4aae36cca402d8612e0c69110f9e7a9128f0ffc Log:

[FIXED JENKINS-41490, JENKINS-41491] Tree steps and validation!

So this started with fixing JENKINS-41490, so that the editor can actually do nested tree steps (d'oh), but in the process, I discovered a strange decision from waaaaaay back in the day to force validation in certain cases to treat the step parameter type as a String, even when it wasn't one. That...was bad. So, fixing both those things.

Add Comment

[bitwiseman@gmail.com (JIRA)]

Liam Newman closed an issue as Fixed

Bulk closing resolved issues.

Jenkins / JENKINS-41490

Declarative JSON schema doesn't allow nested tree steps within tree steps

Change By: Liam Newman Status: Resolved Closed

Add Comment

This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)