[JIRA] (JENKINS-50211) Add an option to optionally reject connections from agents with unsupported Remoting versions

o.v.nenashev@gmail.com (JIRA)

unread,

Mar 16, 2018, 4:50:02 AM3/16/18

to jenkinsc...@googlegroups.com

Oleg Nenashev created an issue

Jenkins /

JENKINS-50211

Add an option to optionally reject connections from agents with unsupported Remoting versions

Issue Type:	Bug
Assignee:	Unassigned
Components:	core
Created:	2018-03-16 08:49
Labels:	remoting
Priority:	Minor
Reporter:	Oleg Nenashev

It is a follow-up to ~~JENKINS-48766~~. That story adds warnings for unsupported agent versions, but it actually does not reject them. It would be useful to have such feature in the core or in Version Column Plugin. Core is preferable though this feature may be detached to a plugin later as a part of JENKINS-44100.

Acceptance criteria:

There is a Global Configuration entry for Remoting. An existing section for Remoting protocols may be used
There is a checkbox in the configuration, which turns on rejection of unsupported versions
SlaveComputer#setChannel() checks the option status. Depending on it, it may either accept or reject the connection

Add Comment

This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)

o.v.nenashev@gmail.com (JIRA)

unread,

Mar 16, 2018, 4:56:02 AM3/16/18

to jenkinsc...@googlegroups.com

Oleg Nenashev updated an issue

Jenkins /

JENKINS-50211

Add an option to optionally reject connections from agents with unsupported Remoting versions

Change By:	Oleg Nenashev

It is a follow-up to JENKINS-48766. That story adds warnings for unsupported agent versions, but it actually does not reject them. It would be useful to have such feature in the core or in Version Column Plugin. Core is preferable though this feature may be detached to a plugin later as a part of JENKINS-44100.

Acceptance criteria:

* There is a Global Configuration entry for Remoting. An existing section for Remoting protocols may be used
* There is a checkbox in the configuration, which turns on rejection of unsupported versions
* SlaveComputer#setChannel() checks the option status. Depending on it, it may either accept or reject the connection
* Nice2have: Automatic test which confirms that the flag survives restarts
* Nice2have: Automatic test which picks unsupported version of Remoting and confirms that it cannot connect

Add Comment

o.v.nenashev@gmail.com (JIRA)

unread,

Mar 16, 2018, 4:57:01 AM3/16/18

to jenkinsc...@googlegroups.com

Oleg Nenashev updated an issue

Jenkins /

JENKINS-50211

Add an option to optionally reject connections from agents with unsupported Remoting versions

Change By:	Oleg Nenashev
Issue Type:	Bug New Feature

Add Comment

o.v.nenashev@gmail.com (JIRA)

unread,

Mar 16, 2018, 4:57:02 AM3/16/18

to jenkinsc...@googlegroups.com

Oleg Nenashev updated an issue

Jenkins /

JENKINS-50211

Add an option to optionally reject connections from agents with unsupported Remoting versions

Change By:	Oleg Nenashev
Priority:	Minor Major

Add Comment

o.v.nenashev@gmail.com (JIRA)

unread,

Mar 16, 2018, 4:58:02 AM3/16/18

to jenkinsc...@googlegroups.com

Oleg Nenashev updated an issue

Jenkins /

JENKINS-50211

Add an option to optionally reject connections from agents with unsupported Remoting versions

Change By:	Oleg Nenashev

It is a follow-up to JENKINS-48766. That story adds warnings for unsupported agent versions, but it actually does not reject them. It would be useful to have such feature in the core or in Version Column Plugin. Core is preferable though this feature may be detached to a plugin later as a part of JENKINS-44100.

Acceptance criteria:

* There is a Global Configuration entry for Remoting. An existing section for Remoting protocols may be used
* There is a checkbox in the configuration, which turns on rejection of unsupported versions
* SlaveComputer#setChannel() checks the option status. Depending on it, it may either accept or reject the connection
* Nice2have: Automatic test which confirms that the flag survives restarts

* Nice2have: Automatic test which picks unsupported version of Remoting and confirms that it cannot connect . See examples in https://github.com/jenkinsci/jenkins/blob/master/test/src/test/java/jenkins/slaves/OldRemotingAgentTest.java