[JIRA] (JENKINS-59016) GitHub branch source won't scan with folder scoped credentials

17 views
Skip to first unread message

mark.earl.waite@gmail.com (JIRA)

unread,
Aug 20, 2019, 3:19:03 PM8/20/19
to jenkinsc...@googlegroups.com
Mark Waite created an issue
 
Jenkins / Bug JENKINS-59016
GitHub branch source won't scan with folder scoped credentials
Issue Type: Bug Bug
Assignee: Unassigned
Components: github-branch-source-plugin
Created: 2019-08-20 19:18
Environment: Jenkins 2.176.2
GitHub Branch Source plugin 2.5.6
Git plugin 3.12.0
Priority: Major Major
Reporter: Mark Waite

If I define a credential at the root level, then the GitHub branch source can use the credential to scan the repository for branches. If I define the credential in a folder, then the GitHub branch source accepts the credential, but then the scan log reports:

Started
[Tue Aug 20 13:00:40 MDT 2019] Starting branch indexing...
13:00:40 Connecting to https://api.github.com with no credentials, anonymous access

Without the credentials, scanning of private repositories is not allowed and scanning of public repositories is limited by a much smaller value for the GitHub API rate limit.

Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

mark.earl.waite@gmail.com (JIRA)

unread,
Aug 20, 2019, 3:29:01 PM8/20/19
to jenkinsc...@googlegroups.com
Mark Waite updated an issue
Change By: Mark Waite
If I define a credential at the root level, then the GitHub branch source can use the credential to scan the repository for branches.  If I define the credential in a folder, then the GitHub branch source accepts the credential, but then the scan log reports:

{code}

Started
[Tue Aug 20 13:00:40 MDT 2019] Starting branch indexing...
13:00:40 Connecting to https://api.github.com with no credentials, anonymous access
{code}


Without the credentials, scanning of private repositories is not allowed and scanning of public repositories is limited by a much smaller value for the GitHub API rate limit.


The problem does not appear in GitHub branch source plugin 2.5.3.

mark.earl.waite@gmail.com (JIRA)

unread,
Aug 20, 2019, 3:30:02 PM8/20/19
to jenkinsc...@googlegroups.com

mark.earl.waite@gmail.com (JIRA)

unread,
Aug 20, 2019, 3:38:01 PM8/20/19
to jenkinsc...@googlegroups.com
Mark Waite updated an issue
If I define a credential at the root level, then the GitHub branch source can use the credential to scan the repository for branches.  If I define the credential in a folder, then the GitHub branch source accepts the credential, but then the scan log reports:

{code}
Started
[Tue Aug 20 13:00:40 MDT 2019] Starting branch indexing...
13:00:40 Connecting to https://api.github.com with no credentials, anonymous access
{code}

Without the credentials, scanning of private repositories is not allowed and scanning of public repositories is limited by a much smaller value for the GitHub API rate limit.


The problem also exists in GitHub branch source plugin 2.5.3 and in GitHub branch source plugin 2.3.6 from a year ago.  This is a long-standing problem and not a recent regression.

mark.earl.waite@gmail.com (JIRA)

unread,
Aug 20, 2019, 5:44:01 PM8/20/19
to jenkinsc...@googlegroups.com
Mark Waite updated an issue
If I define a credential at the root level, then the GitHub branch source can use the credential to scan the repository for branches.  If I define the credential in a folder, then the GitHub branch source accepts the credential, but then the scan log reports:

{code}
Started
[Tue Aug 20 13:00:40 MDT 2019] Starting branch indexing...
13:00:40 Connecting to https://api.github.com with no credentials, anonymous access
{code}

Without the credentials, scanning of private repositories is not allowed and scanning of public repositories is limited by a much smaller value for the GitHub API rate limit.

The problem also exists in GitHub branch source plugin 2.5.3 and .  It does not seem to be an issue in GitHub branch source plugin 2.3.6 from a year ago.   This is a long-standing problem and not a recent   Needs more investigation to narrow the release which introduced the regression.

mark.earl.waite@gmail.com (JIRA)

unread,
Aug 20, 2019, 7:28:02 PM8/20/19
to jenkinsc...@googlegroups.com
Mark Waite updated an issue
If I define a credential at the root level, then the GitHub branch source can use the credential to scan the repository for branches.  If I define the credential in a folder, then the GitHub branch source accepts the credential, but then the scan log reports:

{code}
Started
[Tue Aug 20 13:00:40 MDT 2019] Starting branch indexing...
13:00:40 Connecting to https://api.github.com with no credentials, anonymous access
{code}

Without the credentials, scanning of private repositories is not allowed and scanning of public repositories is limited by a much smaller value for the GitHub API rate limit.

||Version||Result||
||2.5.6||Credentials ignored|
||2.5.5||Credentials ignored|
||2.5.4|
| Credentials honored|
||2.5.3|
| Credentials honored|
||2.4.5|
| Credentials honored|
||2.3.6|
| Credentials honored|

mark.earl.waite@gmail.com (JIRA)

unread,
Aug 20, 2019, 7:28:02 PM8/20/19
to jenkinsc...@googlegroups.com
Mark Waite updated an issue
If I define a credential at the root level, then the GitHub branch source can use the credential to scan the repository for branches.  If I define the credential in a folder, then the GitHub branch source accepts the credential, but then the scan log reports:

{code}
Started
[Tue Aug 20 13:00:40 MDT 2019] Starting branch indexing...
13:00:40 Connecting to https://api.github.com with no credentials, anonymous access
{code}

Without the credentials, scanning of private repositories is not allowed and scanning of public repositories is limited by a much smaller value for the GitHub API rate limit.

The problem also exists in GitHub branch source plugin ||Version||Result||
||
2.5. 3 6||Credentials ignored|
||2
.   It does not seem to be an issue in GitHub branch source plugin 5.5||Credentials ignored|
||
2. 5.4||Credentials honored|
||2.5.
3 ||Credentials honored|
||2
. 6 from a year ago 4 .   Needs more investigation to narrow the release which introduced the regression 5||Credentials honored|
||2
. 3.6||Credentials honored|

mark.earl.waite@gmail.com (JIRA)

unread,
Aug 20, 2019, 7:54:02 PM8/20/19
to jenkinsc...@googlegroups.com
Mark Waite updated an issue
If I define a credential at the root level, then the GitHub branch source can use the credential to scan the repository for branches.  If I define the credential in a folder, then the GitHub branch source accepts the credential, but then the scan log reports:

{code}
Started
[Tue Aug 20 13:00:40 MDT 2019] Starting branch indexing...
13:00:40 Connecting to https://api.github.com with no credentials, anonymous access
{code}

Without the credentials, scanning of private repositories is not allowed and scanning of public repositories is limited by a much smaller value for the GitHub API rate limit.

||Version||Result||
||2.5.6||Credentials ignored|
||2.5.5||Credentials ignored|
||2.5.4|Credentials honored|
||2.5.3|Credentials honored|
||2.4.5|Credentials honored|
||2.3.6|Credentials honored|

Refer to the [JENKINS-59016 branch in my jenkins-bugs repo|https://github.com/MarkEWaite/jenkins-bugs/tree/JENKINS-59016] for the Jenkins Pipeline that I use to test this.  The jobs are run from inside a Docker image that I use which includes credentials used to access the repository.

mark.earl.waite@gmail.com (JIRA)

unread,
Aug 20, 2019, 7:56:01 PM8/20/19
to jenkinsc...@googlegroups.com
Mark Waite commented on Bug JENKINS-59016
 
Re: GitHub branch source won't scan with folder scoped credentials

Based on the change history between 2.5.4 and 2.5.5, I assume that Liam Newman or Devin Nusbaum or Jose Blas Camacho Taboada are the likely ones to investigate the code.

mark.earl.waite@gmail.com (JIRA)

unread,
Aug 21, 2019, 1:06:02 PM8/21/19
to jenkinsc...@googlegroups.com

mark.earl.waite@gmail.com (JIRA)

unread,
Aug 21, 2019, 1:18:03 PM8/21/19
to jenkinsc...@googlegroups.com
Mark Waite updated an issue
If I define a credential at the root level, then the GitHub branch source can use the credential to scan the repository for branches.  If I define the credential in a folder, then the GitHub branch source accepts the credential, but then the scan log reports:

{code}
Started
[Tue Aug 20 13:00:40 MDT 2019] Starting branch indexing...
13:00:40 Connecting to https://api.github.com with * no credentials * , anonymous access

{code}

Without the credentials, scanning of private repositories is not allowed and scanning of public repositories is limited by a much smaller value for the GitHub API rate limit.

||Version||Result||
||2.5.6||Credentials ignored|
||2.5.5||Credentials ignored|
||2.5.4|Credentials honored|
||2.5.3|Credentials honored|
||2.4.5|Credentials honored|
||2.3.6|Credentials honored|

Refer to the [JENKINS-59016 branch in my jenkins-bugs repo|https://github.com/MarkEWaite/jenkins-bugs/tree/JENKINS-59016] for the Jenkins Pipeline that I use to test this.  The jobs are run from inside a Docker image that I use which includes credentials used to access the repository.

mark.earl.waite@gmail.com (JIRA)

unread,
Aug 21, 2019, 1:18:03 PM8/21/19
to jenkinsc...@googlegroups.com

mark.earl.waite@gmail.com (JIRA)

unread,
Aug 21, 2019, 1:19:02 PM8/21/19
to jenkinsc...@googlegroups.com
Mark Waite updated an issue
If I define a credential at the root level, then the GitHub branch source can use the credential to scan the repository for branches.  If I define the credential in a folder, then the GitHub branch source accepts the credential, but then the scan does not use the credential and the scan log reports:


{code}
Started
[Tue Aug 20 13:00:40 MDT 2019] Starting branch indexing...
13:00:40 Connecting to https://api.github.com with no credentials, anonymous access

{code}

Without the credentials, scanning of private repositories is not allowed and scanning of public repositories is limited by a much smaller value for the GitHub API rate limit.

||Version||Result||
||2.5.6||Credentials ignored|
||2.5.5||Credentials ignored|
||2.5.4|Credentials honored|
||2.5.3|Credentials honored|
||2.4.5|Credentials honored|
||2.3.6|Credentials honored|

Refer to the [JENKINS-59016 branch in my jenkins-bugs repo|https://github.com/MarkEWaite/jenkins-bugs/tree/JENKINS-59016] for the Jenkins Pipeline that I use to test this.  The jobs are run from inside a Docker image that I use which includes credentials used to access the repository.
Reply all
Reply to author
Forward
0 new messages