[JIRA] [core] (JENKINS-31511) Recent (since 1.628) bug introduced into pluginManager filter UI

[ronabop@gmail.com (JIRA)]

Ronald Gundlach-Chmara created an issue

Jenkins / JENKINS-31511 Recent (since 1.628) bug introduced into pluginManager filter UI Issue Type: Bug Assignee: Unassigned Attachments: Installed plugin filter1.png, Installed plugin filter2.png Components: core Created: 12/Nov/15 1:04 AM Environment: Filter not working in 1.638, worked in 1.628 Priority: Minor Reporter: Ronald Gundlach-Chmara Jenkins was, on typing characters into the filter section of the plugin window, filtering results, it no longer works as expected. Attached are screenshots for 1.628 and 1.638 for comparison. Note the filter string of "OWA" is reflected in 1.628, the other screenshot is 1.638 (version number is scrolled off the screen). Add Comment

This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265)

[christopherleesimons@gmail.com (JIRA)]

Christopher Simons assigned an issue to Christopher Simons

Jenkins / JENKINS-31511 Recent (since 1.628) bug introduced into pluginManager filter UI

Change By: Christopher Simons Assignee: Christopher Simons

Add Comment

[christopherleesimons@gmail.com (JIRA)]

Christopher Simons started work on JENKINS-31511

Change By: Christopher Simons Status: Open In Progress

Add Comment

[christopherleesimons@gmail.com (JIRA)]

Christopher Simons commented on JENKINS-31511

Re: Recent (since 1.628) bug introduced into pluginManager filter UI Verified bug exists on Chrome in 46.0.2490.80 (64-bit) on Linux against repository tag 'jenkins-1.638' but does not exist on tag 'jenkins-1.628'. When testing, note that the search does not seem to be broken on the default tab, but is broken on the "Installed" tab. When entering a search term, the list results do seem to change sometimes, but more results are returned than are warranted by the search term. Results of git-bisect debugging: 3b5424e507be2e59eabfd3f55ce16cd2b58a6195 is the first bad commit commit 3b5424e507be2e59eabfd3f55ce16cd2b58a6195 Author: tfennelly <tom.fe...@gmail.com> Date: Fri Sep 25 12:22:46 2015 +0100 Only allow disable or uninstall when all dependants or dependencies are disabled/enabled

Add Comment

[christopherleesimons@gmail.com (JIRA)]

Christopher Simons stopped work on JENKINS-31511

Change By: Christopher Simons Status: In Progress Open

Add Comment

[dbeck@cloudbees.com (JIRA)]

Daniel Beck commented on JENKINS-31511

Re: Recent (since 1.628) bug introduced into pluginManager filter UI

Christopher Simons Are you planning to work on this as you assigned yourself?

Add Comment

[christopherleesimons@gmail.com (JIRA)]

Christopher Simons assigned an issue to Unassigned

Daniel Beck Initially I was planning on fixing this but have since gotten sidetracked by other demands. I've unassigned this.

Jenkins / JENKINS-31511

Recent (since 1.628) bug introduced into pluginManager filter UI

Change By: Christopher Simons Assignee: Christopher Simons

Add Comment

[dbeck@cloudbees.com (JIRA)]

Daniel Beck updated an issue

Jenkins / JENKINS-31511 Recent (since 1.628) bug introduced into pluginManager filter UI

Change By: Daniel Beck Labels: lts-candidate regression

Add Comment

[christopherleesimons@gmail.com (JIRA)]

Christopher Simons edited a comment on JENKINS-31511

Re: Recent (since 1.628) bug introduced into pluginManager filter UI [~danielbeck] Initially  I was planning on fixing  planned to fix  this but have since gotten sidetracked by other demands.  I've unassigned this.

Add Comment

[christopherleesimons@gmail.com (JIRA)]

Christopher Simons edited a comment on JENKINS-31511

Re: Recent (since 1.628) bug introduced into pluginManager filter UI

[~danielbeck] Initially  I  planned to fix this but have since gotten sidetracked by other demands.  I've unassigned this.

Add Comment

[christopherleesimons@gmail.com (JIRA)]

Christopher Simons edited a comment on JENKINS-31511

Re: Recent (since 1.628) bug introduced into pluginManager filter UI

Verified bug exists  on  from  Chrome in 46.0.2490.80 ( Linux 64-bit) on  Linux against  repository tag 'jenkins-1.638' but does not exist on tag 'jenkins-1.628'.

When testing, note that the search does not seem to be broken on the default tab, but is broken on the "Installed" tab.  When entering a search term, the list results do seem to change sometimes, but more results are returned than are warranted by the search term. Results of git-bisect debugging:

{code}

3b5424e507be2e59eabfd3f55ce16cd2b58a6195 is the first bad commit commit 3b5424e507be2e59eabfd3f55ce16cd2b58a6195 Author: tfennelly <tom.fe...@gmail.com> Date:   Fri Sep 25 12:22:46 2015 +0100     Only allow disable or uninstall when all dependants or dependencies are disabled/enabled

{code}

Add Comment

[dbeck@cloudbees.com (JIRA)]

Daniel Beck commented on JENKINS-31511

Re: Recent (since 1.628) bug introduced into pluginManager filter UI

This is funny – the filtering actually works, but it also considers plugins that have an (explicit or implied) dependency on any plugin with that name. In the case of OWASP Markup Formatter Plugin, this is (due to how dependencies to detached-from-core plugins work and when this one was detached from core) almost every plugin. If you filter for a string that does not match any plugin that has been detached from core (mostly what Jenkins came bundled with), it works as expected. Not sure whether this is deliberate. Pinging Tom FENNELLY to shed some light on this.

Add Comment

[dbeck@cloudbees.com (JIRA)]

Daniel Beck updated an issue

Jenkins / JENKINS-31511

Recent (since 1.628) bug introduced into pluginManager filter UI

Change By: Daniel Beck Labels: lts-candidate newbie-friendly regression

Add Comment

This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)

[dbeck@cloudbees.com (JIRA)]

Daniel Beck updated an issue

Jenkins / JENKINS-31511 Recent (since 1.628) bug introduced into pluginManager filter UI Change By: Daniel Beck Labels: lts-candidate newbie-friendly regression Add Comment

This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)

[dbeck@cloudbees.com (JIRA)]

Daniel Beck commented on JENKINS-31511

Re: Recent (since 1.628) bug introduced into pluginManager filter UI The behavior remains; with recent plugin releases more easily observable when typing command-launcher as that has been detached from core fairly recently.

Add Comment

[dbeck@cloudbees.com (JIRA)]

Daniel Beck commented on JENKINS-31511

Re: Recent (since 1.628) bug introduced into pluginManager filter UI

applyFilter does not handle the fact that each row has hidden divs containing the plugin dependency information in span}}s. So it's not as trivial as just {{innerHTML.

Add Comment

[dbeck@cloudbees.com (JIRA)]

Daniel Beck edited a comment on JENKINS-31511

Re: Recent (since 1.628) bug introduced into pluginManager filter UI

{{applyFilter}} in {{PluginManager/_table.js}} does not handle the fact that each row has hidden divs containing the plugin dependency information in {{span}}s. So it's not as trivial as just \ { \ {innerHTML}}.

Add Comment

[chig@dickinson.edu (JIRA)]

Allan C assigned an issue to Allan C

Jenkins / JENKINS-31511

Recent (since 1.628) bug introduced into pluginManager filter UI

Change By: Allan C Assignee: Allan C

Add Comment

This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)

[chig@dickinson.edu (JIRA)]

Allan C assigned an issue to Unassigned

[chig@dickinson.edu (JIRA)]

Allan C commented on JENKINS-31511

Re: Recent (since 1.628) bug introduced into pluginManager filter UI Hi, I just ran into this bug and tried to replicate it on my machine. It appeared that this bug did not appear on Jenkins 2.190.3, Firefox 70.0.1 on Ubuntu 18.04.3 LTS.

Add Comment