[JIRA] (JENKINS-58241) Support comments to skip line

timjacomb1@gmail.com (JIRA)

unread,

Jun 27, 2019, 3:39:02 PM6/27/19

to jenkinsc...@googlegroups.com

Tim Jacomb created an issue

Jenkins /

JENKINS-58241

Support comments to skip line

Issue Type:	Improvement
Assignee:	Natasha Stopa
Components:	plugin-installation-manager-tool
Created:	2019-06-27 19:38
Priority:	Minor
Reporter:	Tim Jacomb

In install-plugins.sh it skips lines starting with #
I tried this on the plugins.txt file we use for our docker image, and it failed because we have a couple of commented out plugins in there, see stacktrace:

 
                                                                Exception in thread "main" java.lang.IllegalArgumentException: Illegal character in fragment at index 61: https://updates.jenkins.io/download/plugins/#sonar/2.9-hmcts/#sonar.hpiException in thread "main" java.lang.IllegalArgumentException: Illegal character in fragment at index 61: https://updates.jenkins.io/download/plugins/#sonar/2.9-hmcts/#sonar.hpi at java.net.URI.create(URI.java:852) at org.apache.http.client.methods.HttpGet.<init>(HttpGet.java:66) at io.jenkins.tools.pluginmanager.impl.PluginManager.downloadToFile(PluginManager.java:356) at io.jenkins.tools.pluginmanager.impl.PluginManager.downloadPlugin(PluginManager.java:301) at io.jenkins.tools.pluginmanager.impl.PluginManager.downloadPlugins(PluginManager.java:196) at io.jenkins.tools.pluginmanager.impl.PluginManager.start(PluginManager.java:111) at io.jenkins.tools.pluginmanager.cli.Main.main(Main.java:94)Caused by: java.net.URISyntaxException: Illegal character in fragment at index 61: https://updates.jenkins.io/download/plugins/#sonar/2.9-hmcts/#sonar.hpi at java.net.URI$Parser.fail(URI.java:2848) at java.net.URI$Parser.checkChars(URI.java:3021) at java.net.URI$Parser.parse(URI.java:3067) at java.net.URI.<init>(URI.java:588) at java.net.URI.create(URI.java:850) ... 6 more  
                                                            