| I've not tried 2.190.1 yet, but I can definitely reproduce this double-submit issue with Firefox 68.1.0esr and 70.0b10, and Jenkins 2.176.3, as soon as there are file parameters for a job. I don't think "Parameterized Trigger Plugin" has anything to do with this issue, it can be reproduced while running Jenkins from sources with "mvn org.jenkins-ci.tools:maven-jenkins-dev-plugin:run", which doesn't include this plugin.
And I definitely can't reproduce if using Firefox 66, the latest version available on Ubuntu Trusty (I've not tried 67). Also, I see the same issue in the plugins manager (running from Jenkins sources on the 2.176.3 tag):
- go to /jenkins/pluginManager/advanced
- select some random file to upload (don't bother picking a real .hpi if you don't actually want to install a plugin)
- submit (with Firefox dev tools enabled on network monitor)
- notice that there are 2 identical POST requests sent for /jenkins/pluginManager/uploadPlugin
(and in case you actually upload a .hpi plugin, you'll see in Jenkins log that there are two attempts at loading it, with the later in failure)
Of course I can't say for sure that the "file parameters" bug on jobs and the ".hpi plugin upload" bug are indeed the same bug, but it sounds really very similar. Oh, and I've tried reverting acc4eec688a (from #3761 / JENKINS-53462), again on 2.176.3 sources: it fixes the issue both for running jobs with file parameters, and for uploading a file to the plugins manager. Actually, with this commit reverted, it seems that everything works fine in these two forms, both in FF 66 and 70. And running a job with no file parameter (only a string parameter) works fine too, so I'm starting to doubt this change was really necessary (my understanding of JENKINS-53462 was that form submission without this patch should have broke in recent FF versions). |
