[JIRA] (JENKINS-36002) Add $ErrorActionPreference = "Stop" to the top of each script before executing

[ohads@microsoft.com (JIRA)]

Ohad Schneider created an issue

Jenkins / JENKINS-36002 Add $ErrorActionPreference = "Stop" to the top of each script before executing Issue Type: Improvement Assignee: Unassigned Components: powershell-plugin Created: 2016/Jun/16 8:59 AM Environment: Jenkins 1.628 powershell-plugin 1.2 Priority: Minor Reporter: Ohad Schneider Just as bash scripts are executed with set -e (as to terminate on any error), so should PowerShell scripts be executed with $ErrorActionPreference = "Stop" at the top (to the same effect). Not only is it more consistent (e.g. with bash), it is also usually a more desirable behavior in CI scenarios (when you allow the script to continue you can miss important silent errors). A user can always start his script with $ErrorActionPreference = "Continue" to override this, or it could be a checkbox, or the user could simply wrap potentially erronous statements in a try-catch block (probably the best solution). Add Comment

This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)

[nathandstovall@gmail.com (JIRA)]

Nate Stovall commented on JENKINS-36002

Re: Add $ErrorActionPreference = "Stop" to the top of each script before executing Instead of a fixed default, perhaps a dropdownbox of choices, with the default choice being the PowerShell default could be in put above the command text entry window. Or, you can do what I do and put $ErrorActionPreference = "SilentlyContinue" as the first line of the script.

Add Comment

[ohads@microsoft.com (JIRA)]

Ohad Schneider commented on JENKINS-36002

Re: Add $ErrorActionPreference = "Stop" to the top of each script before executing

Nate Stovall of course adding it manually is a possiblity, just as adding set -e to the top of each bash script would be. But the fact is, Jenkins effectively adds set -e to the top of each bash script without even asking you, so the most consistent thing to do would be do the PS equivalent which is $ErrorActionPreference = "SilentlyContinue". A dropdown (with stop as the default) would be even better, of course...

Add Comment

[ohads@microsoft.com (JIRA)]

Ohad Schneider edited a comment on JENKINS-36002

Re: Add $ErrorActionPreference = "Stop" to the top of each script before executing

[~natestovall] of course adding it manually is a possiblity possibility , just as adding _set -e_ to the top of each bash script would be. But the fact is, Jenkins effectively adds _set -e_ to the top of each bash script without even asking you, so the most consistent thing to do would be do the PS equivalent which is _$ErrorActionPreference = "SilentlyContinue"_. A dropdown (with _stop_ as the default) would be even better, of course...

Add Comment

[ohads@microsoft.com (JIRA)]

Ohad Schneider edited a comment on JENKINS-36002

Re: Add $ErrorActionPreference = "Stop" to the top of each script before executing

[~natestovall] of course adding it manually is a possibility, just as adding _set -e_ to the top of each bash script would be. But the fact is, Jenkins effectively adds _set -e_ to the top of each bash script without even asking you, so the most consistent thing to do would be do to use the PS equivalent which is _$ErrorActionPreference = "SilentlyContinue"_. A dropdown (with _stop_ as the default) would be even better, of course...

Add Comment

[rausalinas@gmail.com (JIRA)]

Raúl Salinas-Monteagudo commented on JENKINS-36002

Re: Add $ErrorActionPreference = "Stop" to the top of each script before executing

This is a great idea, in most cases, you don't want scripts to go on when they encounter failures. I'd rather have false positive abortions than false negatives.

Add Comment

This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

[privat@michaelbrunner.de (JIRA)]

Michael Brunner commented on JENKINS-36002

Re: Add $ErrorActionPreference = "Stop" to the top of each script before executing

Just had the same issue. Script expected some argument, which I didn't pass in. Jenkins still shows green.

Add Comment

This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)