[JIRA] (JENKINS-57789) Warning-ng plugin doesn't capture 'Hint' output from msBuild

22 views
Skip to first unread message

martinmoore@polaris-elements.co.uk (JIRA)

unread,
May 31, 2019, 9:18:03 AM5/31/19
to jenkinsc...@googlegroups.com
Martin Moore created an issue
 
Jenkins / Improvement JENKINS-57789
Warning-ng plugin doesn't capture 'Hint' output from msBuild
Issue Type: Improvement Improvement
Assignee: Ulli Hafner
Components: warnings-ng-plugin
Created: 2019-05-31 13:17
Environment: Win10/64 warnings-ng v5.0.0 Jenkins v2.164.3
Priority: Minor Minor
Reporter: Martin Moore

The msBuild output can include Warnings and Hints. Currently Hints are ignored. It would be very useful if they were included and any increase in the number of hints treated as a fail in qualityGate.

Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

ullrich.hafner@gmail.com (JIRA)

unread,
May 31, 2019, 10:44:03 AM5/31/19
to jenkinsc...@googlegroups.com
Ulli Hafner assigned an issue to Unassigned
 

Can you please add one whole console log line with an example that can be used in a test?

Change By: Ulli Hafner
Summary: Warning-ng plugin doesn't process hints and warnings correctly when building Delphi with capture 'Hint' output from msBuild
Labels: help-wanted newbie-friendly
Assignee: Ulli Hafner

alexmace@polaris-elements.co.uk (JIRA)

unread,
May 31, 2019, 10:48:02 AM5/31/19
to jenkinsc...@googlegroups.com
Alex Mace updated an issue
Change By: Alex Mace
The When building Delphi projects with msBuild , the output can include Warnings and Hints. Currently Hints are ignored. It would be very useful if they were included and any increase in the number of hints treated as a fail in qualityGate.

Additionally the parser misidentifies the affected files. Sample console log:
    Embarcadero Delphi for Win32 compiler version 21.0
    Copyright (c) 1983,2009 Embarcadero Technologies, Inc.
    
    C:\Program Files (x86)\Embarcadero\RAD Studio\7.0\Bin\CodeGear.Delphi.Targets : warning : C:\Delphi Projects\DCU 2010\indy10\Lib\System\IdWship6.pas(469) Warning: W1000 Symbol 'GIdIPv6FuncsAvailable' is deprecated
    
    C:\Program Files (x86)\Embarcadero\RAD Studio\7.0\Bin\CodeGear.Delphi.Targets : warning : C:\Delphi Projects\DCU 2010\indy10\Lib\System\IdWship6.pas(1221) Warning: W1000 Symbol 'GIdIPv6FuncsAvailable' is deprecated
    
    C:\Delphi Projects\DCU 2010\Externals\Lib\Delphi\IBSQL.pas(205) hint: H2219 Private symbol 'GetCodePage' declared but never used
    
    C:\Program Files (x86)\Embarcadero\RAD Studio\7.0\Bin\CodeGear.Delphi.Targets : warning : C:\Program Files (x86)\Jenkins\workspace\POS_Manager_develop\Externals\Lib\Common\FBHStrUtils.pas(349) Warning: W1024 Combining signed and unsigned types - widened both operands
    269261 lines, 2.61 seconds, 2496188 bytes code, 595788 bytes data.
Done building target "CoreCompile" in project "POSManagerTests.dproj".

Done building project "POSManagerTests.dproj".

Build succeeded.
C:\Program Files (x86)\Embarcadero\RAD Studio\7.0\Bin\CodeGear.Delphi.Targets : warning : C:\Delphi Projects\DCU 2010\indy10\Lib\System\IdWship6.pas(469) Warning: W1000 Symbol 'GIdIPv6FuncsAvailable' is deprecated
C:\Program Files (x86)\Embarcadero\RAD Studio\7.0\Bin\CodeGear.Delphi.Targets : warning : C:\Delphi Projects\DCU 2010\indy10\Lib\System\IdWship6.pas(1221) Warning: W1000 Symbol 'GIdIPv6FuncsAvailable' is deprecated
C:\Program Files (x86)\Embarcadero\RAD Studio\7.0\Bin\CodeGear.Delphi.Targets : warning : C:\Program Files (x86)\Jenkins\workspace\POS_Manager_develop\Externals\Lib\Common\FBHStrUtils.pas(349) Warning: W1024 Combining signed and unsigned types - widened both operands
    3 Warning(s)
    0 Error(s)
warnings-ng reports the affected file being C:\Program Files (x86)\Embarcadero\RAD Studio\7.0\Bin\CodeGear.Delphi.Targets, rather than C:\Delphi Projects\DCU 2010\indy10\Lib\System\IdWship6.pas

I suspect it would report the hint correctly, but the ignores it entirely (I imagine because the parser isn't looking for "hints" in the output of msbuild.

 

alexmace@polaris-elements.co.uk (JIRA)

unread,
May 31, 2019, 10:50:02 AM5/31/19
to jenkinsc...@googlegroups.com
Alex Mace updated an issue
When building Delphi projects with msBuild, the output can include Warnings and Hints. Currently Hints are ignored. It would be very useful if they were included and any increase in the number of hints treated as a fail in qualityGate.


Additionally the parser misidentifies the affected files. Sample console log:
{code:java}
    Embarcadero Delphi for Win32 compiler version 21.0
    Copyright (c) 1983,2009 Embarcadero Technologies, Inc.
    
    C:\Program Files (x86)\Embarcadero\RAD Studio\7.0\Bin\CodeGear.Delphi.Targets : warning : C:\Delphi Projects\DCU 2010\indy10\Lib\System\IdWship6.pas(469) Warning: W1000 Symbol 'GIdIPv6FuncsAvailable' is deprecated
    
    C:\Program Files (x86)\Embarcadero\RAD Studio\7.0\Bin\CodeGear.Delphi.Targets : warning : C:\Delphi Projects\DCU 2010\indy10\Lib\System\IdWship6.pas(1221) Warning: W1000 Symbol 'GIdIPv6FuncsAvailable' is deprecated
    
    C:\Delphi Projects\DCU 2010\Externals\Lib\Delphi\IBSQL.pas(205) hint: H2219 Private symbol 'GetCodePage' declared but never used
    
    C:\Program Files (x86)\Embarcadero\RAD Studio\7.0\Bin\CodeGear.Delphi.Targets : warning : C:\Program Files (x86)\Jenkins\workspace\POS_Manager_develop\Externals\Lib\Common\FBHStrUtils.pas(349) Warning: W1024 Combining signed and unsigned types - widened both operands
    269261 lines, 2.61 seconds, 2496188 bytes code, 595788 bytes data.
Done building target "CoreCompile" in project "POSManagerTests.dproj".

Done building project "POSManagerTests.dproj".

Build succeeded.
C:\Program Files (x86)\Embarcadero\RAD Studio\7.0\Bin\CodeGear.Delphi.Targets : warning : C:\Delphi Projects\DCU 2010\indy10\Lib\System\IdWship6.pas(469) Warning: W1000 Symbol 'GIdIPv6FuncsAvailable' is deprecated
C:\Program Files (x86)\Embarcadero\RAD Studio\7.0\Bin\CodeGear.Delphi.Targets : warning : C:\Delphi Projects\DCU 2010\indy10\Lib\System\IdWship6.pas(1221) Warning: W1000 Symbol 'GIdIPv6FuncsAvailable' is deprecated
C:\Program Files (x86)\Embarcadero\RAD Studio\7.0\Bin\CodeGear.Delphi.Targets : warning : C:\Program Files (x86)\Jenkins\workspace\POS_Manager_develop\Externals\Lib\Common\FBHStrUtils.pas(349) Warning: W1024 Combining signed and unsigned types - widened both operands
    3 Warning(s)
    0 Error(s)
{code}

warnings-ng reports the affected file being C:\Program Files (x86)\Embarcadero\RAD Studio\7.0\Bin\CodeGear.Delphi.Targets, rather than C:\Delphi Projects\DCU 2010\indy10\Lib\System\IdWship6.pas

I suspect it would report the hint correctly, but the ignores it entirely (I imagine because the parser isn't looking for "hints" in the output of msbuild.

 

martinmoore@polaris-elements.co.uk (JIRA)

unread,
May 31, 2019, 10:53:02 AM5/31/19
to jenkinsc...@googlegroups.com
Martin Moore updated an issue
Change By: Martin Moore
When building Delphi projects with msBuild, the output can include Warnings and Hints. Currently Hints are ignored. It would be very useful if they were included and any increase in the number of hints treated as a fail in qualityGate.

Additionally the parser misidentifies the affected files. Sample console log:
{code:java}
Embarcadero Delphi for Win32 compiler version 21.0
Copyright (c) 1983,2009 Embarcadero Technologies, Inc.
C:\Program Files (x86)\Embarcadero\RAD Studio\7.0\Bin\CodeGear.Delphi.Targets : warning : C:\Delphi Projects\DCU 2010\indy10\Lib\System\IdWship6.pas(469) Warning: W1000 Symbol 'GIdIPv6FuncsAvailable' is deprecated
C:\Program Files (x86)\Embarcadero\RAD Studio\7.0\Bin\CodeGear.Delphi.Targets : warning : C:\Delphi Projects\DCU 2010\indy10\Lib\System\IdWship6.pas(1221) Warning: W1000 Symbol 'GIdIPv6FuncsAvailable' is deprecated
C:\Delphi Projects\DCU 2010\Externals\Lib\Delphi\IBSQL.pas(205) hint: H2219 Private symbol 'GetCodePage' declared but never used
C:\Program Files (x86)\Embarcadero\RAD Studio\7.0\Bin\CodeGear.Delphi.Targets : warning : C:\Program Files (x86)\Jenkins\workspace\POS_Manager_develop\Externals\Lib\Common\FBHStrUtils.pas(349) Warning: W1024 Combining signed and unsigned types - widened both operands
269261 lines, 2.61 seconds, 2496188 bytes code, 595788 bytes data.
Done building target "CoreCompile" in project "POSManagerTests.dproj".
Done building project "POSManagerTests.dproj".
Build succeeded.
C:\Program Files (x86)\Embarcadero\RAD Studio\7.0\Bin\CodeGear.Delphi.Targets : warning : C:\Delphi Projects\DCU 2010\indy10\Lib\System\IdWship6.pas(469) Warning: W1000 Symbol 'GIdIPv6FuncsAvailable' is deprecated
C:\Program Files (x86)\Embarcadero\RAD Studio\7.0\Bin\CodeGear.Delphi.Targets : warning : C:\Delphi Projects\DCU 2010\indy10\Lib\System\IdWship6.pas(1221) Warning: W1000 Symbol 'GIdIPv6FuncsAvailable' is deprecated
C:\Program Files (x86)\Embarcadero\RAD Studio\7.0\Bin\CodeGear.Delphi.Targets : warning : C:\Program Files (x86)\Jenkins\workspace\POS_Manager_develop\Externals\Lib\Common\FBHStrUtils.pas(349) Warning: W1024 Combining signed and unsigned types - widened both operands
3 Warning(s)
0 Error(s)
{code}

warnings-ng reports the affected file being C:\Program Files (x86)\Embarcadero\RAD Studio\7.0\Bin\CodeGear.Delphi.Targets, rather than C:\Delphi Projects\DCU 2010\indy10\Lib\System\IdWship6.pas

 

Example line with hint
{code:java}
C:\Delphi Projects\DCU 2010\Externals\Lib\Delphi\IBSQL.pas(205) hint: H2219 Private symbol 'GetCodePage' declared but never used{code}
 

I suspect it would report the hint correctly, but the ignores it entirely (I imagine because the parser isn't looking for "hints" in the output of msbuild.

 

martinmoore@polaris-elements.co.uk (JIRA)

unread,
May 31, 2019, 10:54:02 AM5/31/19
to jenkinsc...@googlegroups.com
I suspect it would report the hint correctly, but the ignores it entirely (I imagine because the parser isn't looking for "hints" in the output of msbuild.

 

Example line with hint
{code:java}
C:\Delphi Projects\DCU 2010\Externals\Lib\Delphi\IBSQL.pas(205) hint: H2219 Private symbol 'GetCodePage' declared but never used{code}
 

I suspect it would report the hint correctly, but the ignores it entirely (I imagine because the parser isn't looking for "hints" in the output of msbuild.

 

martinmoore@polaris-elements.co.uk (JIRA)

unread,
May 31, 2019, 10:54:02 AM5/31/19
to jenkinsc...@googlegroups.com

alexmace@polaris-elements.co.uk (JIRA)

unread,
May 31, 2019, 10:59:02 AM5/31/19
to jenkinsc...@googlegroups.com

alexmace@polaris-elements.co.uk (JIRA)

unread,
May 31, 2019, 11:00:01 AM5/31/19
to jenkinsc...@googlegroups.com
Alex Mace commented on Improvement JENKINS-57789
 
Re: Warning-ng plugin doesn't capture 'Hint' output from msBuild

Attached example file with the two problem lines.

ullrich.hafner@gmail.com (JIRA)

unread,
May 31, 2019, 6:27:03 PM5/31/19
to jenkinsc...@googlegroups.com

I wonder if it would make sense to write a new parser here, as the first part of such a log message actually can be totally ignored.

alexmace@polaris-elements.co.uk (JIRA)

unread,
Jun 3, 2019, 8:45:02 AM6/3/19
to jenkinsc...@googlegroups.com

For the warnings, yes, the hint I think is in the correct format that the msbuild parser can read (aside from being a Hint), but you know what's better than me.

ullrich.hafner@gmail.com (JIRA)

unread,
Jun 17, 2019, 4:34:03 PM6/17/19
to jenkinsc...@googlegroups.com
Ulli Hafner updated an issue
 
Change By: Ulli Hafner
Labels: help-wanted newbie-friendly

ullrich.hafner@gmail.com (JIRA)

unread,
Oct 1, 2019, 5:09:02 AM10/1/19
to jenkinsc...@googlegroups.com
Ulli Hafner updated an issue
Change By: Ulli Hafner
Component/s: analysis-model
Component/s: warnings-ng-plugin
This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)
Atlassian logo
Reply all
Reply to author
Forward
0 new messages