[JIRA] (JENKINS-59139) don't set GIT_LFS_SKIP_SMUDGE=1 anymore while cloning with git 2.15+

[mark.earl.waite@gmail.com (JIRA)]

Mark Waite updated an issue

Jenkins / JENKINS-59139 don't set GIT_LFS_SKIP_SMUDGE=1 anymore while cloning with git 2.15+ Change By: Mark Waite Summary: don't set GIT_LFS_SKIP_SMUDGE=1 anymore while cloning with git 2.15+ Add Comment

This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)

[rene.scheibe@gmail.com (JIRA)]

René Scheibe commented on JENKINS-59139

Re: don't set GIT_LFS_SKIP_SMUDGE=1 anymore while cloning with git 2.15+ Please also keep JENKINS-47531 in mind. When a password is provided, it can only be used if git-lfs did not yet run automatically on checkout. See https://github.com/jenkinsci/git-client-plugin/pull/280.

Add Comment

[nishichinu6@gmail.com (JIRA)]

yamhai commented on JENKINS-59139

Re: don't set GIT_LFS_SKIP_SMUDGE=1 anymore while cloning with git 2.15+

I've submitted a PR for this: https://github.com/jenkinsci/git-client-plugin/pull/476. Can you review it? Should I modify it as per Florian's last comment, where as far as I understand, all I need to do is change (lfsRemote != null) logic to something like (isLfsPresent) being initialized from `GitLFSPull`. Is that right?

Add Comment

[rene.scheibe@gmail.com (JIRA)]

René Scheibe updated an issue

Jenkins / JENKINS-59139

don't set GIT_LFS_SKIP_SMUDGE=1 anymore while cloning with git 2.15+

Change By: René Scheibe Since commit [ 853603cccd4434b116ef9b8e094c3f5b815aa75a| https://github.com/jenkinsci/git-client-plugin/commit/853603cccd4434b116ef9b8e094c3f5b815aa75a , ]   , we set  {{ GIT_LFS_SKIP_SMUDGE=1 }}   to improve performance, and require users to add the "Git LFS pull after checkout" "Additional additional behaviour " to resolve pointers.   This was mostly done because git clone performance was pretty bad with the smudge filter enabled, and in some configurations, (ssh clone URLs), git lfs pull didn't work.   Since then, a lot has improved:   Clone Performance performance through the smudge filter has improved since [https://github.com/git-lfs/git-lfs/pull/2511 .|https://github.com/git-lfs/git-lfs/pull/2511 ]   . Backends should support the ` {{ git-lfs-authenticate ` }} dance as described in [https://github.com/git-lfs/git-lfs/blob/master/docs/api/authentication.md#ssh], which retrieves a temporary authorization token to do the clone over https.   I propose to just do a git clone without setting ` {{ GIT_LFS_SKIP_SMUDGE=1 ` }} . Most systems should have done a ` {{ git lfs install ` }} before, so they will resolve the lfs pointers during a clone. We can keep the   "Git LFS pull after checkout" "Additional additional behaviour " , for systems that don't have setup global smudge filters via ` {{ git lfs install ` }} .

Add Comment