[JIRA] (JENKINS-62036) Issue parsers display incorrect data when message or description contains HTML

2 views
Skip to first unread message

msicker@cloudbees.com (JIRA)

unread,
Apr 23, 2020, 4:17:02 PM4/23/20
to jenkinsc...@googlegroups.com
Matt Sicker created an issue
 
Jenkins / Bug JENKINS-62036
Issue parsers display incorrect data when message or description contains HTML
Issue Type: Bug Bug
Assignee: Ulli Hafner
Components: warnings-ng-plugin
Created: 2020-04-23 20:16
Priority: Minor Minor
Reporter: Matt Sicker

All issue parsers in analysis-model extend IssueParser which need to parse a stream into a Report made up of Issue instances (among other thing). These Issue instances are usually created by extracting text from the console log or other log files. I haven't looked through all 100+ times it is used, but in the vast majority of cases, IssueBuilder.setMessage() is invoked with regex match groups, and those contents are treated as raw HTML (using the Unescaped class). Based on the various issue parsers I've used and looked at, they don't seem to expect HTML, though they can make use of it.

Thanks to the use of the OWASP Markup Formatter, nothing malicious can be injected, but any supported HTML and special characters will be interpreted as such when parsed from the console log.

Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)
Atlassian logo
Reply all
Reply to author
Forward
0 new messages