[JIRA] (JENKINS-58824) Warnings NG plugin skips files reported by MSBuild because they are lower case

42 views
Skip to first unread message

david.aldrich@emea.nec.com (JIRA)

unread,
Aug 6, 2019, 5:12:02 AM8/6/19
to jenkinsc...@googlegroups.com
David Aldrich created an issue
 
Jenkins / Bug JENKINS-58824
Warnings NG plugin skips files reported by MSBuild because they are lower case
Issue Type: Bug Bug
Assignee: Ulli Hafner
Attachments: image-2019-08-06-10-07-21-951.png, image-2019-08-06-10-07-53-351.png, image-2019-08-06-10-07-54-392.png
Components: warnings-ng-plugin
Created: 2019-08-06 09:11
Environment: Jenkins 2.176.2
Warnings NG plugin 5.3.0
Priority: Major Major
Reporter: David Aldrich

An example MSBuild warning is:

c:\jenkins\workspace\zodiac_visualstudio_athena_release_only\starlibs\stdstars\firfilter.h(105): warning C4244: 'argument': conversion from 'TCoeffs' to 'const ...

Warnings NG reports the warning but provides no link to the file:

Here is the Warnings NG log:

Information Messages
Parsing console log (workspace: 'c:\jenkins\workspace\Zodiac_VisualStudio_Athena_release_Only')
Post processing issues on 'jenkinswin10' with source code encoding 'UTF-8'
Resolving absolute file names for all issues in workspace 'c:\jenkins\workspace\Zodiac_VisualStudio_Athena_release_Only'
-> 10 resolved, 0 unresolved, 0 already resolved
Resolving module names from module definitions (build.xml, pom.xml, or Manifest.mf files)
-> resolved module names for 15 issues
Resolving package names (or namespaces) by parsing the affected files
-> resolved package names of 10 affected files
No filter has been set, publishing all 15 issues
Creating fingerprints for all affected code blocks to track issues over different builds
-> created fingerprints for 15 issues
Skipping blaming as requested in the job configuration
Copying affected files to Jenkins' build folder '/var/lib/jenkins/jobs/Zodiac_VisualStudio_Athena_release_Only/builds/110/files-with-issues'
-> 0 copied, 10 not in workspace, 0 not-found, 0 with I/O error
Using reference build 'Zodiac_VisualStudio_Athena_release_Only #109' to compute new, fixed, and outstanding issues
Issues delta (vs. reference build): outstanding: 15, new: 0, fixed: 3
No quality gates have been set - skipping
Health report is disabled - skipping

The actual file path is:

C:\jenkins\workspace\Zodiac_VisualStudio_Athena_release_Only\StarLibs\StdStars\FirFilter.h

A similar problem was reported in the Sonar community: https://github.com/SonarOpenCommunity/sonar-cxx/issues/1651

It seems that 'MSBuild creates always lower case paths.'

Ullrich wrote on Gitter:

Maybe an option would be to detect the OS and use an ignore-case option when trying to resolve the file names.

Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

ullrich.hafner@gmail.com (JIRA)

unread,
Aug 22, 2019, 11:23:02 AM8/22/19
to jenkinsc...@googlegroups.com
Ulli Hafner commented on Bug JENKINS-58824
 
Re: Warnings NG plugin skips files reported by MSBuild because they are lower case

Hmm, seems that the lower case paths of MSBuild are not the problem. They are correctly handled already by my plugin: https://ci.jenkins.io/job/Plugins/job/warnings-ng-plugin/job/JENKINS-58824/3/console
(from https://github.com/jenkinsci/warnings-ng-plugin/pull/184)

Since the log above contains the message Parsing console log (workspace: 'c:\jenkins\workspace\Zodiac_VisualStudio_Athena_release_Only') I wonder why the workspace is using a c: and not a C:. Did you specify the path in your agent configuration (Remote root directory) to c:\jenkins? I think this could be the problem, I need to improve the test case to see if this will fail the test...

ullrich.hafner@gmail.com (JIRA)

unread,
Aug 22, 2019, 11:25:02 AM8/22/19
to jenkinsc...@googlegroups.com
Ulli Hafner edited a comment on Bug JENKINS-58824
Hmm, seems that the lower case paths of MSBuild are not the problem. They are correctly handled already by my plugin: https://ci.jenkins.io/job/Plugins/job/warnings-ng-plugin/job/JENKINS-58824/3/console
(from https://github.com/jenkinsci/warnings-ng-plugin/pull/184)

Since the log above contains the message {{Parsing console log (workspace: 'c:\jenkins\workspace\Zodiac_VisualStudio_Athena_release_Only')}} I wonder why the workspace is using a *c:* and not a *C:*. Did you specify the path in your agent configuration (Remote root directory) to {{c:\jenkins}}? I think this could be the problem, I need to improve the test case to see if this will fail the test...
Currently the log indicates that everything works fine and just that the files of your build are not found in the workspace (this is done with a string comparison).

david.aldrich@emea.nec.com (JIRA)

unread,
Aug 22, 2019, 11:27:01 AM8/22/19
to jenkinsc...@googlegroups.com

Yes:

david.aldrich@emea.nec.com (JIRA)

unread,
Aug 22, 2019, 11:27:02 AM8/22/19
to jenkinsc...@googlegroups.com
David Aldrich updated an issue
 
Change By: David Aldrich
Attachment: image-2019-08-22-16-26-17-173.png

ullrich.hafner@gmail.com (JIRA)

unread,
Aug 22, 2019, 11:37:02 AM8/22/19
to jenkinsc...@googlegroups.com

david.aldrich@emea.nec.com (JIRA)

unread,
Aug 22, 2019, 11:39:02 AM8/22/19
to jenkinsc...@googlegroups.com

Thanks for looking into this.

ullrich.hafner@gmail.com (JIRA)

unread,
Aug 22, 2019, 5:02:03 PM8/22/19
to jenkinsc...@googlegroups.com
Ulli Hafner started work on Bug JENKINS-58824
 
Change By: Ulli Hafner
Status: Open In Progress

ullrich.hafner@gmail.com (JIRA)

unread,
Aug 22, 2019, 5:06:02 PM8/22/19
to jenkinsc...@googlegroups.com
Ulli Hafner updated an issue
 

ullrich.hafner@gmail.com (JIRA)

unread,
Aug 22, 2019, 5:14:33 PM8/22/19
to jenkinsc...@googlegroups.com

ullrich.hafner@gmail.com (JIRA)

unread,
Aug 22, 2019, 5:16:02 PM8/22/19
to jenkinsc...@googlegroups.com

Does the plugin work if you change the slave folder to C:\jenkins?

david.aldrich@emea.nec.com (JIRA)

unread,
Aug 23, 2019, 3:26:03 AM8/23/19
to jenkinsc...@googlegroups.com
David Aldrich updated an issue
 
Change By: David Aldrich
Attachment: image-2019-08-23-08-25-46-921.png

david.aldrich@emea.nec.com (JIRA)

unread,
Aug 23, 2019, 3:27:02 AM8/23/19
to jenkinsc...@googlegroups.com
David Aldrich updated an issue
Change By: David Aldrich
Attachment: image-2019-08-23-08-26-25-009.png

david.aldrich@emea.nec.com (JIRA)

unread,
Aug 23, 2019, 3:27:02 AM8/23/19
to jenkinsc...@googlegroups.com
David Aldrich commented on Bug JENKINS-58824
 
Re: Warnings NG plugin skips files reported by MSBuild because they are lower case

I changed the slave to:

but I still see no link:

I didn't disconnect/reconnect the slave.

ullrich.hafner@gmail.com (JIRA)

unread,
Aug 23, 2019, 9:55:03 AM8/23/19
to jenkinsc...@googlegroups.com

Ok thanks for checking... Do you have access to Jenkins build folder, i.e. /var/lib/jenkins/jobs/Zodiac_VisualStudio_Athena_release_Only/builds/110/? Then please have a look at the file id-outstanding-issues.xml and attach one of the issues (from the XML representation) so I can analyze the properties. Maybe I'm overlooking something obvious...

david.aldrich@emea.nec.com (JIRA)

unread,
Aug 23, 2019, 10:08:02 AM8/23/19
to jenkinsc...@googlegroups.com

From /var/lib/jenkins/jobs/Zodiac_VisualStudio_Athena_release_Only/builds/114/msbuild-outstanding-issues.xml:


<?xml version='1.1' encoding='UTF-8'?>
<analysisReport plugin="analysis-...@5.3.0">
  <elements class="linked-hash-set">
    <issue>
      <category>C4244</category>
      <type>-</type>
      <severity>NORMAL</severity>
      <message>&apos;argument&apos;: conversion from &apos;_Ty&apos; to &apos;const std::complex&lt;float&gt;::_Ty&apos;, possible loss of data</message                                     >
      <lineStart>444</lineStart>
      <lineEnd>444</lineEnd>
      <columnStart>0</columnStart>
      <columnEnd>0</columnEnd>
      <lineRanges/>
      <id>bcda9d7a-d049-4e92-9c00-805cd5446f26</id>
      <description></description>
      <reference>4</reference>
      <origin>msbuild</origin>
      <moduleName></moduleName>
      <packageName>-</packageName>
      <fileName>C:/jenkins/workspace/Zodiac_VisualStudio_Athena_release_Only/StarLibs/LinkSim/ChannelModels/TML/StarBlockFadingChannel.cpp</fileName>
      <fingerprint>C2B13AE5D790971CC5DBC2F9A5D913CD</fingerprint>
    </issue>
    <issue>
      <category>C4146</category>
      <type>-</type>
      <severity reference="../../issue/severity"/>
      <message>unary minus operator applied to unsigned type, result still unsigned</message>
      <lineStart>417</lineStart>
      <lineEnd>417</lineEnd>
      <columnStart>0</columnStart>
      <columnEnd>0</columnEnd>
      <lineRanges/>
      <id>9e3732f6-543f-4e5f-a1f2-376de8cf66b6</id>
      <description></description>
      <reference>4</reference>
      <origin>msbuild</origin>
      <moduleName></moduleName>
      <packageName>-</packageName>
      <fileName>C:/jenkins/workspace/Zodiac_VisualStudio_Athena_release_Only/StarLibs/LinkSim/LTE/FixedPoint.cpp</fileName>
      <fingerprint>D7A4F31D09478996321CDDC71F610ABE</fingerprint>
    </issue>
etc.

david.aldrich@emea.nec.com (JIRA)

unread,
Sep 2, 2019, 5:50:02 AM9/2/19
to jenkinsc...@googlegroups.com

Ulli Hafner Was the info I sent ok for you?

ullrich.hafner@gmail.com (JIRA)

unread,
Sep 2, 2019, 10:52:03 AM9/2/19
to jenkinsc...@googlegroups.com

Yes, thanks. I just arrived back from my holidays.

The report looks ok. Parsing of issues seems to work quite well. Just the workspace prefix does somehow not match with the path of the workspace. A simple fix would be to use lowercase on Windows. I still want to see if I can reproduce it in a test case...

david.aldrich@emea.nec.com (JIRA)

unread,
Sep 2, 2019, 11:19:01 AM9/2/19
to jenkinsc...@googlegroups.com

Thanks for looking into this.
Add Comment Add Comment
 

ullrich.hafner@gmail.com (JIRA)

unread,
Sep 5, 2019, 7:20:02 PM9/5/19
to jenkinsc...@googlegroups.com

Since I still can't reproduce it in a test: can you please upgrade to 6.0.0 and see if it still does not work?

david.aldrich@emea.nec.com (JIRA)

unread,
Sep 6, 2019, 5:07:04 AM9/6/19
to jenkinsc...@googlegroups.com
David Aldrich updated an issue
Change By: David Aldrich
Attachment: screenshot-1.png

david.aldrich@emea.nec.com (JIRA)

unread,
Sep 6, 2019, 5:08:03 AM9/6/19
to jenkinsc...@googlegroups.com
David Aldrich commented on Bug JENKINS-58824
 
Re: Warnings NG plugin skips files reported by MSBuild because they are lower case

The problem is fixed in 6.0.0 - the links to source code work correctly.

(In the slave I have

So I think we can close this issue. Thanks very much for your help.

david.aldrich@emea.nec.com (JIRA)

unread,
Sep 6, 2019, 5:08:03 AM9/6/19
to jenkinsc...@googlegroups.com
David Aldrich edited a comment on Bug JENKINS-58824
The problem is fixed in 6.0.0 - the links to source code work correctly.
( In the slave I have: )

!screenshot-1.png|thumbnail!

So I think we can close this issue. Thanks very much for your help.

ullrich.hafner@gmail.com (JIRA)

unread,
Sep 6, 2019, 6:48:02 AM9/6/19
to jenkinsc...@googlegroups.com

Ok, I remember that I changed something in the paths handling quite some weeks ago. Good to see that it helps for your problem as well.

ullrich.hafner@gmail.com (JIRA)

unread,
Sep 6, 2019, 6:48:03 AM9/6/19
to jenkinsc...@googlegroups.com
Ulli Hafner resolved as Fixed
 
Change By: Ulli Hafner
Status: In Progress Resolved
Resolution: Fixed
Released As: 6.0.0
Reply all
Reply to author
Forward
0 new messages