[JIRA] (JENKINS-39559) Job Config History Plugin saving config for a node other than the one being edited

2 views
Skip to first unread message

brian.hewson@cd-adapco.com (JIRA)

unread,
Nov 7, 2016, 10:11:02 AM11/7/16
to jenkinsc...@googlegroups.com
brian hewson created an issue
 
Jenkins / Bug JENKINS-39559
Job Config History Plugin saving config for a node other than the one being edited
Issue Type: Bug Bug
Assignee: Stefan Brausch
Components: jobconfighistory-plugin
Created: 2016/Nov/07 3:10 PM
Environment: Jenkins ver. 2.7.4
jobconfighistory-plugin 2.15
Labels: plugin slave configuration
Priority: Minor Minor
Reporter: brian hewson

Saving configuration changes on some agents* results in config-history being updated for a different node. IE making changes to labels for Agent A, press save, the config-history is updated for Agent B, with the current configuration from Agent B. The history.xml file shows that I was the user making the change to Agent B. If I make another change to Slave A and save, Agent C config-history is updated with current configuration from Agent C.

To be clear:

  1. Current agent config.xml files are not altered in any unintended way, only the config-history files
  2. When saving the agent configuration, the agent configuration that is actually saved is incrementing alphabetically.
  3. The above problem is happening on every save of the agents configuration. definite and repeatable

Further:
The above problem seems to be causing an undesired effect in leaving the agent in a disconnected state. However, this is not repeatable.
The workaround is to re-save the configuration. Which then resumes connectivity between agent and master.

* some in this case is 6 windows slaves (out of 246 mixed linux and windows slaves currently connected to master), the 6 agents aren't named sequentially and weren't connected to master at the same time

Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)
Atlassian logo

jnord@cloudbees.com (JIRA)

unread,
Mar 15, 2017, 9:47:02 AM3/15/17
to jenkinsc...@googlegroups.com
James Nord commented on Bug JENKINS-39559
 
Re: Job Config History Plugin saving config for a node other than the one being edited

\this has also shown to lead to deadlocks as serializing the xml for a node may take out some locks - so when serializing other nodes where the locks are not held you can get out of order locking and then deadlocks.

This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)
Atlassian logo

brian.hewson@cd-adapco.com (JIRA)

unread,
Jul 13, 2018, 9:48:02 AM7/13/18
to jenkinsc...@googlegroups.com
brian hewson updated an issue
 
Change By: brian hewson
Environment: Jenkins ver. 2.7.4 && jobconfighistory-plugin 2.15
Jenkins ver. 2.46.2 && jobconfighistory-plugin 2.16
Jenkins ver. 2.60.3 && jobconfighistory-plugin 2.18
Jenkins ver. 2.89.2 && jobconfighistory-plugin 2.18

Jenkins ver. 2.107.3 && jobconfighistory-plugin 2.18
This message was sent by Atlassian JIRA (v7.10.1#710002-sha1:6efc396)

robin.richard.schulz@gmail.com (JIRA)

unread,
Jan 10, 2020, 10:23:02 AM1/10/20
to jenkinsc...@googlegroups.com
Robin Schulz commented on Bug JENKINS-39559
 
Re: Job Config History Plugin saving config for a node other than the one being edited

The problem here is that ComputerListener's methods don't provide information on which node's config has changed. So every node's config is persisted. Having activated the option to not save duplicates, this should still only save the config of the node for which you changed something unless you haven't altered other config.xmls manually or in another way that has not triggered the Saveable listener.

This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)
Atlassian logo
Reply all
Reply to author
Forward
0 new messages