[JIRA] (JENKINS-60692) credential type icon not correctly reflected

credential type icon not correctly reflected

Issue Type:	Bug
Assignee:	Chris Kilding
Attachments:	Screenshot 2020-01-08 at 10.00.12.png
Components:	aws-secrets-manager-credentials-provider-plugin
Created:	2020-01-08 13:25
Priority:	Minor
Reporter:	Dominik Bartholdi

I created a username/password credentials with the following command:

 
                                                                aws secretsmanager create-secret --name 'DB_USER_XXXXX' --secret-string 'zzzzzz' --tags 'Key=jenkins:credentials:username,Value=uuuuu' --description 'dddddddd'   
                                                            

although this worked and the credentials also show up in jenkins, the credentials have the wrong type icon shown in the credentials list screen:

all four credentials shown in the above screenshot should have the same icon in the first position of each line - all should be of type "UserName with Password". Currently the ones from AWS Provider show a different icon with the tool tip "AWS Secrets Manager secret" (which in fact is the icon for "Secret text"). This is very irritating for a user.

This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)

chris+jenkins@chriskilding.com (JIRA)

unread,

Jan 9, 2020, 7:46:01 AM1/9/20

to jenkinsc...@googlegroups.com

Chris Kilding commented on

I'm intending to remove the multi-type credential object in PR #10, replacing it with different credential type classes that each implement just one credentials interface.

On initial inspection this seems to be fixing a lot of cosmetic problems like the formatting of names, bringing them in line with how credentials usually appear in the UI.

If you're interested and have the time, I encourage you to check out the git-plugin-username-password-bug branch, test it locally, and see if it is fixing the icon problem as well?

chris+jenkins@chriskilding.com (JIRA)

unread,

Jan 14, 2020, 10:18:06 AM1/14/20

to jenkinsc...@googlegroups.com

Chris Kilding commented on

Not to worry, I've since run the test and the icons are still all pegged to the one used for secret text.

That icon is actually the default icon if the custom credentials descriptor does not implement the method

 
                                                                public String getIconClassName() 
                                                            

The most obvious route to fix this is to copy and paste what the Jenkins default credential implementations return in their descriptors. E.g. "icon-credentials-userpass" for UsernamePasswordCredentialsImpl.

The problem is that I can't find the source of the icon class names they return: I presume a PNG with a matching name exists in some other part of the Jenkins codebase, but didn't find it. So while we could copy-paste the class names into this provider, we would get no warning if the names ever changed.

chris+jenkins@chriskilding.com (JIRA)

unread,

Jan 14, 2020, 10:19:09 AM1/14/20

to jenkinsc...@googlegroups.com

Chris Kilding edited a comment on

Not to worry, I've since run the test and the icons are still all pegged to the one used for secret text.

That icon is actually the default icon if the custom credentials descriptor does not implement the method

{code:java}
public String getIconClassName(){code}

The most obvious route to fix this is to copy and paste what the Jenkins default credential implementations return in their descriptors. E.g. "icon-credentials-userpass" for UsernamePasswordCredentialsImpl.

The problem is that I can't find the source of the icon class names they return: I presume a PNG with a matching name exists in some other part of the Jenkins codebase, but didn't find it. So while we could copy-paste the class names into this provider, we would get no warning if the names ever changed , or if we made a typo .

chris+jenkins@chriskilding.com (JIRA)

unread,

Jan 14, 2020, 10:41:15 AM1/14/20

to jenkinsc...@googlegroups.com

Chris Kilding commented on

I have requested that the icon names be made available as string constants in the credentials-plugin: JENKINS-60766

chris+jenkins@chriskilding.com (JIRA)

unread,

Jan 23, 2020, 6:51:02 AM1/23/20

to jenkinsc...@googlegroups.com

Chris Kilding started work on

Change By:	Chris Kilding
Status:	Open In Progress

chris+jenkins@chriskilding.com (JIRA)

unread,

Jan 23, 2020, 6:52:03 AM1/23/20

to jenkinsc...@googlegroups.com

Chris Kilding commented on

Started work in GitHub PR #19

chris+jenkins@chriskilding.com (JIRA)

unread,

Jan 24, 2020, 7:17:02 AM1/24/20

to jenkinsc...@googlegroups.com

Chris Kilding commented on