[JIRA] (JENKINS-57428) Duplicate warnings when using error-prone and java scan

reitzmichnicht@gmx.de (JIRA)

unread,

May 13, 2019, 8:18:03 AM5/13/19

to jenkinsc...@googlegroups.com

Michael Düsterhus created an issue

Jenkins /

JENKINS-57428

Duplicate warnings when using error-prone and java scan

Issue Type:	Bug
Assignee:	Ulli Hafner
Attachments:	2019-05-13 14_14_43- [Jenkins] - Vivaldi.png, 2019-05-13 14_16_36-[Jenkins] - Vivaldi.png
Components:	analysis-model
Created:	2019-05-13 12:17
Environment:	Version 5.0.1
Priority:	Minor
Reporter:	Michael Düsterhus

We use the following setup to scan for java and error-prone warnings:

 
                                                                 def javaIssues = scanForIssues(
                        blameDisabled: !blame,
                        sourceCodeEncoding: 'UTF-8',
                        tool: java(reportEncoding: 'UTF-8'))
                def errorproneIssues = scanForIssues(
                        blameDisabled: !blame,
                        sourceCodeEncoding: 'UTF-8',
                        tool: errorProne(reportEncoding: 'UTF-8'))
                publishIssues(
                        id: 'java-compiler',
                        name: 'Compiler',
                        ignoreFailedBuilds: false,
                        sourceCodeEncoding: 'UTF-8',
                        issues: [javaIssues, errorproneIssues],
                        qualityGates: [[threshold: 1, type: 'TOTAL', unstable: true]])
 
                                                            

For a build output like this it results in duplicate warnings count:

 
                                                                00:03:20.475  [WARNING] /home/jenkins/agent/workspace/xxx/src/test/java/foo/SettingsControllerIT.java:[139,57] [StringSplitter] String.split(String) has surprising behavior
00:03:20.475      (see https://errorprone.info/bugpattern/StringSplitter)
00:03:20.475    Did you mean 'for (String productFamStr : Splitter.on(',').split(productFamiliesStr)) {'?

See screenshot

Add Comment

This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

ullrich.hafner@gmail.com (JIRA)

unread,

May 13, 2019, 4:59:02 PM5/13/19

to jenkinsc...@googlegroups.com

Ulli Hafner commented on

JENKINS-57428

Re: Duplicate warnings when using error-prone and java scan

Yes, both parsers match the same warning line. Just error prone has some additional entries. I'm not sure what a good approach would be to eliminate these duplicates.

Add Comment

ullrich.hafner@gmail.com (JIRA)

unread,

May 13, 2019, 4:59:04 PM5/13/19

to jenkinsc...@googlegroups.com

Ulli Hafner updated an issue

Jenkins /

JENKINS-57428

Duplicate warnings when using error-prone and java scan

Change By:	Ulli Hafner
Issue Type:	Bug Improvement

Add Comment

reitzmichnicht@gmx.de (JIRA)

unread,

May 14, 2019, 3:33:02 AM5/14/19

to jenkinsc...@googlegroups.com

Michael Düsterhus commented on

JENKINS-57428

Re: Duplicate warnings when using error-prone and java scan

I would recommend to define priority for parsers and put all warnings with unique identifier like (File + Line) in a global HashMap. Then if a parser has already created a warnings entry for this location all subsequent parsers will ignore it.