[JIRA] (JENKINS-53732) Git plugin unit test is leaking into user's git config

josephp90@gmail.com (JIRA)

unread,

Sep 22, 2018, 8:22:03 AM9/22/18

to jenkinsc...@googlegroups.com

Joseph Petersen created an issue

Jenkins /

JENKINS-53732

Git plugin unit test is leaking into user's git config

Issue Type:	Task
Assignee:	Mark Waite
Components:	git-plugin
Created:	2018-09-22 12:21
Priority:	Blocker
Reporter:	Joseph Petersen

I have had several times where I noticed my user.email and user.name was changed in my git config.

 
                                                                [include]
	path = .gitconfig.local
[user]
	name = Name From Git-Plugin-Test
	email = email.from.gi...@example.com
 
                                                            

Because I use a include of local git global config.

Finally figured out it was git-plugin unit tests messing with my config.

Is there are way we can ban the test or fix this for all versions since this test was included.

Add Comment

This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

josephp90@gmail.com (JIRA)

unread,

Sep 22, 2018, 8:24:02 AM9/22/18

to jenkinsc...@googlegroups.com

Joseph Petersen updated an issue

Jenkins /

JENKINS-53732

Git plugin unit test is leaking into user's git config

Change By:	Joseph Petersen

I have had several times where I noticed my user.email and user.name was changed in my git config.

This is the culprit: [ https://github.com/jenkinsci/git-plugin/blob/70634f15702157af3a5b7f49e953882c45e438df/src/test/java/jenkins/plugins/git/CliGitCommand.java#L137-L149 ]

{code:java}

[include]
path = .gitconfig.local
[user]
name = Name From Git-Plugin-Test
email = email.from.gi...@example.com

{code}

Because I use a include of local git global config.

Finally figured out it was git-plugin unit tests messing with my config.

Is there are way we can ban the test or fix this for all versions since this test was included.

Happens for instance when you run unit test for Bitbucket branch source plugin...