[JIRA] (JENKINS-60552) Fail to call a script method stored as a class attribute/field

[dicomj23@gmail.com (JIRA)]

Dicom J created an issue

Jenkins / JENKINS-60552 Fail to call a script method stored as a class attribute/field Issue Type: Bug Assignee: Andrew Bayer Components: groovy-plugin, workflow-cps-plugin Created: 2019-12-20 09:54 Priority: Blocker Reporter: Dicom J Similar case to  https://wiki.jenkins.io/display/JENKINS/Pipeline+CPS+method+mismatches#PipelineCPSmethodmismatches-Directinvocationofclosuresstoredinobjectfieldsormaps But instead of Closure, but this time the method from loaded script is called, what could be simulated right now even in a single Jenkins file. def scriptMethod() {     println 'passed' } class Test {   def fn } node {     def object = new Test()     object.fn = this.&scriptMethod     object.fn.call() } Got an exception: java.lang.IllegalStateException: expected to call org.codehaus.groovy.runtime.MethodClosure.call but wound up catching WorkflowScript.scriptMethod; see: https://jenkins.io/redirect/pipe line-cps-method-mismatches/ at org.jenkinsci.plugins.workflow.cps.CpsVmExecutorService.handleMismatch(CpsVmExecutorService.java:123) at com.cloudbees.groovy.cps.impl.CpsCallableInvocation.checkMismatch(CpsCallableInvocation.java:98) btw, Closure case works fine now. But this is critical as it doesn't allow to break a single Jenkinsfile into a couple of smaller modules (scripts). Add Comment

This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)

[dicomj23@gmail.com (JIRA)]

Dicom J updated an issue

Jenkins / JENKINS-60552 Fail to call a script method stored as a class attribute/field

Change By: Dicom J

Similar case to  [https://wiki.jenkins.io/display/JENKINS/Pipeline+CPS+method+mismatches#PipelineCPSmethodmismatches-Directinvocationofclosuresstoredinobjectfieldsormaps] But instead of Closure, but

this time the method from loaded script is called, what could be simulated right now even in a single Jenkins file. {code:java}

def scriptMethod() {     println 'passed' } class Test {   def fn } node {     def object = new Test()     object.fn = this.&scriptMethod     object.fn.call()

} {code} Got an exception: {code:java}

java.lang.IllegalStateException: expected to call org.codehaus.groovy.runtime.MethodClosure.call but wound up catching WorkflowScript.scriptMethod; see: https://jenkins.io/redirect/pipe line-cps-method-mismatches/

at org.jenkinsci.plugins.workflow.cps.CpsVmExecutorService.handleMismatch(CpsVmExecutorService.java:123) at com.cloudbees.groovy.cps.impl.CpsCallableInvocation.checkMismatch(CpsCallableInvocation.java:98)  {code}

btw, Closure case works fine now. But this is critical as it doesn't allow to break a single Jenkinsfile into a couple of smaller modules (scripts).

Add Comment

[dicomj23@gmail.com (JIRA)]

Dicom J commented on JENKINS-60552

Re: Fail to call a script method stored as a class attribute/field cc: Jesse Glick

Add Comment

[dicomj23@gmail.com (JIRA)]

Dicom J commented on JENKINS-60552

Re: Fail to call a script method stored as a class attribute/field

same as https://issues.jenkins-ci.org/browse/JENKINS-58407

Add Comment

[jglick@cloudbees.com (JIRA)]

Jesse Glick assigned an issue to Unassigned

Jenkins / JENKINS-60552

Fail to call a script method stored as a class attribute/field

Change By: Jesse Glick Assignee: Andrew Bayer

Add Comment

[jglick@cloudbees.com (JIRA)]

Jesse Glick updated an issue

Jenkins / JENKINS-60552 Fail to call a script method stored as a class attribute/field

Change By: Jesse Glick Component/s: groovy-plugin

Add Comment

[jglick@cloudbees.com (JIRA)]

Jesse Glick commented on JENKINS-60552

Re: Fail to call a script method stored as a class attribute/field Would only be a warning, but I suppose you are using JFR in which case it is an error due to JENKINS-55764. Workaround (untested): just avoid method references or other Groovy exotica: object.fn = {-> scriptMethod()}

Add Comment

[dicomj23@gmail.com (JIRA)]

Dicom J commented on JENKINS-60552

Re: Fail to call a script method stored as a class attribute/field

Thanks Jesse Glick, I really appreciate your replies! Yes, workaround would work. Regarding JFR - here, you're right as well. Actually we use both, JFR to develop pipelines locally and Jenkins run production mode. So we try to keep codebase same for JFR and regular Jenkins, IOW we try to avoid "if (JFR)" statements.

Add Comment