[JIRA] (JENKINS-56152) Improve dependency errors message

2 views
Skip to first unread message

jsoref+jenkins@gmail.com (JIRA)

unread,
Feb 14, 2019, 7:05:02 PM2/14/19
to jenkinsc...@googlegroups.com
Josh Soref created an issue
 
Jenkins / Bug JENKINS-56152
Improve dependency errors message
Issue Type: Bug Bug
Assignee: Unassigned
Attachments: image-2019-02-14-18-59-51-856.png
Components: core
Created: 2019-02-15 00:04
Priority: Minor Minor
Reporter: Josh Soref

I intentionally deleted the mailer plugin (the reasons are immaterial)

Dependency errors:

Some plugins could not be loaded due to unsatisfied dependencies. Fix these issues and restart Jenkins to restore the functionality provided by these plugins.

Lockable Resources plugin version 2.4mailer version 1.5 is missing. To fix, install version 1.5 or later.Pipeline: Basic Steps version 2.14mailer version 1.18 is missing. To fix, install version 1.18 or later.

Downstream dependency errors:

These plugins failed to load because of one or more of the errors above. Fix those and these plugins will load again.

Docker Pipeline version 1.17Pipeline: Basic Steps version 2.14 failed to load. Fix this plugin first.Hubot Pipeline Steps version 2.0.3Pipeline version 2.6 failed to load. Fix this plugin first.Pipeline version 2.6Lockable Resources plugin version 2.4 failed to load. Fix this plugin first.Pipeline: Declarative version 1.3.4.1Pipeline: Basic Steps version 2.14 failed to load. Fix this plugin first.

The layout of this is more or less:

  1. Heading:
  2. Descriptive message which is not actually covered by heading, but merely explains the heading
  3. Actual items related to heading.

I think the basic fix is changing the order to roughly:

  1. Descriptive message
  2. Heading:
  3. Actual items

Beyond the most basic:

  • The use of bold is really unhelpful.
    • Plugin names should be consistently styled in all 4 sections
    • The version field should not be styled in the same way.
  • I don't think that "Fix this plugin first" adds any value.
  • I don't think that the label "Downstream dependency errors" is particularly helpful – a label is needed, but it should be something else.

Note:

Below this blob is:

New version of Jenkins (2.164) is available for download (changelog).

The version formatting style here is better than the one used above.

 
Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

jsoref+jenkins@gmail.com (JIRA)

unread,
Feb 14, 2019, 7:10:51 PM2/14/19
to jenkinsc...@googlegroups.com
Josh Soref updated an issue
Change By: Josh Soref
I intentionally deleted the mailer plugin (the reasons are immaterial)
{quote}*Dependency errors:*


Some plugins could not be loaded due to unsatisfied dependencies. Fix these issues and restart Jenkins to restore the functionality provided by these plugins.

Lockable Resources plugin version 2.4mailer version 1.5 is missing. To fix, install version 1.5 or later.Pipeline: Basic Steps version 2.14mailer version 1.18 is missing. To fix, install version 1.18 or later.

*Downstream dependency errors:*


These plugins failed to load because of one or more of the errors above. Fix those and these plugins will load again.

Docker Pipeline version 1.17Pipeline: Basic Steps version 2.14 failed to load. Fix this plugin first.Hubot Pipeline Steps version 2.0.3Pipeline version 2.6 failed to load. Fix this plugin first.Pipeline version 2.6Lockable Resources plugin version 2.4 failed to load. Fix this plugin first.Pipeline: Declarative version 1.3.4.1Pipeline: Basic Steps version 2.14 failed to load. Fix this plugin first.
{quote}
!image-2019-02-14-18-59-51-856.png!

 Perhaps, most importantly, the {{Correct}} button doesn't do what one would expect. – It takes one to {{/pluginManager/}} which is:
# The wrong screen
## It should be {{/pluginManager/available}}
## This should be done.
# The relevant plugins aren't selected
# The simplest fix would be to change the button label from {{Correct}} to {{Manage}} 
# The better fix would be to preselect the missing plugins.

The layout of this is more or less:
# Heading:
# Descriptive message which is not actually covered by heading, but merely explains the heading
# Actual items related to heading.


I think the basic fix is changing the order to roughly:
# Descriptive message
# Heading:
# Actual items

Beyond the most basic:
* The use of bold is really unhelpful.
** Plugin names should be consistently styled in all 4 sections
** The version field should not be styled in the same way.
* I don't think that "Fix this plugin first" adds any value.
* I don't think that the label "Downstream dependency errors" is particularly helpful – a label is needed, but it should be something else.


Note:

Below this blob is:
{quote}New version of Jenkins (2.164) is available for [download|http://updates.jenkins-ci.org/download/war/2.164/jenkins.war] ([changelog|https://jenkins.io/changelog]).
{quote}

The version formatting style here is better than the one used above.

 

jsoref+jenkins@gmail.com (JIRA)

unread,
Feb 14, 2019, 7:11:02 PM2/14/19
to jenkinsc...@googlegroups.com

jsoref+jenkins@gmail.com (JIRA)

unread,
Feb 14, 2019, 7:12:02 PM2/14/19
to jenkinsc...@googlegroups.com
Josh Soref updated an issue
I intentionally deleted the mailer plugin (the reasons are immaterial)
{quote}*Dependency errors:*

Some plugins could not be loaded due to unsatisfied dependencies. Fix these issues and restart Jenkins to restore the functionality provided by these plugins.

Lockable Resources plugin version 2. 4mailer 4

    mailer version 1.5 is missing. To fix, install version 1.5 or later.

Pipeline: Basic Steps version 2. 14mailer 14

    mailer version 1.18 is missing. To fix, install version 1.18 or later.


*Downstream dependency errors:*

These plugins failed to load because of one or more of the errors above. Fix those and these plugins will load again.

Docker Pipeline version 1. 17Pipeline 17

    Pipeline : Basic Steps version 2.14 failed to load. Fix this plugin first.

Hubot Pipeline Steps version 2.0. 3Pipeline 3

    Pipeline version 2.6 failed to load. Fix this plugin first.

Pipeline version 2. 6Lockable 6

    Lockable Resources plugin version 2.4 failed to load. Fix this plugin first.

Pipeline: Declarative version 1.3.4. 1Pipeline 1

    Pipeline : Basic Steps version 2.14 failed to load. Fix this plugin first.

{quote}
!image-2019-02-14-18-59-51-856.png!

Perhaps, most importantly, the {{Correct}} button doesn't do what one would expect. – It takes one to {{/pluginManager/}} which is:
# The wrong screen
## It should be {{/pluginManager/available}}
## This should be done.
# The relevant plugins aren't selected
# The simplest fix would be to change the button label from {{Correct}} to {{Manage}} 
# The better fix would be to preselect the missing plugins.
# After installing the plugin (which doesn't require a restart), the dependencies aren't recalculated.

The layout of this is more or less:
# Heading:
# Descriptive message which is not actually covered by heading, but merely explains the heading
# Actual items related to heading.

I think the basic fix is changing the order to roughly:
# Descriptive message
# Heading:
# Actual items

Beyond the most basic:
* The use of bold is really unhelpful.
** Plugin names should be consistently styled in all 4 sections
** The version field should not be styled in the same way.
* I don't think that "Fix this plugin first" adds any value.
* I don't think that the label "Downstream dependency errors" is particularly helpful – a label is needed, but it should be something else.

Note:

Below this blob is:
{quote}New version of Jenkins (2.164) is available for [download|http://updates.jenkins-ci.org/download/war/2.164/jenkins.war] ([changelog|https://jenkins.io/changelog]).
{quote}
The version formatting style here is better than the one used above.

 

jsoref+jenkins@gmail.com (JIRA)

unread,
Feb 17, 2019, 11:47:02 PM2/17/19
to jenkinsc...@googlegroups.com

jsoref+jenkins@gmail.com (JIRA)

unread,
Feb 17, 2019, 11:47:02 PM2/17/19
to jenkinsc...@googlegroups.com
Josh Soref assigned an issue to Josh Soref
Change By: Josh Soref
Assignee: Josh Soref

jsoref+jenkins@gmail.com (JIRA)

unread,
Feb 17, 2019, 11:48:01 PM2/17/19
to jenkinsc...@googlegroups.com
Josh Soref started work on Bug JENKINS-56152
 
Change By: Josh Soref
Status: Open In Progress

jsoref+jenkins@gmail.com (JIRA)

unread,
Feb 18, 2019, 9:26:01 PM2/18/19
to jenkinsc...@googlegroups.com

This is w/ my updated message, but I want to discuss an edge:

Some plugins could not be loaded due to unsatisfied dependencies. Fix these issues and restart Jenkins to reenable these plugins.

Dependency errors:
Pipeline (2.6)
  Disabled: Pipeline: Shared Groovy Libraries
  ...
  Disabled: Pipeline: Basic Steps
...

Some of the above failures also result in additional indirectly dependent plugins not being able to load.

Indirectly dependent plugins:
...
Pipeline (2.6)
  Failed to load: Pipeline: Nodes and Processes (2.29)

If Pipeline has top level dependency errors, is it really useful to list indirect dependency errors as well?

Personally, I think I'd rather fold dependencies into the main list as just a single line item:
{{Dependent:

{name}

}}.

I'm open to suggestions. I might not make this change in this bug/pr series.

jsoref+jenkins@gmail.com (JIRA)

unread,
Feb 18, 2019, 9:27:01 PM2/18/19
to jenkinsc...@googlegroups.com
Josh Soref edited a comment on Bug JENKINS-56152

o.v.nenashev@gmail.com (JIRA)

unread,
Jan 15, 2020, 7:11:06 AM1/15/20
to jenkinsc...@googlegroups.com
Oleg Nenashev resolved as Fixed
Change By: Oleg Nenashev
Status: In Progress Resolved
Resolution: Fixed
Released As: Jenkins 2.214
This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)
Atlassian logo
Reply all
Reply to author
Forward
0 new messages