[JIRA] (JENKINS-36794) Fine tuning: Jenkins startup script

3 views
Skip to first unread message

omazilov@gmail.com (JIRA)

unread,
Jul 19, 2016, 7:43:02 AM7/19/16
to jenkinsc...@googlegroups.com
Oleksii Mazilov created an issue
 
Jenkins / Improvement JENKINS-36794
Fine tuning: Jenkins startup script
Issue Type: Improvement Improvement
Assignee: Unassigned
Components: other
Created: 2016/Jul/19 11:42 AM
Environment: version: latest stable
Priority: Minor Minor
Reporter: Oleksii Mazilov

File: /etc/init.d/jenkins
Line: 165

for n in 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20; do
    sleep 1
    $DAEMON $DAEMON_ARGS --running || break
done

It's better to use seq instead of list of numbers

for n in $(1 20); do
    sleep 1
    $DAEMON $DAEMON_ARGS --running || break
done
Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)
Atlassian logo

dbeck@cloudbees.com (JIRA)

unread,
Jul 19, 2016, 12:26:01 PM7/19/16
to jenkinsc...@googlegroups.com
Daniel Beck commented on Improvement JENKINS-36794
 
Re: Fine tuning: Jenkins startup script

An explicit list is less error prone, as your sample code demonstrates. No seq to be found anywhere.

slide.o.mix@gmail.com (JIRA)

unread,
Jul 17, 2019, 9:30:03 AM7/17/19
to jenkinsc...@googlegroups.com
Alex Earl closed an issue as Won't Do
 
Change By: Alex Earl
Status: Open Closed
Resolution: Won't Do
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)
Reply all
Reply to author
Forward
0 new messages