[JIRA] (JENKINS-51495) descriptorRadioList does not honor DescriptorVisibilityFilter

14 views
Skip to first unread message

amuniz@cloudbees.com (JIRA)

unread,
May 23, 2018, 4:13:01 AM5/23/18
to jenkinsc...@googlegroups.com
Antonio Muñiz created an issue
 
Jenkins / Bug JENKINS-51495
descriptorRadioList does not honor DescriptorVisibilityFilter
Issue Type: Bug Bug
Assignee: Unassigned
Components: core
Created: 2018-05-23 08:12
Priority: Major Major
Reporter: Antonio Muñiz

descriptorRadioList does not honor DescriptorVisibilityFilter extensions.

The workaround for this has been to pass an already filtered list of descriptors to descriptorRadioList (ie here):

f.descriptorRadioList([...], descriptors: h.filterDescriptors(app, MyExtensionPoint.all()))

However this has a side effect as descriptorRadioList is using an index to match frontend selected descriptor with a backend instance, so when a descriptor is hidden (by the visibility filter) in the frontend then backend indexes do not match.

So, I believe descriptorRadioList should be fixed to either a) Generate correct indexes when there a visibility filter or b) stop using indexes to match things (which seems quite awkward).
Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)
Atlassian logo

o.v.nenashev@gmail.com (JIRA)

unread,
May 26, 2018, 10:49:03 AM5/26/18
to jenkinsc...@googlegroups.com
Oleg Nenashev updated an issue
Change By: Oleg Nenashev
Labels: newbie-friendly

msmswwwww@gmail.com (JIRA)

unread,
Apr 7, 2019, 12:36:03 AM4/7/19
to jenkinsc...@googlegroups.com
Sho Matsumoto assigned an issue to Sho Matsumoto
Change By: Sho Matsumoto
Assignee: Sho Matsumoto
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

msmswwwww@gmail.com (JIRA)

unread,
Apr 7, 2019, 1:08:02 AM4/7/19
to jenkinsc...@googlegroups.com

> So, I believe descriptorRadioList should be fixed to either a) Generate correct indexes when there a visibility filter or b) stop using indexes to match things (which seems quite awkward).

I followed b) plan and stop using indexes and begin using id instead.

bmathus+ossjira@cloudbees.com (JIRA)

unread,
Apr 7, 2019, 8:18:02 AM4/7/19
to jenkinsc...@googlegroups.com
Baptiste Mathus started work on Bug JENKINS-51495
 
Change By: Baptiste Mathus
Status: Open In Progress

o.v.nenashev@gmail.com (JIRA)

unread,
Mar 9, 2020, 9:02:04 AM3/9/20
to jenkinsc...@googlegroups.com
Oleg Nenashev resolved as Fixed
 

I am not sure it should be ported to LTS, definitely not to 2.222.1 taking the merge date
Change By: Oleg Nenashev
Status: In Progress Resolved
Resolution: Fixed
Released As: Jenkins 2.224
This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)
Atlassian logo

o.v.nenashev@gmail.com (JIRA)

unread,
Mar 9, 2020, 9:03:06 AM3/9/20
to jenkinsc...@googlegroups.com
Oleg Nenashev updated an issue
Change By: Oleg Nenashev
Labels: 2.222.1-rejected lts-candidate newbie-friendly

timjacomb1@gmail.com (JIRA)

unread,
Mar 9, 2020, 12:44:04 PM3/9/20
to jenkinsc...@googlegroups.com
Tim Jacomb updated an issue
Change By: Tim Jacomb
Labels: 2.222.1-rejected lts-candidate newbie-friendly regression

timjacomb1@gmail.com (JIRA)

unread,
Mar 9, 2020, 12:45:02 PM3/9/20
to jenkinsc...@googlegroups.com

timjacomb1@gmail.com (JIRA)

unread,
Mar 9, 2020, 1:23:03 PM3/9/20
to jenkinsc...@googlegroups.com
Tim Jacomb updated an issue
Change By: Tim Jacomb
Labels: 2.222.1-rejected lts-candidate newbie-friendly regression

o.v.nenashev@gmail.com (JIRA)

unread,
Mar 10, 2020, 6:20:03 AM3/10/20
to jenkinsc...@googlegroups.com
Change By: Oleg Nenashev
Status: Resolved Fixed but Unreleased

o.v.nenashev@gmail.com (JIRA)

unread,
Mar 10, 2020, 6:21:02 AM3/10/20
to jenkinsc...@googlegroups.com
Oleg Nenashev commented on Bug JENKINS-51495
 
Re: descriptorRadioList does not honor DescriptorVisibilityFilter

We rolled back the fix in 2.225 to fix the regression.

https://github.com/jenkinsci/jenkins/pull/4562 was created for a new implementation

o.v.nenashev@gmail.com (JIRA)

unread,
Mar 10, 2020, 6:21:04 AM3/10/20
to jenkinsc...@googlegroups.com
Oleg Nenashev assigned an issue to Oleg Nenashev
 
Change By: Oleg Nenashev
Assignee: Sho Matsumoto Oleg Nenashev

ogondza@gmail.com (JIRA)

unread,
Mar 11, 2020, 7:58:03 AM3/11/20
to jenkinsc...@googlegroups.com
Change By: Oliver Gondža
Resolution: Fixed
Status: Fixed but Unreleased Reopened

ogondza@gmail.com (JIRA)

unread,
Mar 11, 2020, 7:59:03 AM3/11/20
to jenkinsc...@googlegroups.com

dbeck@cloudbees.com (JIRA)

unread,
Mar 13, 2020, 3:45:03 PM3/13/20
to jenkinsc...@googlegroups.com
Daniel Beck updated an issue
 
Change By: Daniel Beck
Released As: Jenkins 2.224 (reverted in 2.225)
Reply all
Reply to author
Forward
0 new messages