[JIRA] (JENKINS-57901) Concurrent Pipeline builds report all changes since last completed build

21 views
Skip to first unread message

williambrode@gmail.com (JIRA)

unread,
Jun 6, 2019, 8:22:02 PM6/6/19
to jenkinsc...@googlegroups.com
William Brode created an issue
 
Jenkins / Bug JENKINS-57901
Concurrent Pipeline builds report all changes since last completed build
Issue Type: Bug Bug
Assignee: Unassigned
Components: p4-plugin
Created: 2019-06-07 00:21
Environment: Jenkins ver. 2.164.3
p4-plugin 1.9.6
Priority: Minor Minor
Reporter: William Brode

When running two concurrent pipeline builds, the second one will contain the changes from the first (so long as the first hasn't finished running when the second pipeline starts).

 

CL 1 starts a build

CL 2 starts a build

 

Then Build #2 will contain CL 1 and CL 2 even though it is really only "newly" building CL 2.

 

This causes issues for reporting (e-mails, jenkins ui, ect) since it makes it look like CL 1 was first introduced in Build #2 when it was really introduced in Build #1.

Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

kwirth@perforce.com (JIRA)

unread,
Jun 7, 2019, 3:32:02 AM6/7/19
to jenkinsc...@googlegroups.com
Karl Wirth commented on Bug JENKINS-57901
 
Re: Concurrent Pipeline builds report all changes since last completed build

Hi William Brode - Thanks for highlighting this.

To help me test this, do the concurrent jobs have unique workspace names?For example are you including 'EXECUTOR_NUMBER' in the workspace name and can you see in the job output that a different workspace is used in each? Also are both jobs running on the same slave node or in a unique node (such as a docker container)?

kwirth@perforce.com (JIRA)

unread,
Jun 7, 2019, 3:32:02 AM6/7/19
to jenkinsc...@googlegroups.com

kwirth@perforce.com (JIRA)

unread,
Jun 20, 2019, 8:59:02 AM6/20/19
to jenkinsc...@googlegroups.com
Karl Wirth updated an issue
Change By: Karl Wirth
Attachment: image-2019-06-20-13-58-08-830.png

kwirth@perforce.com (JIRA)

unread,
Jun 20, 2019, 9:00:03 AM6/20/19
to jenkinsc...@googlegroups.com
Karl Wirth updated an issue
Change By: Karl Wirth
Attachment: image-2019-06-20-13-59-00-618.png

kwirth@perforce.com (JIRA)

unread,
Jun 20, 2019, 9:26:02 AM6/20/19
to jenkinsc...@googlegroups.com
 
Re: Concurrent Pipeline builds report all changes since last completed build

Hi William Brode, I have tested this here on P4-Plugin1.10.0 and can see that my workspace contains the correct files for each job but the reporting shows both changes-lists. For example:

First job...

Second job...

I'm assuming this is the behavior you saw. If not please let me know.

 

Reproduction Steps:

1 - Create a Jenkinsfile containing a 60 second sleep:

pipeline {
  agent { label 'master' }
  stages {
    stage("Repro") {
      steps {
        script {
           echo "Starting job."           

           echo "This shows that the slave contains the correct files with an implicit sync."
           sh 'ls -l'           echo "Sleep for 60 seconds to allow overlap"
	   sleep 60
        }
      }
    }
  }
}

2 - Add Jenkinsfile and test.txt file to the depot

3 - Create a pipeline job that uses the jenkinsfile.

4 - Run build once to create baseline.

5 - Edit and submit test.txt

6 - Run build.

7 - Wait 10 seconds then quickly edit and submit test.txt. For example:

p4 edit test.txt && echo test >> test.txtx && p4 submit -d "Edited test.txt"

8 - Manually run build again (must be within 40 seconds of the build started in step 6).

Outcome :

Build 2 will report changelist 2.

Build 3 will report changelist 2 and 3.

Expected:

Build 2 will report changelist 2.

Build 3 will report changelist 3.

Note - This is not the same as poll per change. If two edits had been made Build 3 should report changelists 3 and 4.

 

 

 

kwirth@perforce.com (JIRA)

unread,
Jun 20, 2019, 9:27:03 AM6/20/19
to jenkinsc...@googlegroups.com

kwirth@perforce.com (JIRA)

unread,
Jun 20, 2019, 9:27:03 AM6/20/19
to jenkinsc...@googlegroups.com

pallen@perforce.com (JIRA)

unread,
Jun 20, 2019, 9:36:02 AM6/20/19
to jenkinsc...@googlegroups.com

kwilliamson@perforce.com (JIRA)

unread,
Jun 28, 2019, 10:01:04 AM6/28/19
to jenkinsc...@googlegroups.com

kwilliamson@perforce.com (JIRA)

unread,
Jun 28, 2019, 10:17:03 AM6/28/19
to jenkinsc...@googlegroups.com
Kevin Williamson started work on Bug JENKINS-57901
 
Change By: Kevin Williamson
Status: Open In Progress

kwilliamson@perforce.com (JIRA)

unread,
Jun 28, 2019, 10:31:02 AM6/28/19
to jenkinsc...@googlegroups.com

kwilliamson@perforce.com (JIRA)

unread,
Jul 2, 2019, 5:28:06 AM7/2/19
to jenkinsc...@googlegroups.com

kwilliamson@perforce.com (JIRA)

unread,
Jul 2, 2019, 5:29:03 AM7/2/19
to jenkinsc...@googlegroups.com

kwilliamson@perforce.com (JIRA)

unread,
Jul 2, 2019, 5:29:03 AM7/2/19
to jenkinsc...@googlegroups.com
Reply all
Reply to author
Forward
0 new messages