[JIRA] (JENKINS-49980) Whitelist standard Kotlin classes to ensure compatibility with JEP-200 in 2.102+

1 view
Skip to first unread message

o.v.nenashev@gmail.com (JIRA)

unread,
Mar 7, 2018, 6:05:02 AM3/7/18
to jenkinsc...@googlegroups.com
Oleg Nenashev updated an issue
 
Jenkins / Improvement JENKINS-49980
Whitelist standard Kotlin classes to ensure compatibility with JEP-200 in 2.102+
Change By: Oleg Nenashev
Labels: JEP-200
Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)
Atlassian logo

o.v.nenashev@gmail.com (JIRA)

unread,
Mar 7, 2018, 6:05:03 AM3/7/18
to jenkinsc...@googlegroups.com
Oleg Nenashev created an issue
Issue Type: Improvement Improvement
Assignee: Joseph Petersen
Components: kotlin-v1-stdlib-jdk8-plugin
Created: 2018-03-07 11:04
Priority: Minor Minor
Reporter: Oleg Nenashev

It is a follow-up to the discussion in HOSTING-492 with Joseph Petersen . The plugin does not whitelist base classes, and it's high risk of regressions in API user plugins. E.g. see JENKINS-49699

> What to serialize? It is a complicated topic. Jenkins 2.102+ will reject serialization of classes over Remoting and XStream, so the rule would be the following:

  • Every class plugin developers persist on the disk
  • Every class plugin developers send over the channel to agents

> I would say that the most of the classes should be whitelisted by plugin developers, but the library could whitelist Kotlin base classes (like kotlin.collections.EmptyList in JENKINS-49699). You can find examples of whitelisted base classes for Java here: https://github.com/jenkinsci/jenkins/blob/master/core/src/main/resources/jenkins/security/whitelisted-classes.txt

o.v.nenashev@gmail.com (JIRA)

unread,
Apr 13, 2018, 5:30:02 AM4/13/18
to jenkinsc...@googlegroups.com
Oleg Nenashev commented on Improvement JENKINS-49980
 
Re: Whitelist standard Kotlin classes to ensure compatibility with JEP-200 in 2.102+

Joseph Petersen IIUC the discussion in JENKINS-49699, you have already done some whitelisting prototyping, right?
Do you think it makes sense to close this ticket?

josephp90@gmail.com (JIRA)

unread,
Apr 15, 2018, 2:46:02 AM4/15/18
to jenkinsc...@googlegroups.com
Joseph Petersen resolved as Fixed
 

Yup, closing

Change By: Joseph Petersen
Status: Open Resolved
Resolution: Fixed

josephp90@gmail.com (JIRA)

unread,
Mar 7, 2020, 1:08:28 AM3/7/20
to jenkinsc...@googlegroups.com
Joseph Petersen assigned an issue to Joseph Petersen
Change By: Joseph Petersen
Assignee: Joseph Petersen (old)
This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)
Atlassian logo
Reply all
Reply to author
Forward
0 new messages