[JIRA] [accurev-plugin] (JENKINS-33103) AccuRev Stream color is reset without a clear purpose

2 views
Skip to first unread message

arno@90a.nl (JIRA)

unread,
Feb 23, 2016, 8:57:01 AM2/23/16
to jenkinsc...@googlegroups.com
Arno Moonen created an issue
 
Jenkins / Bug JENKINS-33103
AccuRev Stream color is reset without a clear purpose
Issue Type: Bug Bug
Assignee: Scott Tatum
Components: accurev-plugin
Created: 23/Feb/16 1:56 PM
Labels: accurev
Priority: Minor Minor
Reporter: Arno Moonen

Currently the AccuRev Jenkins CI plug-in always resets the color of the stream.
This is not something we requested, nor something we can disable.
This is unwanted behavior.
I would like to see an option to disable this.

If I look at hudson.plugins.accurev.delegates.AbstractModeDelegate it seems that this is only called in checkout( ... ).
I do not really know why this is done in the first place.
In my opinion it does not add anything and it can be removed.
It would only start to make sense if the plug-in also has the option the change the color when the build fails, but I did not find this in the code.

Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265)
Atlassian logo

josephp90@gmail.com (JIRA)

unread,
Sep 14, 2016, 5:29:01 AM9/14/16
to jenkinsc...@googlegroups.com
Joseph Petersen assigned an issue to Joseph Petersen
Change By: Joseph Petersen
Assignee: Scott Tatum Joseph Petersen
This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)
Atlassian logo

josephp90@gmail.com (JIRA)

unread,
Sep 14, 2016, 5:32:01 AM9/14/16
to jenkinsc...@googlegroups.com
Joseph Petersen commented on Bug JENKINS-33103
 
Re: AccuRev Stream color is reset without a clear purpose

This option, should it be global for the accurev server or for each job?

I do believe the option should start out as false, that way users would have to enable it.

arno@90a.nl (JIRA)

unread,
Sep 14, 2016, 10:04:01 PM9/14/16
to jenkinsc...@googlegroups.com

I think the answer is both.
So on a global level you probably want to set the default and on a job level you'd probably want to override it.

But still, resetting the color does not make sense to me, if you do not provide a way to set the color based on the result of the build for example.

The client I'm currently working for that uses AccuRev has its own coloring scheme to indicate how a stream should be used (what its purpose is).

scm_issue_link@java.net (JIRA)

unread,
Sep 15, 2016, 11:56:03 AM9/15/16
to jenkinsc...@googlegroups.com

Code changed in jenkins
User: Joseph
Path:
.gitignore
src/main/java/hudson/plugins/accurev/AccurevLauncher.java
src/main/java/hudson/plugins/accurev/AccurevSCM.java
src/main/java/hudson/plugins/accurev/DetermineRemoteHostname.java
src/main/java/hudson/plugins/accurev/cmd/ChangeLogCmd.java
src/main/java/hudson/plugins/accurev/cmd/PopulateCmd.java
src/main/java/hudson/plugins/accurev/cmd/Update.java
src/main/java/hudson/plugins/accurev/delegates/AbstractModeDelegate.java
src/main/java/hudson/plugins/accurev/parsers/xml/ParseHistory.java
src/main/resources/hudson/plugins/accurev/AccurevSCM/global.jelly
src/main/webapp/help/use-color.html
http://jenkins-ci.org/commit/accurev-plugin/54cb79967006982752154c27f49e435154d85e9b
Log:
NullPointer fixes. better hostname handling. Toggle streamColor. (#27)

  • ignore .DS_Store file

Cannot prevent bad DNS/Hostname config.

cannot prevent bad DNS/Hostname.

  • [JENKINS-33103, JENKINS-38148] added toggle for color reset.

josephp90@gmail.com (JIRA)

unread,
Sep 22, 2016, 11:02:03 AM9/22/16
to jenkinsc...@googlegroups.com
Joseph Petersen resolved as Fixed
 

Marked as fixed, because you can now disable the color reset.

Change By: Joseph Petersen
Status: Open Resolved
Resolution: Fixed

josephp90@gmail.com (JIRA)

unread,
Mar 7, 2020, 1:08:28 AM3/7/20
to jenkinsc...@googlegroups.com
Joseph Petersen assigned an issue to Joseph Petersen
Change By: Joseph Petersen
Assignee: Joseph Petersen (old)
This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)
Atlassian logo
Reply all
Reply to author
Forward
0 new messages