[JIRA] (JENKINS-53462) Jenkins websites use non-trusted 'submit' event to start form submission when current browser is Firefox

5 views
Skip to first unread message

dbeck@cloudbees.com (JIRA)

unread,
Sep 7, 2018, 6:28:02 AM9/7/18
to jenkinsc...@googlegroups.com
Daniel Beck moved an issue
 
Jenkins / Bug JENKINS-53462
Jenkins websites use non-trusted 'submit' event to start form submission when current browser is Firefox
Change By: Daniel Beck
Project: Jenkins Website
Key: WEBSITE JENKINS - 454 53462
Workflow: WEBSITE: Software Development Workflow JNJira + In-Review
Status: To Do Open
Component/s: core
Component/s: core
Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

dbeck@cloudbees.com (JIRA)

unread,
Sep 7, 2018, 6:30:02 AM9/7/18
to jenkinsc...@googlegroups.com
Daniel Beck commented on Bug JENKINS-53462
 
Re: Jenkins websites use non-trusted 'submit' event to start form submission when current browser is Firefox

Henrik Skupin Can you clarify what release of Firefox this should be in? From my reading, it should be in 56.x, but I'm on 61, soon 62, and can log in just fine, current or previous login form.

hskupin@gmail.com (JIRA)

unread,
Sep 7, 2018, 7:01:03 AM9/7/18
to jenkinsc...@googlegroups.com

We had to backout the patch due to the regression with Jenkins. As such it was only available in some Nightly builds of Firefox during the 56 development process.

hskupin@gmail.com (JIRA)

unread,
Sep 7, 2018, 7:03:03 AM9/7/18
to jenkinsc...@googlegroups.com

Ok, so I checked with such a Nightly build and switched the user agent to Chrome. That actually fixed it, yes.

dbeck@cloudbees.com (JIRA)

unread,
Sep 7, 2018, 7:07:02 AM9/7/18
to jenkinsc...@googlegroups.com

I wonder what happens with Jenkins in current releases of Firefox if we remove the special treatment. I assume that was added for a reason.

IOW, do we rip out the Firefox special behavior, or do we need more elaborate Firefox special behavior to remain compatible with current and future Firefox.

echen@mozilla.com (JIRA)

unread,
Sep 7, 2018, 9:31:03 AM9/7/18
to jenkinsc...@googlegroups.com

I checked the LTS 2.121.2 and 2.121.3, I still saw the Firefox special behavior. I am not sure if 2.138.1 fixes this, but I am happy to test again.

From the form submission point of view, it is not necessary to give Firefox special behavior, giving the same behavior as other browser should just also work on Firefox.

dbeck@cloudbees.com (JIRA)

unread,
Sep 7, 2018, 9:40:02 AM9/7/18
to jenkinsc...@googlegroups.com

Should be testable by setting a different User-Agent on a prod release of Firefox I suppose.

dbeck@cloudbees.com (JIRA)

unread,
Sep 7, 2018, 9:43:03 AM9/7/18
to jenkinsc...@googlegroups.com

And assuming Chrome behaves to spec (like Firefox post-fix), we should be able to observe the problem in Jenkins by setting Chrome's User-Agent to Firefox.

dbeck@cloudbees.com (JIRA)

unread,
Sep 7, 2018, 9:43:03 AM9/7/18
to jenkinsc...@googlegroups.com
Daniel Beck updated an issue
 
Change By: Daniel Beck
Environment: All Any Jenkins websites. e.g. https://jenkins.qa.ubuntu.com/ login form

echen@mozilla.com (JIRA)

unread,
Sep 7, 2018, 9:46:02 AM9/7/18
to jenkinsc...@googlegroups.com

dbeck@cloudbees.com (JIRA)

unread,
Sep 7, 2018, 9:52:02 AM9/7/18
to jenkinsc...@googlegroups.com

And assuming Chrome behaves to spec (like Firefox post-fix), we should be able to observe the problem in Jenkins by setting Chrome's User-Agent to Firefox.

This is exactly what's happening.

The good news is that the redesigned login form will work in 2.138.1.

The bad news is that all other submit buttons will not. It's not quite as bad as before, as most forms have an 'Apply' button that still works, but close.

hskupin@gmail.com (JIRA)

unread,
Sep 14, 2018, 3:25:03 AM9/14/18
to jenkinsc...@googlegroups.com

Regarding the bad news, about how many different submit buttons we are talking here? Is it something which could easily be fixed and shipped, or how long would it take? So far Jenkins seems to be the only site which blocks us from shipping this feature fix, and we really would like to get this out to our users for a better web platform conformance.

 

Thanks.

dbeck@cloudbees.com (JIRA)

unread,
Sep 14, 2018, 8:01:02 PM9/14/18
to jenkinsc...@googlegroups.com

I suspect it'll be one button, but it's reused a lot as the f:submit form control. Just needs someone to figure out where JS takes a wrong turn to address this.

tscherler@cloudbees.com (JIRA)

unread,
Oct 10, 2018, 4:18:05 AM10/10/18
to jenkinsc...@googlegroups.com
Thorsten Scherler assigned an issue to Thorsten Scherler
 
Change By: Thorsten Scherler
Assignee: Thorsten Scherler

tscherler@cloudbees.com (JIRA)

unread,
Oct 10, 2018, 4:18:05 AM10/10/18
to jenkinsc...@googlegroups.com
Thorsten Scherler started work on Bug JENKINS-53462
 
Change By: Thorsten Scherler
Status: Open In Progress

tscherler@cloudbees.com (JIRA)

unread,
Oct 10, 2018, 4:26:01 AM10/10/18
to jenkinsc...@googlegroups.com
Thorsten Scherler commented on Bug JENKINS-53462
 
Re: Jenkins websites use non-trusted 'submit' event to start form submission when current browser is Firefox

I will have a look now whether I can come up with a fix.

My understanding so far:

  • I need a patched FF version (the earlier links do not work anymore, can you Henrik Skupin provide me with a link?)
  • The "new login" page works, as Daniel Beck said, most likely because I only used vanilla js, no external libs and especially no 
    f:submit
  • in the bugzilla thread someone mentioned YUI I think that may be the base problem.

I will now review the 

f:submit

and see whether I can extract all usage of YUI and do "vanilla js" submits.

dbeck@cloudbees.com (JIRA)

unread,
Oct 10, 2018, 6:37:02 AM10/10/18
to jenkinsc...@googlegroups.com

I need a patched FF version

Not quite. All you need is a Chrome that claims to be FF, then that will encounter the same problem as patched/future Firefox would. Probably simpler to get started

tscherler@cloudbees.com (JIRA)

unread,
Oct 10, 2018, 8:42:01 AM10/10/18
to jenkinsc...@googlegroups.com

https://github.com/scherler/jenkins/tree/JENKINS-53462 I created a callback and in case we have a submit type we look up the parent form and submit it.

...I know but those 9 line of code is based on different approaches and to not break the universe I implemented like as-is.

tscherler@cloudbees.com (JIRA)

unread,
Oct 10, 2018, 8:58:01 AM10/10/18
to jenkinsc...@googlegroups.com

dbeck@cloudbees.com (JIRA)

unread,
Oct 10, 2018, 1:24:03 PM10/10/18
to jenkinsc...@googlegroups.com

Jenkins PR build for download at https://ci.jenkins.io/job/Core/job/jenkins/job/PR-3689/2/artifact/org/jenkins-ci/main/jenkins-war/2.147-rc27437.1590be3ff083/jenkins-war-2.147-rc27437.1590be3ff083.war

Perhaps those watchers with ability to patch and build their own Firefox could check whether form submission buttons in this Jenkins build address the problem?

 

hskupin@gmail.com (JIRA)

unread,
Oct 18, 2018, 5:30:02 AM10/18/18
to jenkinsc...@googlegroups.com

Thanks Daniel Beck. Sadly I don't have a chance to run such a Jenkins build locally and verify all the different occurrences of this problem. You and Thorsten Scherler should have the better overview of what to test.

Therefore you wouldn't have to build Firefox with the patch but as I mentioned above just pick one of the older Firefox Nightly builds for your platform. The one which had this patch included can be found at https://archive.mozilla.org/pub/firefox/nightly/2017/07/2017-07-07-10-01-38-mozilla-central/.

 

Let me know if that works for you. Thanks in advance!

hskupin@gmail.com (JIRA)

unread,
Oct 18, 2018, 5:31:02 AM10/18/18
to jenkinsc...@googlegroups.com

tscherler@cloudbees.com (JIRA)

unread,
Oct 18, 2018, 6:30:02 AM10/18/18
to jenkinsc...@googlegroups.com

tscherler@cloudbees.com (JIRA)

unread,
Oct 18, 2018, 6:41:01 AM10/18/18
to jenkinsc...@googlegroups.com
Thorsten Scherler edited a comment on Bug JENKINS-53462
[~whimboo] https://youtu.be/o6bw5KEIqik AFAIC tell it works
and debug mode: https://youtu.be/321YMNNozcE

hskupin@gmail.com (JIRA)

unread,
Oct 18, 2018, 7:08:04 AM10/18/18
to jenkinsc...@googlegroups.com

Thorsten Scherler, I assume that without your patch saving the settings doesn't work? Also AFAIR it was mentioned that all submit buttons throughout Jenkins are affected by that. They all work that way now? If yes, that sounds great.

tscherler@cloudbees.com (JIRA)

unread,
Oct 18, 2018, 3:03:02 PM10/18/18
to jenkinsc...@googlegroups.com

https://youtu.be/oT7orP-FdMs I just tested on master Henrik Skupin and it shows the issue description. I am pretty confident that the PR fixes the issue (not by winning a beauty competition, but...)

hskupin@gmail.com (JIRA)

unread,
Oct 18, 2018, 4:56:02 PM10/18/18
to jenkinsc...@googlegroups.com

Wonderful. In that case I assume you want to finish up the patch now? Is there something else you would need help with?

My remaining question would be if we could also get this into a LTS release once it landed on master.

 

tscherler@cloudbees.com (JIRA)

unread,
Oct 18, 2018, 5:04:02 PM10/18/18
to jenkinsc...@googlegroups.com

to your last question I guess Daniel Beck or R. Tyler Croy can make this happening.

The patch just needs some approves and it is done.

BTW I just verified that other parts of jenkins will work as expected and I left a comment in the FF bugzilla to link to the pr as fix when people run into the issue on older versions of jenkins.

HTH and thanks for all your hard work at mozilla!!!

tscherler@cloudbees.com (JIRA)

unread,
Oct 18, 2018, 5:04:02 PM10/18/18
to jenkinsc...@googlegroups.com
Thorsten Scherler edited a comment on Bug JENKINS-53462
to your last question I guess [~danielbeck] or [~rtyler] can make this happening happen . ;)


The patch just needs some approves and it is done.

BTW I just verified that other parts of jenkins will work as expected and I left a comment in the FF bugzilla to link to the pr as fix when people run into the issue on older versions of jenkins.

HTH and thanks for all your hard work at mozilla!!!

tscherler@cloudbees.com (JIRA)

unread,
Oct 18, 2018, 5:14:02 PM10/18/18
to jenkinsc...@googlegroups.com

As final explanation why FF stopped working is that since we did not provide a callback to the onClick, FF is correctly stop propagating and all other browser are wrong to propagate the event to a submit.

We fixed the f:submit however the problem may occur in other parts but the solution will always be to provide a default fallback for onClick.

tscherler@cloudbees.com (JIRA)

unread,
Oct 18, 2018, 5:15:02 PM10/18/18
to jenkinsc...@googlegroups.com
Thorsten Scherler edited a comment on Bug JENKINS-53462

tscherler@cloudbees.com (JIRA)

unread,
Oct 18, 2018, 5:16:02 PM10/18/18
to jenkinsc...@googlegroups.com
Thorsten Scherler edited a comment on Bug JENKINS-53462
As final explanation why FF stopped working is that since we did not provide a callback to the onClick, FF correctly stop stops propagating and all other browser are wrong to propagate the event to a submit.


We fixed the f:submit however the problem may occur in other parts but the solution will always be to provide a default fallback for onClick.

dbeck@cloudbees.com (JIRA)

unread,
Oct 20, 2018, 12:49:02 PM10/20/18
to jenkinsc...@googlegroups.com

My remaining question would be if we could also get this into a LTS release once it landed on master.

Doubtful, the RC for the next LTS is due next Wednesday and we generally require changes to soak for at least two releases (~10 days), preferably three, before backporting.

Should be in the early December LTS though.

dbeck@cloudbees.com (JIRA)

unread,
Oct 20, 2018, 12:49:03 PM10/20/18
to jenkinsc...@googlegroups.com
Daniel Beck updated an issue
Change By: Daniel Beck
Labels: lts-candidate

hskupin@gmail.com (JIRA)

unread,
Oct 22, 2018, 4:23:02 AM10/22/18
to jenkinsc...@googlegroups.com
Henrik Skupin commented on Bug JENKINS-53462
 
Re: Jenkins websites use non-trusted 'submit' event to start form submission when current browser is Firefox

That's great to hear that you are considering it for a LTS release even it's not the upcoming one. Thanks a lot!

hskupin@gmail.com (JIRA)

unread,
Nov 1, 2018, 3:39:02 PM11/1/18
to jenkinsc...@googlegroups.com

Daniel Beck, I simply want to report back that one of our engineers who works a lot with Jenkins just checked the latest release of Jenkins and it indeed seems to work all fine. Having it in the next LTS release would be fantastic! Thanks!

dbeck@cloudbees.com (JIRA)

unread,
Nov 7, 2018, 7:23:02 AM11/7/18
to jenkinsc...@googlegroups.com

We identified regressions that we believe are caused by this change (linked issues). This increases the likelihood that we won't choose 2.148 or newer as the next LTS baseline.

hskupin@gmail.com (JIRA)

unread,
Nov 7, 2018, 7:40:02 AM11/7/18
to jenkinsc...@googlegroups.com

What I wonder is that the change here should have only affected Firefox, right? But people are filing issues for Chrome and IE.

dbeck@cloudbees.com (JIRA)

unread,
Nov 7, 2018, 7:45:01 AM11/7/18
to jenkinsc...@googlegroups.com

hskupin@gmail.com (JIRA)

unread,
Nov 7, 2018, 7:55:02 AM11/7/18
to jenkinsc...@googlegroups.com

Oh, I thought that this issue was about a custom behavior only used for Firefox; as stated in the issue summary. So the non-trusted `submit` event was used for all browsers then?

jglick@cloudbees.com (JIRA)

unread,
Nov 7, 2018, 1:15:01 PM11/7/18
to jenkinsc...@googlegroups.com

JENKINS-54233 was recently reported, though I cannot reproduce it and it does not seem to have anything to do with clicking buttons (though it does look like a JavaScript issue).

dbeck@cloudbees.com (JIRA)

unread,
Nov 14, 2018, 7:29:02 AM11/14/18
to jenkinsc...@googlegroups.com

Proposed reversal of the fix in https://github.com/jenkinsci/jenkins/pull/3760 due to regressions it caused (especially for the upcoming 2.150.x LTS line).

Proposed amendment of the fix in https://github.com/jenkinsci/jenkins/pull/3761 in the hopes it would solve the problem. Due to time constraints this has undergone minimal testing, would appreciate if others could take a look.

dbeck@cloudbees.com (JIRA)

unread,
Nov 14, 2018, 1:27:03 PM11/14/18
to jenkinsc...@googlegroups.com
Daniel Beck edited a comment on Bug JENKINS-53462
Proposed reversal of the fix in [https://github.com/jenkinsci/jenkins/pull/3760] due to regressions it caused (especially for the upcoming 2.150.x LTS line).

Proposed amendment of the fix in [https://github.com/jenkinsci/jenkins/pull/3761] in the hopes it would solve the problem. Due to time constraints this has undergone minimal testing, would appreciate if others could take a look.

[https://repo.jenkins-ci.org/incrementals/org/jenkins-ci/main/jenkins-war/2.152-rc27510.acc4eec688a0/] has the jenkins.war for this PR, which currently is 2.151 + the specific change.

hskupin@gmail.com (JIRA)

unread,
Nov 15, 2018, 2:52:02 AM11/15/18
to jenkinsc...@googlegroups.com

Thank you for the update Daniel! I also asked on https://bugzilla.mozilla.org/show_bug.cgi?id=1399783 if someone could help testing it with Firefox. Hope the new proposed fix will be less regression-prone and will fix it.

dbeck@cloudbees.com (JIRA)

unread,
Apr 11, 2019, 3:46:05 AM4/11/19
to jenkinsc...@googlegroups.com
Daniel Beck updated Bug JENKINS-53462
 

Next attempt at fixing this is done towards the next weekly release, 2.173.
Change By: Daniel Beck
Status: In Progress Fixed but Unreleased
Assignee: Thorsten Scherler Daniel Beck
Resolution: Fixed
Released As: Jenkins 2.173

hskupin@gmail.com (JIRA)

unread,
Apr 15, 2019, 3:57:03 AM4/15/19
to jenkinsc...@googlegroups.com
 
Re: Jenkins websites use non-trusted 'submit' event to start form submission when current browser is Firefox

Thanks Daniel Beck! These are great news. I cannot await to see this being shipped with that release, and for a LTS later. Is there a place I can watch in which LTS release it will be included if stable?

dbeck@cloudbees.com (JIRA)

unread,
Apr 15, 2019, 5:25:04 AM4/15/19
to jenkinsc...@googlegroups.com

2.164.3, scheduled for May 8, the earliest, if accepted as a backport. The next .1, scheduled for early June, otherwise. Assuming of course we don't cause regressions again.

dbeck@cloudbees.com (JIRA)

unread,
Apr 15, 2019, 5:27:02 AM4/15/19
to jenkinsc...@googlegroups.com
Change By: Daniel Beck
Status: Fixed but Unreleased Resolved

dbeck@cloudbees.com (JIRA)

unread,
Apr 15, 2019, 10:55:05 PM4/15/19
to jenkinsc...@googlegroups.com
 
Re: Jenkins websites use non-trusted 'submit' event to start form submission when current browser is Firefox

FWIW if someone wants to test this with a patched Firefox build, docker run -p 8080:8080 jenkins/jenkins:2.173 and then go to http://localhost:8080 – should be fairly straightforward to get through the wizard, then e.g. Manage Jenkins » Configure System to go to a form with a formerly broken submit button ("Save").

hskupin@gmail.com (JIRA)

unread,
Apr 16, 2019, 3:31:02 AM4/16/19
to jenkinsc...@googlegroups.com

I won't have the time for testing it, but I requested a new Firefox build with the patch on https://bugzilla.mozilla.org/show_bug.cgi?id=1370630 applied. Currently the patch doesn't apply anymore. Once we have a build I will happily post a link to it.

dbeck@cloudbees.com (JIRA)

unread,
Apr 16, 2019, 5:47:03 AM4/16/19
to jenkinsc...@googlegroups.com
Daniel Beck updated an issue
Change By: Daniel Beck
Environment: Any Jenkins classic login form
(before 2.128), regular "Save" form submission buttons on the classic UI

ogondza@gmail.com (JIRA)

unread,
Apr 23, 2019, 4:52:07 AM4/23/19
to jenkinsc...@googlegroups.com
Oliver Gondža commented on Bug JENKINS-53462
 
Re: Jenkins websites use non-trusted 'submit' event to start form submission when current browser is Firefox

Can someone verify the patch? I have failed to reproduce the problem using firefox-nightly-68.0a1.20190422-1 and jenkins/jenkins:2.172. Both logging in as admin and saving global config page works for me.

hskupin@gmail.com (JIRA)

unread,
Apr 23, 2019, 5:02:02 AM4/23/19
to jenkinsc...@googlegroups.com

Oliver Gondža, a normal nightly build of Firefox won't work given that it hasn't the patch from bug 1370630 included. You can pick a build from https://treeherder.mozilla.org/#/jobs?repo=try&revision=3f12e17b558a36ef5b65235d663c4e617c3d328e&searchStr=build by just clicking the `B` symbol of your platform, selecting Job Details in the lower pane, and then `target.zip`, `target.dmg`, or `target.tar.bz2`. Just extract the archive and run the binary. With such a build you should be able to see the failure without the patch in Jenkins.

dbeck@cloudbees.com (JIRA)

unread,
Apr 23, 2019, 5:17:02 AM4/23/19
to jenkinsc...@googlegroups.com

Oliver Gondža AFAIUI, the behavior of Chrome is the correct one (i.e. future Firefox's), so you should be able to confirm using Chrome with a Firefox user agent string. That's how I reproduced it and worked on the fix.

dbeck@cloudbees.com (JIRA)

unread,
Apr 23, 2019, 5:22:02 AM4/23/19
to jenkinsc...@googlegroups.com

Henrik Skupin Thanks for the link. "Save" buttons don't work on the nightly build and Jenkins 2.164.2, as expected. And they work on Jenkins 2.174, also as expected

hskupin@gmail.com (JIRA)

unread,
Apr 23, 2019, 6:40:02 AM4/23/19
to jenkinsc...@googlegroups.com

Great to be helpful. And that sounds fantastic. So we now have to wait for the 2.174 and an upcoming LTS before we can make that change live in Firefox.

ogondza@gmail.com (JIRA)

unread,
Apr 23, 2019, 6:45:03 AM4/23/19
to jenkinsc...@googlegroups.com
Oliver Gondža updated an issue
 
Change By: Oliver Gondža
Labels: lts 2.164.3 - candidate fixed

ogondza@gmail.com (JIRA)

unread,
Apr 23, 2019, 6:56:04 AM4/23/19
to jenkinsc...@googlegroups.com
Oliver Gondža commented on Bug JENKINS-53462
 
Re: Jenkins websites use non-trusted 'submit' event to start form submission when current browser is Firefox

Cool, thanks! I am backporting this to 2.164.3 to be released 2019-04-08, unless further regressions are found.

Henrik Skupin, I do appreciate the effort put in making sure Jenkins is ready for the fix in Firefox. Though I am wondering if there is a chance to postpone the delivery until significant Jenkins (or what other applications are affected) userbase migrate to the fixed version.

hskupin@gmail.com (JIRA)

unread,
Apr 23, 2019, 7:09:03 AM4/23/19
to jenkinsc...@googlegroups.com

I assume you mean 2019-05-08.

We can post-pone for sure. It's not that this patch is critical, and we already waited a while for it. Do you have some stats in how long it takes for the majority of users to upgrade to the next LTS release? Will it be one week, or two? Also note that the fix will land on mozilla-central only, which means it will only be part of a nightly build. Those people are tech-aware and should upgrade their instances fast enough.

 

Our next merge to beta is on 2019-05-13, so I would suggest to at least wait until 2019-05-14 before landing that change in Firefox Nightly (69).

ogondza@gmail.com (JIRA)

unread,
Apr 23, 2019, 7:12:02 AM4/23/19
to jenkinsc...@googlegroups.com
Oliver Gondža edited a comment on Bug JENKINS-53462
Cool, thanks! I am backporting this to 2.164.3 to be released - 2019-04-08 - (EDIT: 2019-05-08) , unless further regressions are found.

[~whimboo], I do appreciate the effort put in making sure Jenkins is ready for the fix in Firefox. Though I am wondering if there is a chance to postpone the delivery until significant Jenkins (or what other applications are affected) userbase migrate to the fixed version.

dbeck@cloudbees.com (JIRA)

unread,
Apr 23, 2019, 8:10:03 AM4/23/19
to jenkinsc...@googlegroups.com

Henrik Skupin We are unfamiliar with the Firefox release schedule, could you clarify what that means in terms of rolling out the change to regular users? Those who are on 66.0.3 right now?

For Jenkins, based on usage statistics, 60% of LTS users are within the last 4 LTS releases (~4 months), and 50% of weekly release users are within the last 16 releases (~3.5 months). So I expect the majority of Jenkins users to be on compatible releases around August/September, and they can update no later than May (for LTS), and should already be updated (for weekly releases).

From a project POV, we only consider the latest LTS and weekly releases (e.g. only those get security fixes) to be supported. Of course users may lag behind in updating, and for some setups, updating Jenkins is a big project. The question the Firefox team will need to answer is, how aggressively do they want to annoy Firefox+Jenkins users that update one but not the other.

dbeck@cloudbees.com (JIRA)

unread,
Apr 23, 2019, 8:15:02 AM4/23/19
to jenkinsc...@googlegroups.com
Daniel Beck closed an issue as Fixed
 
Change By: Daniel Beck
Status: Resolved Closed

hskupin@gmail.com (JIRA)

unread,
Apr 23, 2019, 9:15:03 AM4/23/19
to jenkinsc...@googlegroups.com
Henrik Skupin commented on Bug JENKINS-53462
 
Re: Jenkins websites use non-trusted 'submit' event to start form submission when current browser is Firefox

Daniel Beck thank you for bringing this up. It's actually not my job to make such a decision, so I will leave it up to the release managers to decide. I will clearly reference your last comment, so that they are aware of the situation for Jenkins users.

 

hskupin@gmail.com (JIRA)

unread,
Apr 25, 2019, 2:38:02 PM4/25/19
to jenkinsc...@googlegroups.com

Ok, so here an update. If that patch sticks and will not be backed out again, we will land the Firefox patch for Firefox 69 on May 14th or 15th. Which means it will ride the trains through beta, and will be finally be released on Sep 3rd. If by that time there are still users who running a Jenkins LTS release earlier than 2.164.3, they will have to use Firefox 68 ESR. That ESR version will be maintained for another year, and will never have this patch included. Details see https://bugzilla.mozilla.org/show_bug.cgi?id=1370630#c41 and following.

 

Thanks a lot again for the patch! It will unblock us from landing several features which are all blocked by this particular issue.

hskupin@gmail.com (JIRA)

unread,
Apr 25, 2019, 2:39:01 PM4/25/19
to jenkinsc...@googlegroups.com
Henrik Skupin edited a comment on Bug JENKINS-53462

dbeck@cloudbees.com (JIRA)

unread,
Oct 29, 2019, 9:42:08 AM10/29/19
to jenkinsc...@googlegroups.com
Daniel Beck reopened an issue
 
Change By: Daniel Beck
Resolution: Fixed
Status: Closed Reopened
Assignee: Daniel Beck
This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)
Atlassian logo

dbeck@cloudbees.com (JIRA)

unread,
Oct 29, 2019, 9:43:02 AM10/29/19
to jenkinsc...@googlegroups.com
Daniel Beck commented on Bug JENKINS-53462
 
Re: Jenkins websites use non-trusted 'submit' event to start form submission when current browser is Firefox

Reopened because 2.202 backed out the change again due to the regression it caused (JENKINS-58296).

dbeck@cloudbees.com (JIRA)

unread,
Nov 1, 2019, 4:37:03 PM11/1/19
to jenkinsc...@googlegroups.com
Daniel Beck updated an issue
 
Change By: Daniel Beck
Released As: Jenkins 2.173 to 2.2.201, removed from 2.202

dbeck@cloudbees.com (JIRA)

unread,
Nov 2, 2019, 5:37:03 AM11/2/19
to jenkinsc...@googlegroups.com
Daniel Beck updated an issue
Change By: Daniel Beck
Released As: Jenkins 2.173 to 2. 2. 201, removed from 2.202
Reply all
Reply to author
Forward
0 new messages