[JIRA] (JENKINS-61224) "Monitors" terminology should not be used in GUI

34 views
Skip to first unread message

jglick@cloudbees.com (JIRA)

unread,
Feb 25, 2020, 9:56:03 AM2/25/20
to jenkinsc...@googlegroups.com
Jesse Glick created an issue
 
Jenkins / Bug JENKINS-61224
"Monitors" terminology should not be used in GUI
Issue Type: Bug Bug
Assignee: Unassigned
Components: core
Created: 2020-02-25 14:55
Priority: Trivial Trivial
Reporter: Jesse Glick

After JENKINS-60920 (I guess?), the header bar shows <bell icon> monitors 2 and the tooltip shows

bq . There are 2 active administrative monitors.

We should not be using the bare term "monitor" in the GUI. This word in English has various meanings (video displays, bureaucratic police, ...) but none of them would be intuitive in this context. In some spots in the GUI like /configure we do use the phrase "administrative monitor" which is more tolerable, though something like "alert" or "notification" would be more conventional. (I think the Java API introduced AdministrativeMonitor to describe how the implementations are written—by monitoring some condition and conditionally displaying the result to administrators—but this does not well capture the user's perspective.)

I would suggest just deleting the word from the toolbar. The bell icon suffices for people to understand that there are some alerts they can see by clicking on it.
Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)
Atlassian logo

jglick@cloudbees.com (JIRA)

unread,
Feb 25, 2020, 9:57:06 AM2/25/20
to jenkinsc...@googlegroups.com
Jesse Glick assigned an issue to Félix Queiruga Balado
Change By: Jesse Glick
Assignee: Félix Queiruga Balado

fqueiruga@cloudbees.com (JIRA)

unread,
Feb 26, 2020, 3:28:04 AM2/26/20
to jenkinsc...@googlegroups.com
Félix Queiruga Balado commented on Bug JENKINS-61224
 
Re: "Monitors" terminology should not be used in GUI

I sort of agree with you.

I think having a good, meaningful label would be better. On the other side, having a bad label is even worse. I'll be happy to create a patch to remove this if more people agree that it should be done.

dbeck@cloudbees.com (JIRA)

unread,
Feb 26, 2020, 6:17:03 AM2/26/20
to jenkinsc...@googlegroups.com
Daniel Beck updated an issue
 
Change By: Daniel Beck
Labels: lts-candidate

dbeck@cloudbees.com (JIRA)

unread,
Feb 26, 2020, 6:23:02 AM2/26/20
to jenkinsc...@googlegroups.com
Daniel Beck commented on Bug JENKINS-61224
 
Re: "Monitors" terminology should not be used in GUI

Do not disagree for the headr, but what about the Adminstrative Monitors Configuration in Configure System? We need a name for these things.

dbeck@cloudbees.com (JIRA)

unread,
Feb 26, 2020, 6:24:04 AM2/26/20
to jenkinsc...@googlegroups.com
Daniel Beck updated an issue
Change By: Daniel Beck
Comment: Do not disagree for the headr, but what about the Adminstrative Monitors Configuration in Configure System? We need _a_ name for these things.

msicker@cloudbees.com (JIRA)

unread,
Feb 26, 2020, 12:44:03 PM2/26/20
to jenkinsc...@googlegroups.com
Matt Sicker commented on Bug JENKINS-61224
 
Re: "Monitors" terminology should not be used in GUI

Using the word "alert" instead of "monitor" might work. Or there might be some vocabulary that can be lifted from observability frameworks.
This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)
Atlassian logo

jthompson@cloudbees.com (JIRA)

unread,
Feb 26, 2020, 12:46:02 PM2/26/20
to jenkinsc...@googlegroups.com

I've had the same concerns with naming on these things before. The API name isn't a good term for users, but it got picked up and used in UI a number of places. I think the best term is "alert".

I don't have much of an opinion on Jesse's latter suggestion of removing the word entirely. I guess I would have a slight, soft preference for retaining text with better wording.

msicker@cloudbees.com (JIRA)

unread,
Feb 26, 2020, 12:51:03 PM2/26/20
to jenkinsc...@googlegroups.com

Warnings could work, too. Or if someone can think of a good butler pun: I'd love that.

romen@romenrg.com (JIRA)

unread,
Mar 4, 2020, 3:35:06 PM3/4/20
to jenkinsc...@googlegroups.com

I'd agree with Jesse, we don't need to have text at all, just the bell and the number, as is common pattern in many other cases, such as GitHub.

Félix Queiruga Balado, are you OK if I assign this to myself as discussed in the UX SIG? I'll be happy to work on that so that I get more familiar with the Jenkins UI and can keep contributing to it.

fqueiruga@cloudbees.com (JIRA)

unread,
Mar 5, 2020, 5:29:04 AM3/5/20
to jenkinsc...@googlegroups.com
Félix Queiruga Balado updated an issue
 
Change By: Félix Queiruga Balado
Labels: lts-candidate newbie-friendly

romen@romenrg.com (JIRA)

unread,
Mar 5, 2020, 5:45:03 AM3/5/20
to jenkinsc...@googlegroups.com
Romen Rodriguez-Gil edited a comment on Bug JENKINS-61224
I'd agree with Jesse, we don't need to have text at all, just the bell and the number, as is common pattern in many other cases, such as GitHub.

[~fqueiruga], are you OK if I assign this to myself as discussed in the UX SIG? I'll be happy to work on that so that I get more familiar with the Jenkins UI and can keep contributing to it.

Edit: Just chatted with Félix and he is OK, so I'm assigning it to me

romen@romenrg.com (JIRA)

unread,
Mar 5, 2020, 5:45:03 AM3/5/20
to jenkinsc...@googlegroups.com
Romen Rodriguez-Gil assigned an issue to Romen Rodriguez-Gil
 
Change By: Romen Rodriguez-Gil
Assignee: Félix Queiruga Balado Romen Rodriguez-Gil

bmathus+ossjira@cloudbees.com (JIRA)

unread,
Mar 5, 2020, 6:10:03 AM3/5/20
to jenkinsc...@googlegroups.com
Baptiste Mathus commented on Bug JENKINS-61224
 
Re: "Monitors" terminology should not be used in GUI

Woot <3! Gracias Romen! Go go go ! \o/

romen@romenrg.com (JIRA)

unread,
Mar 5, 2020, 3:10:05 PM3/5/20
to jenkinsc...@googlegroups.com
Romen Rodriguez-Gil started work on Bug JENKINS-61224
 
Change By: Romen Rodriguez-Gil
Status: Open In Progress

romen@romenrg.com (JIRA)

unread,
Mar 8, 2020, 10:33:03 AM3/8/20
to jenkinsc...@googlegroups.com

romen@romenrg.com (JIRA)

unread,
Mar 8, 2020, 10:34:05 AM3/8/20
to jenkinsc...@googlegroups.com
 
Change By: Romen Rodriguez-Gil
Status: Open In Progress

romen@romenrg.com (JIRA)

unread,
Mar 8, 2020, 10:34:12 AM3/8/20
to jenkinsc...@googlegroups.com
Romen Rodriguez-Gil stopped work on Bug JENKINS-61224
 
Change By: Romen Rodriguez-Gil
Status: In Progress Open

jglick@cloudbees.com (JIRA)

unread,
Mar 9, 2020, 9:25:04 AM3/9/20
to jenkinsc...@googlegroups.com
Change By: Jesse Glick
Status: In Progress Review

romen@romenrg.com (JIRA)

unread,
Mar 15, 2020, 10:13:03 AM3/15/20
to jenkinsc...@googlegroups.com
 
Re: "Monitors" terminology should not be used in GUI

Just FTR, noting here that the linked PR ended up including a color change in the monitor alert, both for the old UI and for the new. The "proposed changelog entries" were modified in the PR accordingly.

bmathus+ossjira@cloudbees.com (JIRA)

unread,
Mar 16, 2020, 6:16:03 AM3/16/20
to jenkinsc...@googlegroups.com
Change By: Baptiste Mathus
Status: In Review Fixed but Unreleased
Resolution: Fixed
Released As: 2.226

bmathus+ossjira@cloudbees.com (JIRA)

unread,
Mar 16, 2020, 6:16:04 AM3/16/20
to jenkinsc...@googlegroups.com
Change By: Baptiste Mathus
Status: Fixed but Unreleased Resolved

ogondza@gmail.com (JIRA)

unread,
Apr 3, 2020, 4:29:03 AM4/3/20
to jenkinsc...@googlegroups.com
Oliver Gondža updated an issue
Change By: Oliver Gondža
Labels: lts-candidate newbie-friendly

ogondza@gmail.com (JIRA)

unread,
Apr 3, 2020, 4:30:03 AM4/3/20
to jenkinsc...@googlegroups.com
Oliver Gondža commented on Bug JENKINS-61224
 
Re: "Monitors" terminology should not be used in GUI

I am removing the `lts-candidate` as the is too minor to qualify for LTS backport.
Reply all
Reply to author
Forward
0 new messages