[JIRA] (JENKINS-62001) Autocompletion dropdown UI looks broken

16 views
Skip to first unread message

dbeck@cloudbees.com (JIRA)

unread,
Apr 21, 2020, 4:20:03 PM4/21/20
to jenkinsc...@googlegroups.com
Daniel Beck created an issue
 
Jenkins / Bug JENKINS-62001
Autocompletion dropdown UI looks broken
Issue Type: Bug Bug
Assignee: Unassigned
Attachments: 2.222.1.png, 2.233.png
Components: core
Created: 2020-04-21 20:19
Labels: regression ui ux
Priority: Minor Minor
Reporter: Daniel Beck

Attached screenshots of the "Logger" configuration autocompletion UI in 2.222.1 and 2.233.

It looks like one of the recent redesign PRs messed this up.
Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)
Atlassian logo

dbeck@cloudbees.com (JIRA)

unread,
Apr 21, 2020, 4:25:03 PM4/21/20
to jenkinsc...@googlegroups.com
Daniel Beck commented on Bug JENKINS-62001
 
Re: Autocompletion dropdown UI looks broken

Looks correctin 2.232, so this is a regression in 2.233 specifically.

dbeck@cloudbees.com (JIRA)

unread,
Apr 21, 2020, 4:30:03 PM4/21/20
to jenkinsc...@googlegroups.com
Daniel Beck updated an issue
 
Change By: Daniel Beck
Environment: Jenkins 2.233

fqueiruga@cloudbees.com (JIRA)

unread,
Apr 22, 2020, 2:36:02 AM4/22/20
to jenkinsc...@googlegroups.com
Félix Queiruga Balado commented on Bug JENKINS-62001
 
Re: Autocompletion dropdown UI looks broken

If this is in Core I'll take a look Today

fqueiruga@cloudbees.com (JIRA)

unread,
Apr 22, 2020, 2:37:03 AM4/22/20
to jenkinsc...@googlegroups.com

In which screen does this manifest?

fqueiruga@cloudbees.com (JIRA)

unread,
Apr 22, 2020, 2:38:03 AM4/22/20
to jenkinsc...@googlegroups.com
In which screen does this manifest? Do I need a plugin to see it?

dbeck@cloudbees.com (JIRA)

unread,
Apr 22, 2020, 4:16:02 AM4/22/20
to jenkinsc...@googlegroups.com

fqueiruga@cloudbees.com (JIRA)

unread,
Apr 22, 2020, 4:26:02 AM4/22/20
to jenkinsc...@googlegroups.com

This was caused because the YUI skin.css file is no longer used: https://github.com/jenkinsci/jenkins/commit/d1cd03f48103f5624790b15335eaf6ac04fdb6ad#diff-d00c6bc3369be9674b400c1a8163acb6

I wouldn't want to restore the whole file because it will mess up the button styles a lot. Also, restoring just the following code fixes the issue:

.yui-skin-sam .yui-ac {
  position: relative;
  font-family: arial;
  font-size: 100%;
}
.yui-skin-sam .yui-ac-input {
  position: absolute;
  width: 100%;
}
.yui-skin-sam .yui-ac-container {
  position: absolute;
  top: 1.6em;
  width: 100%;
}
.yui-skin-sam .yui-ac-content {
  position: absolute;
  width: 100%;
  border: 1px solid #808080;
  background: #fff;
  overflow: hidden;
  z-index: 9050;
}
.yui-skin-sam .yui-ac-shadow {
  position: absolute;
  margin: 0.3em;
  width: 100%;
  background: #000;
  -moz-opacity: 0.1;
  opacity: 0.1;
  filter: alpha(opacity=10);
  z-index: 9049;
}
.yui-skin-sam .yui-ac iframe {
  opacity: 0;
  filter: alpha(opacity=0);
  padding-right: 0.3em;
  padding-bottom: 0.3em;
}
.yui-skin-sam .yui-ac-content ul {
  margin: 0;
  padding: 0;
  width: 100%;
}
.yui-skin-sam .yui-ac-content li {
  margin: 0;
  padding: 2px 5px;
  cursor: default;
  white-space: nowrap;
  list-style: none;
  zoom: 1;
}
.yui-skin-sam .yui-ac-content li.yui-ac-prehighlight {
  background: #b3d4ff;
}
.yui-skin-sam .yui-ac-content li.yui-ac-highlight {
  background: #426fd9;
  color: #fff;
}

I'll be creating a patch.

timjacomb1@gmail.com (JIRA)

unread,
Apr 22, 2020, 5:17:03 AM4/22/20
to jenkinsc...@googlegroups.com
Tim Jacomb assigned an issue to Félix Queiruga Balado
 
Change By: Tim Jacomb
Assignee: Félix Queiruga Balado

timjacomb1@gmail.com (JIRA)

unread,
Apr 22, 2020, 5:17:05 AM4/22/20
to jenkinsc...@googlegroups.com
Tim Jacomb started work on Bug JENKINS-62001
 
Change By: Tim Jacomb
Status: Open In Progress

fqueiruga@cloudbees.com (JIRA)

unread,
Apr 22, 2020, 7:21:04 AM4/22/20
to jenkinsc...@googlegroups.com
Change By: Félix Queiruga Balado
Status: In Progress Review

dbeck@cloudbees.com (JIRA)

unread,
Apr 27, 2020, 8:06:04 PM4/27/20
to jenkinsc...@googlegroups.com
Change By: Daniel Beck
Status: In Review Resolved
Resolution: Fixed
Released As: Jenkins 2.234
Reply all
Reply to author
Forward
0 new messages