[JIRA] (JENKINS-60214) Plugin installation manager does not work with other update sites

10 views
Skip to first unread message

leemeador@java.net (JIRA)

unread,
Nov 21, 2019, 3:35:03 PM11/21/19
to jenkinsc...@googlegroups.com
leemeador updated an issue
 
Jenkins / Improvement JENKINS-60214
Plugin installation manager does not work with other update sites
Change By: leemeador
Summary: Plugin installation manager does not work with Cloudbees other update site sites
Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)
Atlassian logo

leemeador@java.net (JIRA)

unread,
Nov 21, 2019, 3:37:02 PM11/21/19
to jenkinsc...@googlegroups.com
leemeador updated an issue
I've found that jenkins-plugin-manager-1.0.1 fails when not used against updates.jenkins.io. For example, the Cloudbees update center fails because that site has no update-center.actual.json file available there. There seems to be is an update-center.json for all of the update centers .

The actual file has pure json content while the non-actual file has a wrapper around the json which is "updateCenter.post( ... json goes here ... );" Someone said that has to do with allowing the file to be more easily compatible with browsers use of javascript.
I don't know if the best thing is to get Cloudbees to add the non-actual file or change the code to remove the wrapper text in in the non-actual file and use it.

bmathus+ossjira@cloudbees.com (JIRA)

unread,
Dec 31, 2019, 5:07:02 AM12/31/19
to jenkinsc...@googlegroups.com
Baptiste Mathus commented on Improvement JENKINS-60214
 
Re: Plugin installation manager does not work with other update sites

Though we could ask to add this on CloudBees side, I think the right way is to actually not use the .actual.json, since this is the other file that Jenkins uses/relies on. So IMO it would be safer to use the file that Jenkins instances are downloading.

timjacomb1@gmail.com (JIRA)

unread,
Dec 31, 2019, 5:53:02 AM12/31/19
to jenkinsc...@googlegroups.com

It seems silly that you need to modify a response before you can use it, would be good for cloudbees to add the JSON imo

bmathus+ossjira@cloudbees.com (JIRA)

unread,
Dec 31, 2019, 7:42:04 AM12/31/19
to jenkinsc...@googlegroups.com

Well, processing data is what we do with these things under our hands .
Back to my point about the "source of truth", I still quite believe the fact the tool does not use what Jenkins does is a pretty important thing?

timjacomb1@gmail.com (JIRA)

unread,
Dec 31, 2019, 6:47:02 PM12/31/19
to jenkinsc...@googlegroups.com

It can handle both formats now

bmathus+ossjira@cloudbees.com (JIRA)

unread,
Jan 2, 2020, 7:49:03 AM1/2/20
to jenkinsc...@googlegroups.com

(y)great! Thanks!

leemeador@java.net (JIRA)

unread,
Jan 2, 2020, 3:54:02 PM1/2/20
to jenkinsc...@googlegroups.com

I found some bugs in the 1st PR after it was merged:

1) If you use the command line option to supply an experimental update center, it generates an incorrect URL from which to load the update-center.json. (There is an improper "update-center.actual.json" embedded it it.)

2) If you supply an update center that has a long URL, such as the version specific update centers at cloudbees, it does not generate the correct URL for loading plugin files. The old algorithm was just removing the last part of the URL and finding plugins below that path.
Reply all
Reply to author
Forward
0 new messages