[JIRA] (JENKINS-56010) Git Plugin v4.0.0-rc breaks Git-Tag-Message-Plugin

17 views
Skip to first unread message

jenkins@callerid.de (JIRA)

unread,
Feb 6, 2019, 7:14:02 PM2/6/19
to jenkinsc...@googlegroups.com
R W created an issue
 
Jenkins / Bug JENKINS-56010
Git Plugin v4.0.0-rc breaks Git-Tag-Message-Plugin
Issue Type: Bug Bug
Assignee: Mark Waite
Components: git-plugin
Created: 2019-02-07 00:13
Priority: Major Major
Reporter: R W

After upgrade from 3.9.2 to 4.0.0-rc, git tag message plugin is not creating GIT_TAG_NAME env anymore.

From build logs, I can also see, that 4.0 does not:
> git tag -l ... -n10000
anymore. Sounds related.

Rolling back to 3.9.2 fixes the issue.

Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

mark.earl.waite@gmail.com (JIRA)

unread,
Feb 11, 2019, 4:04:03 PM2/11/19
to jenkinsc...@googlegroups.com
Mark Waite assigned an issue to Unassigned
Change By: Mark Waite
Assignee: Mark Waite

mark.earl.waite@gmail.com (JIRA)

unread,
Feb 11, 2019, 4:04:04 PM2/11/19
to jenkinsc...@googlegroups.com
Mark Waite updated an issue
Change By: Mark Waite
Component/s: git-tag-message-plugin

mark.earl.waite@gmail.com (JIRA)

unread,
Feb 11, 2019, 4:04:04 PM2/11/19
to jenkinsc...@googlegroups.com
Mark Waite commented on Bug JENKINS-56010
 
Re: Git Plugin v4.0.0-rc breaks Git-Tag-Message-Plugin

This will need a change in the git tag message plugin to adapt to the removal of the BuildData bloat in JENKINS-19022.

I think that Jacob Keller may have suggestions based on the BuildData reference

christian.haeussler@huk-coburg.de (JIRA)

unread,
May 8, 2019, 5:35:03 AM5/8/19
to jenkinsc...@googlegroups.com

We have the same issue with Jenkins V2.138.41.0.1-fixed and Gut-Plugin V4.0.0-RC

mark.earl.waite@gmail.com (JIRA)

unread,
May 8, 2019, 7:05:03 AM5/8/19
to jenkinsc...@googlegroups.com
Mark Waite edited a comment on Bug JENKINS-56010
[~it12lsp] thanks for reporting that.  Yes, any Jenkins version that is running git plugin 4.0.0-rc and git client plugin 3.0.0-rc will see this problem.  A fix is proposed in a [pull request|https://github.com/jenkinsci/git-plugin/pull/689] that adds a test for this specific case and reverts the fix for JENKINS-19022 as the way to fix the failing test.  That pull request has not been merged yet because I need to write tests for the other 2 blocking bugs that seem to be related.  Those bugs are JENKINS-56176 and JENKINS-55939.

I don't plan to require any change to the git tag message plugin at this time, since the issues from the JENKINS-19022 fix seem more serious than I had initially realized.  I did not discover them in my testing, nor did several others that were testing, but the community discovered them when 4.0.0-rc was incorrectly released.
  

  The git plugin 4.0.0-rc release has been blacklisted so that it no longer appears in the update center.  It should not be used on production servers.

mark.earl.waite@gmail.com (JIRA)

unread,
May 8, 2019, 7:05:04 AM5/8/19
to jenkinsc...@googlegroups.com

Christian Häussler thanks for reporting that. Yes, any Jenkins version that is running git plugin 4.0.0-rc and git client plugin 3.0.0-rc will see this problem. A fix is proposed in a pull request that adds a test for this specific case and reverts the fix for JENKINS-19022 as the way to fix the failing test. That pull request has not been merged yet because I need to write tests for the other 2 blocking bugs that seem to be related. Those bugs are JENKINS-56176 and JENKINS-55939.

I don't plan to require any change to the git tag message plugin at this time, since the issues from the JENKINS-19022 fix seem more serious than I had initially realized. I did not discover them in my testing, nor did several others that were testing, but the community discovered them when 4.0.0-rc was incorrectly released. The git plugin 4.0.0-rc release has been blacklisted so that it no longer appears in the update center. It should not be used on production servers.

mark.earl.waite@gmail.com (JIRA)

unread,
May 27, 2019, 6:28:02 PM5/27/19
to jenkinsc...@googlegroups.com
Mark Waite started work on Bug JENKINS-56010
 
Change By: Mark Waite
Status: Open In Progress

mark.earl.waite@gmail.com (JIRA)

unread,
Jun 3, 2019, 2:59:05 PM6/3/19
to jenkinsc...@googlegroups.com

Fixed in merge to master branch. Will be included in the next release of the git plugin

mark.earl.waite@gmail.com (JIRA)

unread,
Jun 3, 2019, 2:59:06 PM6/3/19
to jenkinsc...@googlegroups.com

mark.earl.waite@gmail.com (JIRA)

unread,
Jun 3, 2019, 2:59:06 PM6/3/19
to jenkinsc...@googlegroups.com
Change By: Mark Waite
Status: In Review Resolved
Resolution: Fixed

mark.earl.waite@gmail.com (JIRA)

unread,
Jul 5, 2019, 7:44:03 PM7/5/19
to jenkinsc...@googlegroups.com
Mark Waite closed an issue as Fixed
 

Fixed in Git plugin 4.0.0-beta10

Change By: Mark Waite
Status: Resolved Closed

mark.earl.waite@gmail.com (JIRA)

unread,
Jul 5, 2019, 7:49:03 PM7/5/19
to jenkinsc...@googlegroups.com
Reply all
Reply to author
Forward
0 new messages