[JIRA] (JENKINS-41950) Errors in agent instantiation and checkout not surfaced if post has node-requiring steps

[andrew.bayer@gmail.com (JIRA)]

Andrew Bayer created an issue

Jenkins / JENKINS-41950 Errors in agent instantiation and checkout not surfaced if post has node-requiring steps Issue Type: Bug Assignee: Andrew Bayer Components: pipeline-model-definition-plugin Created: 2017/Feb/11 6:05 PM Priority: Critical Reporter: Andrew Bayer If there's an error in the top-level agent instantiation (say, due to a checkout failing or non-existent Docker image, etc), and the post for the build includes steps that require running on a node (such as deleteDir() or emailext), those post steps will fail and end up being the only reported errors, preventing any visibility into what actually went wrong in the agent. We need to handle those error cases better. Add Comment

This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)

[andrew.bayer@gmail.com (JIRA)]

Andrew Bayer started work on JENKINS-41950

Change By: Andrew Bayer Status: Open In Progress

Add Comment

[andrew.bayer@gmail.com (JIRA)]

Andrew Bayer updated JENKINS-41950

Jenkins / JENKINS-41950 Errors in agent instantiation and checkout not surfaced if post has node-requiring steps

Change By: Andrew Bayer Status: In Progress Review

Add Comment

[andrew.bayer@gmail.com (JIRA)]

Andrew Bayer commented on JENKINS-41950

Re: Errors in agent instantiation and checkout not surfaced if post has node-requiring steps PR up at https://github.com/jenkinsci/pipeline-model-definition-plugin/pull/113

Add Comment

[scm_issue_link@java.net (JIRA)]

SCM/JIRA link daemon commented on JENKINS-41950

Re: Errors in agent instantiation and checkout not surfaced if post has node-requiring steps

Code changed in jenkins User: Andrew Bayer Path: pipeline-model-definition/src/main/resources/org/jenkinsci/plugins/pipeline/modeldefinition/ModelInterpreter.groovy pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/AgentTest.java pipeline-model-definition/src/test/resources/nonExistentDockerImage.groovy http://jenkins-ci.org/commit/pipeline-model-definition-plugin/de9286d6e917e156a6b629bfc595dba1dd3b444b Log: [FIXED JENKINS-41950] Properly report errors outside stages And treat errors in post-build the same whether we're running post-build within the agent block or not.

Add Comment

[andrew.bayer@gmail.com (JIRA)]

Andrew Bayer updated JENKINS-41950

Merged. Will be in 1.0.2 release.

Jenkins / JENKINS-41950

Errors in agent instantiation and checkout not surfaced if post has node-requiring steps

Change By: Andrew Bayer Status: In Review Resolved Resolution: Fixed

Add Comment

[scm_issue_link@java.net (JIRA)]

SCM/JIRA link daemon commented on JENKINS-41950

Re: Errors in agent instantiation and checkout not surfaced if post has node-requiring steps

Code changed in jenkins User: Andrew Bayer Path: pipeline-model-definition/src/main/resources/org/jenkinsci/plugins/pipeline/modeldefinition/ModelInterpreter.groovy pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/AgentTest.java pipeline-model-definition/src/test/resources/nonExistentDockerImage.groovy

http://jenkins-ci.org/commit/pipeline-model-definition-plugin/afaea38ea3a4c7ededb49a69c3104623372dde66 Log: Merge pull request #113 from abayer/jenkins-41950

[FIXED JENKINS-41950] Properly report errors outside stages

Add Comment

[bitwiseman@gmail.com (JIRA)]

Liam Newman closed an issue as Fixed

Bulk closing resolved issues.

Jenkins / JENKINS-41950

Errors in agent instantiation and checkout not surfaced if post has node-requiring steps

Change By: Liam Newman Status: Resolved Closed

Add Comment

This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)