[JIRA] (JENKINS-41764) Perforce triggered build should not trigger polling on jobs unless there are changes related to that view

[rpocase@gmail.com (JIRA)]

Robby Pocase created an issue

Jenkins / JENKINS-41764 Perforce triggered build should not trigger polling on jobs unless there are changes related to that view Issue Type: Improvement Assignee: Unassigned Components: p4-plugin Created: 2017/Feb/06 3:35 PM Priority: Major Reporter: Robby Pocase The current implementation triggers polling on all jobs with Perforce Triggered Build enabled. This is fine for small installations with few check ins per day, but not for installations with hundreds of jobs. This can cause massive spikes in size increases for Perforce server logs. For example, if I check in a file to "//my_depot/..." I should trigger polling on a job with view: //my_depot/... //workspace_name/... However, I should not trigger polling on a job with view: //my_depot2/... //workspace_name/... Add Comment

This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)

[rpocase@gmail.com (JIRA)]

Robby Pocase commented on JENKINS-41764

Re: Perforce triggered build should not trigger polling on jobs unless there are changes related to that view Additionally, it should verify the change is actually associated with the right port. Looks like this work may require significant overhaul of the current probeJobs implementation. The webhook would need to pass in more complete information for better decision making. That overhaul is very likely out of scope of these improvement request.

Add Comment

[rpocase@gmail.com (JIRA)]

Robby Pocase edited a comment on JENKINS-41764

Re: Perforce triggered build should not trigger polling on jobs unless there are changes related to that view

Additionally, it should verify the change is actually associated with the right port. Looks like this work may require significant overhaul of the current probeJobs implementation. The webhook would need to pass in more complete information for better decision making. That overhaul is very likely possibly out of scope of these improvement request. You might be able to accomplish that portion naively in the same request. If you retrieve the change in probeJobs using port and change you likely have a very high success ratio of matching the change to the server. If change is null, it's obviously a mismatch. If change isn't, then your depot path still has to match the jobs workspace view. I would be surprised if many Perforce deployments have large amounts of duplicated full depot paths on multiple servers.

Add Comment

[alena.volarevic@rockstargames.com (JIRA)]

Alena Volarevic commented on JENKINS-41764

Re: Perforce triggered build should not trigger polling on jobs unless there are changes related to that view

Is there any progress on this? Also not sure if it's related or not.. but I have a pipeline script job, that is set to "Perforce triggered build" and it never gets picked up when I send manual P4 Trigger.

Add Comment

This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)

[alena.volarevic@rockstargames.com (JIRA)]

Alena Volarevic commented on JENKINS-41764

Re: Perforce triggered build should not trigger polling on jobs unless there are changes related to that view

Also the jobs that are being triggered by preforce should be build no matter if they are using Source Code Management or not.  Like I have a job that is using the files from the perforce, but I am syncing the workspace files in the build process instead of source code managements portion. and I realized if I don't have source code management set to use perforce. the jobs wont be picked up when the P4 trigger is emitted...

Add Comment