[JIRA] (JENKINS-50682) Error when selecting when / changeRequest or tag in the Directive Generator

2 views
Skip to first unread message

andrew.bayer@gmail.com (JIRA)

unread,
Apr 9, 2018, 3:54:02 PM4/9/18
to jenkinsc...@googlegroups.com
Andrew Bayer commented on Bug JENKINS-50682
 
Re: Error when selecting when / changeRequest or tag in the Directive Generator

tag barfs too, but you have to open the "Advanced" options to get it to do so.
Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)
Atlassian logo

andrew.bayer@gmail.com (JIRA)

unread,
Apr 9, 2018, 3:54:02 PM4/9/18
to jenkinsc...@googlegroups.com
Andrew Bayer updated an issue
 
Jenkins / Bug JENKINS-50682
Change By: Andrew Bayer
Summary:
Error when selecting when / changeRequest or tag in the Directive Generator

andrew.bayer@gmail.com (JIRA)

unread,
Apr 9, 2018, 4:41:02 PM4/9/18
to jenkinsc...@googlegroups.com
Andrew Bayer started work on Bug JENKINS-50682
 
Change By: Andrew Bayer
Status: Open In Progress

andrew.bayer@gmail.com (JIRA)

unread,
Apr 9, 2018, 4:41:02 PM4/9/18
to jenkinsc...@googlegroups.com
Change By: Andrew Bayer
Status: In Progress Review

andrew.bayer@gmail.com (JIRA)

unread,
Apr 9, 2018, 4:41:02 PM4/9/18
to jenkinsc...@googlegroups.com
 
Re: Error when selecting when / changeRequest or tag in the Directive Generator

Got it - PR up at https://github.com/jenkinsci/pipeline-model-definition-plugin/pull/261 fixing that and making a few other changes to when condition directive generation.

scm_issue_link@java.net (JIRA)

unread,
Apr 17, 2018, 1:33:02 PM4/17/18
to jenkinsc...@googlegroups.com

Code changed in jenkins
User: Andrew Bayer
Path:
pipeline-model-definition/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/generator/WhenDirective.java
pipeline-model-definition/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/when/impl/BuildingTagConditional.java
pipeline-model-definition/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/when/impl/ChangeRequestConditional.java
pipeline-model-definition/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/when/impl/TagConditional.java
pipeline-model-definition/src/main/resources/org/jenkinsci/plugins/pipeline/modeldefinition/generator/WhenDirective/config.jelly
pipeline-model-definition/src/main/resources/org/jenkinsci/plugins/pipeline/modeldefinition/when/impl/ChangeRequestConditional/config.jelly
http://jenkins-ci.org/commit/pipeline-model-definition-plugin/eac90be72124d7ef32d957af898a5eef913f478b
Log:
[FIXED JENKINS-50682] Actually pass descriptor to when condition forms

Also add display name for a few when conditions, move all of
ChangeRequestConditional's fields into advanced, since they're
optional and all, and smack things around a bit internally to not
display when directive parameters when they're not required and
they've got an empty string value.

andrew.bayer@gmail.com (JIRA)

unread,
Apr 17, 2018, 1:36:02 PM4/17/18
to jenkinsc...@googlegroups.com
 

Merged, releasing today in Declarative 1.2.9.
Change By: Andrew Bayer
Status: In Review Resolved
Resolution: Fixed

bitwiseman@gmail.com (JIRA)

unread,
Oct 22, 2019, 11:25:20 PM10/22/19
to jenkinsc...@googlegroups.com
Liam Newman closed an issue as Fixed
 

Bulk closing resolved issues.

Change By: Liam Newman
Status: Resolved Closed
This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)
Atlassian logo
Reply all
Reply to author
Forward
0 new messages