[JIRA] (JENKINS-60779) Pipeline Build Step: Remove Message converting string Parameter to Extensible Choice Parameter

13 views
Skip to first unread message

max.matissek@beitragsservice.de (JIRA)

unread,
Jan 15, 2020, 5:51:14 AM1/15/20
to jenkinsc...@googlegroups.com
Max Matissek created an issue
 
Jenkins / Bug JENKINS-60779
Pipeline Build Step: Remove Message converting string Parameter to Extensible Choice Parameter
Issue Type: Bug Bug
Assignee: Devin Nusbaum
Components: pipeline-build-step-plugin
Created: 2020-01-15 10:50
Priority: Trivial Trivial
Reporter: Max Matissek

The Pipeline build step logs a message after Updating zu Version 2.10.

Example:
Pipeline-Command: build job: 'testjob', parameters: [string(name: 'SELECTEDVERSION', value: artifactUrl)]

 
After the update of the "Pipeline: Build Step" Plugin to Verison 2.10 I get the Message "The parameter 'SELECTEDVERSION' did not have the type expected by testjob. Converting to Extensible Choice". 

There was suggestion to create a bug for that in JENKINS-60216.
 
Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)
Atlassian logo

dnusbaum@cloudbees.com (JIRA)

unread,
Jan 15, 2020, 10:59:08 AM1/15/20
to jenkinsc...@googlegroups.com
Devin Nusbaum commented on Bug JENKINS-60779
 
Re: Pipeline Build Step: Remove Message converting string Parameter to Extensible Choice Parameter

I think the best thing to do in this case would be to change to this block to not log anything or change the description when the class name of the parameter definition is ExtensibleChoiceParameterDefinition. It still makes sense to do the conversion, which IIUC goes through this code to make sure the specified parameter is one of the options, we just don't want to log a warning since the conversion is expected.

dnusbaum@cloudbees.com (JIRA)

unread,
Jan 15, 2020, 3:34:02 PM1/15/20
to jenkinsc...@googlegroups.com

Max Matissek This PR will eventually produce an incremental build of the plugin with the changes in the PR (I'll try to update the comment with a link later, but the link should be available from one of the GitHub statuses once the build passes). It would be great if you could test it out in a dev environment and let us know if it fixes the issue.

paul.thevenot@atos.net (JIRA)

unread,
Mar 4, 2020, 5:19:03 AM3/4/20
to jenkinsc...@googlegroups.com

I think the same warning is shown while using the [Active Choice Plugin|https://github.com/jenkinsci/active-choices-plugin] and it would make sense to add the following class org.biouno.unochoice.AbstractUnoChoiceParameter to the codition you added in your pull request (l180). I don't see how we could pass a parameter to this plugin whitout using a string parameter. What do you think? 
This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)
Atlassian logo

paul.thevenot@atos.net (JIRA)

unread,
Mar 9, 2020, 12:07:03 PM3/9/20
to jenkinsc...@googlegroups.com
Paul Thevenot edited a comment on Bug JENKINS-60779
I think the same warning is shown while using the [Active Choice Plugin|[https://github.com/jenkinsci/active-choices-plugin]] and it would make sense to add the following class classes org.biouno.unochoice.CascadeChoiceParameter,  org.biouno.unochoice. AbstractUnoChoiceParameter ChoiceParameter to the codition condition you added in your pull request (l180). I don't see how we could pass a parameter to this plugin whitout using a string parameter. What do you think? 

dnusbaum@cloudbees.com (JIRA)

unread,
Mar 12, 2020, 1:30:04 PM3/12/20
to jenkinsc...@googlegroups.com
Change By: Devin Nusbaum
Status: In Progress Review

dnusbaum@cloudbees.com (JIRA)

unread,
Mar 12, 2020, 1:30:04 PM3/12/20
to jenkinsc...@googlegroups.com
Devin Nusbaum commented on Bug JENKINS-60779
 
Re: Pipeline Build Step: Remove Message converting string Parameter to Extensible Choice Parameter

I added the the parameter definitions for Active Choices Plugin to the whitelist. Paul Thevenot Max Matissek If either of you is able test the proposed fix, here is a prerelease build of the plugin that includes the fix that you could install on your Jenkins instance.

dnusbaum@cloudbees.com (JIRA)

unread,
Mar 12, 2020, 1:30:05 PM3/12/20
to jenkinsc...@googlegroups.com
Devin Nusbaum started work on Bug JENKINS-60779
 
Change By: Devin Nusbaum
Status: Open In Progress

paul.thevenot@atos.net (JIRA)

unread,
Mar 13, 2020, 5:01:02 AM3/13/20
to jenkinsc...@googlegroups.com

Thanks Devin Nusbaum. I gave it a try for the Active Choices Plugin and it works well. No more warnings. I can't tell for the Extensible Choice Parameter plugin since I'm not using it. 

dnusbaum@cloudbees.com (JIRA)

unread,
Mar 13, 2020, 10:14:03 AM3/13/20
to jenkinsc...@googlegroups.com

Paul Thevenot Thanks for the feedback! I'll plan on releasing the fix sometime next week unless I get feedback that something is wrong with it.

dnusbaum@cloudbees.com (JIRA)

unread,
Mar 17, 2020, 4:55:03 PM3/17/20
to jenkinsc...@googlegroups.com
 

A fix for this issue was just released in Pipeline: Build Step Plugin version 2.12. Thanks Paul Thevenot for testing the fix!
Change By: Devin Nusbaum
Status: In Review Resolved
Resolution: Fixed
Released As: pipeline-build-step 2.12
Reply all
Reply to author
Forward
0 new messages