[JIRA] (JENKINS-59207) READONLY autoclean sync fails on reconcile

[dave@dsak.com (JIRA)]

Dave Miller created an issue

Jenkins / JENKINS-59207 READONLY autoclean sync fails on reconcile Issue Type: Bug Assignee: Unassigned Components: p4-plugin Created: 2019-09-03 18:16 Environment: Jenkins ver. 2.150.2 Plugin ver. 1.10.3 Priority: Major Reporter: Dave Miller When a READONLY client is synced with the "Auto cleanup and sync" option, the reconcile throws an innocuous "Client of type 'readonly' cannot modify files." error. In 1.10, this error is ignored. In 1.10.3, this error causes the build to fail. This may be a consequence of a modification to src/main/java/org/jenkinsci/plugins/p4/client/ClientHelper.java in Change 25759, which added an exception when a reconcile fails. Unfortunately, in the above scenario, reconcile shouldn't even be called, so the fact that it fails should be ignored. Add Comment

This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

[dwhitfield@perforce.com (JIRA)]

Doug Whitfield commented on JENKINS-59207

Re: READONLY autoclean sync fails on reconcile Issue introduced in 1.10.1, so does seem like 25759 is likely

Add Comment

This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)

[j.f.brown@sbcglobal.net (JIRA)]

Joel Brown commented on JENKINS-59207

Re: READONLY autoclean sync fails on reconcile

The fact the reconcile failure was ignored in an earlier release is a bug - the error should have been surfaced.   IMO, we fixed it the change you noted.   auto cleanup and sync should run "reconcile -w -f" to make the workspace consistent with the last sync.

Add Comment