[JIRA] (JENKINS-56896) Shutdown message 'INFOS: JVM is terminating. Shutting down Jetty' is shown randomly

[bmathus+ossjira@cloudbees.com (JIRA)]

Baptiste Mathus created an issue

Jenkins / JENKINS-56896 Shutdown message 'INFOS: JVM is terminating. Shutting down Jetty' is shown randomly Issue Type: Bug Assignee: Unassigned Components: winstone-jetty Created: 2019-04-05 07:43 Priority: Minor Reporter: Baptiste Mathus TODO Add Comment

This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

[bmathus+ossjira@cloudbees.com (JIRA)]

Baptiste Mathus updated an issue

Jenkins / JENKINS-56896 Shutdown message 'INFOS: JVM is terminating. Shutting down Jetty' is shown randomly

Change By: Baptiste Mathus TODO This is _funny_ issue I discovered recently after being pointed out by a customer. h3. How to reproduce * Start Jenkins * Wait a bit of time until it reaches full startup (no new log shown, generally ~30 to 60 seconds, say) * Stop it with a signal/Ctrl-C * See if the message is

Add Comment

[bmathus+ossjira@cloudbees.com (JIRA)]

Baptiste Mathus updated an issue

Jenkins / JENKINS-56896 Shutdown message 'INFOS: JVM is terminating. Shutting down Jetty' is shown randomly Change By: Baptiste Mathus

This is _funny_ issue I discovered recently after being pointed out by a customer. h3. How to reproduce * Start Jenkins * Wait a bit of time until it reaches full startup (no new log shown, generally ~30 to 60 seconds, say) * Stop it with a signal/Ctrl-C

* See if Doing this many times, see that the message {{NFOS: JVM is terminating. Shutting down Jetty}} is not shown consistently h3. Expected behavior The message should be always shown. h3. Aside This seems like this is not a big deal, given this has been this way for a long time, if not forever. I was able to reproduce it using even an old Jenkins 2.1: {{docker run jenkinsci/jenkins:2.1}}.

Add Comment

[bmathus+ossjira@cloudbees.com (JIRA)]

Baptiste Mathus updated an issue

Jenkins / JENKINS-56896 Shutdown message 'INFOS: JVM is terminating. Shutting down Jetty' is shown randomly Change By: Baptiste Mathus

This is _funny_ issue I discovered recently after being pointed out by a customer. h3. How to reproduce * Start Jenkins * Wait a bit of time until it reaches full startup (no new log shown, generally ~30 to 60 seconds, say) * Stop it with a signal/Ctrl-C

* Doing this many times, see that the message {{NFOS: JVM is terminating. Shutting down Jetty}} is not shown consistently

h3. Expected behavior The message should be always shown.

h3. Aside Asides

This seems like this is not a big deal, given this has been this way for a long time, if not forever. I was able to reproduce it using even an old Jenkins 2.1: {{docker run jenkinsci/jenkins:2.1}}.

Technically, after a small testing, the issue seems to be that when the ShutdownHook gets called, sometimes the _launcher_ is null ?!? https://github.com/jenkinsci/winstone/blob/79fb68763729c24fd70fcf6a1064c472b3a9ce66/src/main/java/winstone/ShutdownHook.java#L23

Add Comment

[bmathus+ossjira@cloudbees.com (JIRA)]

Baptiste Mathus updated an issue

Jenkins / JENKINS-56896 Shutdown message 'INFOS: JVM is terminating. Shutting down Jetty' is shown randomly Change By: Baptiste Mathus

This is _funny_ issue I discovered recently after being pointed out by a customer. h3. How to reproduce * Start Jenkins * Wait a bit of time until it reaches full startup (no new log shown, generally ~30 to 60 seconds, say) * Stop it with a signal/Ctrl-C

* Doing this many times, see that the message {{ NFOS INFOS : JVM is terminating. Shutting down Jetty}} is not shown consistently

h3. Expected behavior The message should be always shown.

h3. Asides

This seems like this is not a big deal, given this has been this way for a long time, if not forever. I was able to reproduce it using even an old Jenkins 2.1: {{docker run jenkinsci/jenkins:2.1}}. Technically, after a small testing, the issue seems to be that when the ShutdownHook gets called, sometimes the _launcher_ is null ?!? https://github.com/jenkinsci/winstone/blob/79fb68763729c24fd70fcf6a1064c472b3a9ce66/src/main/java/winstone/ShutdownHook.java#L23

Add Comment

[irc@webratz.de (JIRA)]

Andreas Sieferlinger commented on JENKINS-56896

Re: Shutdown message 'INFOS: JVM is terminating. Shutting down Jetty' is shown randomly seeing this problem also from time to time

Add Comment

[irc@webratz.de (JIRA)]

Andreas Sieferlinger commented on JENKINS-56896

Re: Shutdown message 'INFOS: JVM is terminating. Shutting down Jetty' is shown randomly

Overall the shutdown within the docker container seems not to be clean. According to https://github.com/jenkinsci/jenkins/blob/0c2d194f0d933fdba8f5a9a1fda8adc8826981c0/core/src/main/java/jenkins/model/Jenkins.java#L3313 there should be a message like "Stopping Jenkins" which does not appear at all (logger is configured to show INFO)

Add Comment

[irc@webratz.de (JIRA)]

Andreas Sieferlinger edited a comment on JENKINS-56896

Re: Shutdown message 'INFOS: JVM is terminating. Shutting down Jetty' is shown randomly

Seems to be there for quite a while already: [https://github.com/jenkinsci/docker/issues/321]

Overall the shutdown within the docker container seems not to be clean. According to [https://github.com/jenkinsci/jenkins/blob/0c2d194f0d933fdba8f5a9a1fda8adc8826981c0/core/src/main/java/jenkins/model/Jenkins.java#L3313] there should be a message like "Stopping Jenkins" which does not appear at all (logger is configured to show INFO)

Add Comment