[JIRA] (JENKINS-60624) Repo not maintained anymore?

10 views
Skip to first unread message

callum+jenkins@callumpember.com (JIRA)

unread,
Jan 2, 2020, 4:44:04 PM1/2/20
to jenkinsc...@googlegroups.com
Callum Pember created an issue
 
Jenkins / Bug JENKINS-60624
Repo not maintained anymore?
Issue Type: Bug Bug
Assignee: Rik Turnbull
Components: aws-parameter-store-plugin
Created: 2020-01-02 21:43
Priority: Minor Minor
Reporter: Callum Pember

Hi there,

I need some functionality added that's included in this PR: https://github.com/jenkinsci/aws-parameter-store-plugin/pull/3

I'm having trouble getting a review done on it. Is Rik Turnbull still active?

Thanks

Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)
Atlassian logo

rik@controlz.co.uk (JIRA)

unread,
Jan 4, 2020, 1:05:02 PM1/4/20
to jenkinsc...@googlegroups.com
Rik Turnbull commented on Bug JENKINS-60624
 
Re: Repo not maintained anymore?

Hi Callum, yes still here but just lacking the time to get in the headspace for this plugin. Luckily, New Year is quiet..

So, I had a look at your PR - and thanks for submitting, it has helped me understand a bit more about what's going on with the authentication.

It seems that as the AWS authentication always happens on the Jenkins master, where the plugin runs, then it can only ever use creds supplied in the credentials stores or the local Jenkins master AWS configuration (env vars, .aws files, IAM roles).

I did notice that the build job and pipeline environment variables are passed to the plugin though (via initialEnvironment), so rather than add a lot of new properties (as per your PR) I just modified the code to check this environment for the AWS_* environment variables. I then used the logic you had to determine the credentials provider.

Changes here: https://github.com/jenkinsci/aws-parameter-store-plugin/commit/1a824f82d9ea9526b7eb6ff3f2cfdff2d22260be

This should work for your requirements - if possible, can you check a custom build from this master branch? If not, I'll risk it and publish a new version.

Cheers!

callum+jenkins@callumpember.com (JIRA)

unread,
Jan 4, 2020, 4:28:03 PM1/4/20
to jenkinsc...@googlegroups.com

Hi Rik,

Thanks for checking out the PR and the amazingly fast turnaround!

I've just built master and tested the changes. It's working perfectly.

Thanks again!

Callum

rik@controlz.co.uk (JIRA)

unread,
Jan 5, 2020, 12:35:03 PM1/5/20
to jenkinsc...@googlegroups.com

Great! Thanks for testing Callum - I've released the changes now

 

Cheers, Rik.

 

callum+jenkins@callumpember.com (JIRA)

unread,
Jan 5, 2020, 7:30:04 PM1/5/20
to jenkinsc...@googlegroups.com
Callum Pember resolved as Fixed
Change By: Callum Pember
Status: Open Resolved
Resolution: Fixed

callum+jenkins@callumpember.com (JIRA)

unread,
Jan 5, 2020, 7:32:01 PM1/5/20
to jenkinsc...@googlegroups.com
Callum Pember closed an issue as Fixed
Change By: Callum Pember
Status: Resolved Closed
Reply all
Reply to author
Forward
0 new messages