[JIRA] (JENKINS-58835) recognize file's encodings

3 views
Skip to first unread message

ilatypov@yahoo.ca (JIRA)

unread,
Aug 6, 2019, 6:39:02 PM8/6/19
to jenkinsc...@googlegroups.com
Ilguiz Latypov created an issue
 
Jenkins / Improvement JENKINS-58835
recognize file's encodings
Issue Type: Improvement Improvement
Assignee: Unassigned
Components: workflow-basic-steps-plugin
Created: 2019-08-06 22:38
Priority: Minor Minor
Reporter: Ilguiz Latypov

It would be nice if the readFile basic step could recognize the file's encoding.  (Writing a file with writeFile can store a BOM at the beginning to help in recognizing the character set later, but this must be only a non-default option to preserve backward compatibility with earlier groovy code reading the created files.  This agrees with a rule of thumb "accept liberally, produce conservatively").

There is no need to reinvent the wheel.  Using (and white-listing) groovy.util.CharsetToolkit can make this easy.

 

https://github.com/groovy/groovy-core/blob/GROOVY_2_4_X/src/main/groovy/util/CharsetToolkit.java#L388

 

http://docs.groovy-lang.org/latest/html/api/groovy/util/CharsetToolkit.html#getReader()

 

https://github.com/jenkinsci/workflow-basic-steps-plugin/blob/workflow-basic-steps-2.18/src/main/java/org/jenkinsci/plugins/workflow/steps/ReadFileStep.java

 

Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

ilatypov@yahoo.ca (JIRA)

unread,
Aug 6, 2019, 6:41:02 PM8/6/19
to jenkinsc...@googlegroups.com
Reply all
Reply to author
Forward
0 new messages