[JIRA] (JENKINS-53708) Cannot use standard CSS comments

1 view
Skip to first unread message

mtdeguzis@geisigner.edu (JIRA)

unread,
Sep 21, 2018, 11:25:03 AM9/21/18
to jenkinsc...@googlegroups.com
Michael DeGuzis created an issue
 
Jenkins / Bug JENKINS-53708
Cannot use standard CSS comments
Issue Type: Bug Bug
Assignee: Tobias Gruetzmacher
Components: simple-theme-plugin
Created: 2018-09-21 15:24
Environment: Jenkins 2.138.1
Simple Theme Plugin 0.5.1
Priority: Minor Minor
Reporter: Michael DeGuzis

Multiline CSS comments or // comments do not work. They break the CSS I used to adjust the image:

Invalid:

body {
  background-color:  #feffd8;
}

/* Uncomment he below to change the logo image */
/*
  .logo img {
  content:url("https://host:8444/userContent/title.png");
}
*/

*/
login page - See: https://jenkins.io/blog/2018/06/27/new-login-page
See section for Login Theme plugin at Jenkins > Manage Jenkins
*/

.logo #jenkins-name-icon {
   content:url("https://host:8444/userContent/title.png");
   position: absolute;
   bottom: 3px;
   left: 40px;
   width: 220px;
}

.logo:after {
  // Use regular text instead of an image
  content: '';
  font-weight: bold;
  font-size: 20px;
  margin-left: 50px;
  margin-right: 12px;
  color: white;
  line-height: 40px;
}

Works:

body {
  background-color:  #feffd8;
}

.logo #jenkins-name-icon {
   content:url("https://host:8444/userContent/title.png");
   position: absolute;
   bottom: 3px;
   left: 40px;
   width: 220px;
}

.logo:after {
  // Use regular text instead of an image
  content: '';
  font-weight: bold;
  font-size: 20px;
  margin-left: 50px;
  margin-right: 12px;
  color: white;
  line-height: 40px;
}
Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

tobias-jenkins@23.gs (JIRA)

unread,
Oct 28, 2019, 4:18:03 PM10/28/19
to jenkinsc...@googlegroups.com
Tobias Gruetzmacher closed an issue as Not A Defect
 

1. CSS has no single-line (//) comments. Using them in CSS lets browsers ignore part of your CSS
2. The comments in your example are not paired up, they seems to work fine if used correctly...

Closing, since I don't see any issue here...
Change By: Tobias Gruetzmacher
Status: Open Closed
Resolution: Not A Defect
This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)
Atlassian logo
Reply all
Reply to author
Forward
0 new messages